re: media: rcar-vin: add group allocator functions

2018-05-02 Thread Colin Ian King
Hi there, Static analysis with CoverityScan picked up an explicit null pointer dereference in the the following commit: commit 3bb4c3bc85bf77a76c921671800bde2e1bf82a88 Author: Niklas Söderlund Date: Sat Apr 14 07:57:18 2018 -0400 media: rcar-vin: add group allocator functions in

Re: media: rcar-vin: add group allocator functions

2018-04-24 Thread Niklas Söderlund
Sat Apr 14 07:57:18 2018 -0400 > > media: rcar-vin: add group allocator functions > > The analysis is as follows: > > 339 static void rvin_group_put(struct rvin_dev *vin) > 340 { > 341mutex_lock(&vin->group->lock); > 342 >1. assign_zero: Assigning

re: media: rcar-vin: add group allocator functions

2018-04-24 Thread Colin Ian King
-vin: add group allocator functions The analysis is as follows: 339 static void rvin_group_put(struct rvin_dev *vin) 340 { 341mutex_lock(&vin->group->lock); 342 1. assign_zero: Assigning: vin->group = NULL. 343vin->group = NULL; 344vin->v4l2_dev.mdev