RE: mei: cancel stall timers in mei_reset

2013-11-09 Thread Eugene Shatokhin
Hi, >Looks like there is a hiccup in scheduling during resume and timer work is >kicked before its time and starts unnecessary the reset flow. >Can you check that the device is in good state (/mei/devastate , it >should be ENABLED). Yes, /sys/kernel/debug/mei/devstate contains "ENABLED"

RE: mei: cancel stall timers in mei_reset

2013-11-09 Thread Eugene Shatokhin
Hi, Looks like there is a hiccup in scheduling during resume and timer work is kicked before its time and starts unnecessary the reset flow. Can you check that the device is in good state (debugfs/mei/devastate , it should be ENABLED). Yes, /sys/kernel/debug/mei/devstate contains ENABLED

RE: mei: cancel stall timers in mei_reset

2013-11-07 Thread Winkler, Tomas
> -Original Message- > From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] > Sent: Thursday, November 07, 2013 08:38 > To: Winkler, Tomas > Cc: Usyskin, Alexander; Nicol? Costanza; Alex Burmashev; LKML > Subject: RE: mei: cancel stall timers in mei_reset >

RE: mei: cancel stall timers in mei_reset

2013-11-07 Thread Winkler, Tomas
-Original Message- From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] Sent: Thursday, November 07, 2013 08:38 To: Winkler, Tomas Cc: Usyskin, Alexander; Nicol? Costanza; Alex Burmashev; LKML Subject: RE: mei: cancel stall timers in mei_reset Hi, You can safely

RE: mei: cancel stall timers in mei_reset

2013-11-06 Thread Eugene Shatokhin
Hi, > You can safely comment out all of the timer_work. Well, I rebuilt the kernel with the schedule_... commented out (in mei_me_pci_resume(), for the present). The errors are no longer visible in the log. The full log is attached. Regards, Eugene system-log-20131107.tar.bz2 Description:

RE: mei: cancel stall timers in mei_reset

2013-11-06 Thread Winkler, Tomas
> -Original Message- > From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] > Sent: Wednesday, November 06, 2013 09:14 > To: Winkler, Tomas > Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML > Subject: Re: mei: cancel stall timers in mei_reset >

RE: mei: cancel stall timers in mei_reset

2013-11-06 Thread Winkler, Tomas
-Original Message- From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] Sent: Wednesday, November 06, 2013 09:14 To: Winkler, Tomas Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML Subject: Re: mei: cancel stall timers in mei_reset Hi, Please try

RE: mei: cancel stall timers in mei_reset

2013-11-06 Thread Eugene Shatokhin
Hi, You can safely comment out all of the timer_work. Well, I rebuilt the kernel with the schedule_... commented out (in mei_me_pci_resume(), for the present). The errors are no longer visible in the log. The full log is attached. Regards, Eugene system-log-20131107.tar.bz2 Description:

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
Hi, > Please try to comment out schedule_delayed_work(>timer_work, HZ); in pci-me.c You mean this call in mei_me_pci_resume() rather than in .probe, I suppose? There are two such calls in pci-me.c. Regards, Eugene -- Eugene Shatokhin, ROSA Laboratory. www.rosalab.com -- To unsubscribe

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
On 11/05/2013 03:49 PM, Winkler, Tomas wrote: This patches only catch the error, our goal is to discover why it is failing. I have just applied these error-handling-related patches to kernel 3.10.15 (without commenting out schedule_delayed_work(>timer_work, HZ) yet) and checked the system

RE: mei: cancel stall timers in mei_reset

2013-11-05 Thread Winkler, Tomas
> Hi, > > On 11/05/2013 01:58 PM, Usyskin, Alexander wrote: > > The problem that you found was fixed in patch here: > https://lkml.org/lkml/2013/6/23/169 > > And this patch merged into 3.11 according to http://lxr.free- > electrons.com/source/drivers/misc/mei/mei_dev.h?v=3.11 > > Can you

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
Hi, On 11/05/2013 01:58 PM, Usyskin, Alexander wrote: The problem that you found was fixed in patch here: https://lkml.org/lkml/2013/6/23/169 And this patch merged into 3.11 according to http://lxr.free-electrons.com/source/drivers/misc/mei/mei_dev.h?v=3.11 Can you re-check with latest 3.11

RE: mei: cancel stall timers in mei_reset

2013-11-05 Thread Usyskin, Alexander
Message- From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] Sent: Tuesday, November 05, 2013 10:07 To: Winkler, Tomas Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML Subject: Re: mei: cancel stall timers in mei_reset On 11/04/2013 07:48 PM, Eugene Shatokhin wrote

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
On 11/04/2013 07:48 PM, Eugene Shatokhin wrote: - Original Message - I would appreciate the full log and your .config I have attached the config and the log. Meanwhile, I have found one suspicious place in the code that could be related: mei_reset() ignores the return value of

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
On 11/04/2013 07:48 PM, Eugene Shatokhin wrote: - Original Message - I would appreciate the full log and your .config I have attached the config and the log. Meanwhile, I have found one suspicious place in the code that could be related: mei_reset() ignores the return value of

RE: mei: cancel stall timers in mei_reset

2013-11-05 Thread Usyskin, Alexander
Message- From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] Sent: Tuesday, November 05, 2013 10:07 To: Winkler, Tomas Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML Subject: Re: mei: cancel stall timers in mei_reset On 11/04/2013 07:48 PM, Eugene Shatokhin wrote

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
Hi, On 11/05/2013 01:58 PM, Usyskin, Alexander wrote: The problem that you found was fixed in patch here: https://lkml.org/lkml/2013/6/23/169 And this patch merged into 3.11 according to http://lxr.free-electrons.com/source/drivers/misc/mei/mei_dev.h?v=3.11 Can you re-check with latest 3.11

RE: mei: cancel stall timers in mei_reset

2013-11-05 Thread Winkler, Tomas
Hi, On 11/05/2013 01:58 PM, Usyskin, Alexander wrote: The problem that you found was fixed in patch here: https://lkml.org/lkml/2013/6/23/169 And this patch merged into 3.11 according to http://lxr.free- electrons.com/source/drivers/misc/mei/mei_dev.h?v=3.11 Can you re-check with

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
On 11/05/2013 03:49 PM, Winkler, Tomas wrote: This patches only catch the error, our goal is to discover why it is failing. I have just applied these error-handling-related patches to kernel 3.10.15 (without commenting out schedule_delayed_work(dev-timer_work, HZ) yet) and checked the system

Re: mei: cancel stall timers in mei_reset

2013-11-05 Thread Eugene Shatokhin
Hi, Please try to comment out schedule_delayed_work(dev-timer_work, HZ); in pci-me.c You mean this call in mei_me_pci_resume() rather than in .probe, I suppose? There are two such calls in pci-me.c. Regards, Eugene -- Eugene Shatokhin, ROSA Laboratory. www.rosalab.com -- To unsubscribe

RE: mei: cancel stall timers in mei_reset

2013-11-03 Thread Winkler, Tomas
> -Original Message- > From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] > Sent: Friday, November 01, 2013 14:27 > To: Winkler, Tomas > Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML > Subject: Re: mei: cancel stall timers in mei_reset >

RE: mei: cancel stall timers in mei_reset

2013-11-03 Thread Winkler, Tomas
-Original Message- From: Eugene Shatokhin [mailto:eugene.shatok...@rosalab.ru] Sent: Friday, November 01, 2013 14:27 To: Winkler, Tomas Cc: Usyskin, Alexander; Nicolò Costanza; Alex Burmashev; LKML Subject: Re: mei: cancel stall timers in mei_reset Hi, In case my previous

Re: mei: cancel stall timers in mei_reset

2013-11-01 Thread Eugene Shatokhin
Hi, In case my previous mail went to /dev/null, it is all about the flood of error messages in the system log, like these: mei_me :00:16.0: reset: wrong host start response mei_me :00:16.0: unexpected reset: dev_state = INIT_CLIENTS mei_me :00:16.0: reset: unexpected enumeration

Re: mei: cancel stall timers in mei_reset

2013-11-01 Thread Eugene Shatokhin
Hi, In case my previous mail went to /dev/null, it is all about the flood of error messages in the system log, like these: mei_me :00:16.0: reset: wrong host start response mei_me :00:16.0: unexpected reset: dev_state = INIT_CLIENTS mei_me :00:16.0: reset: unexpected enumeration

[ 17/52] mei: cancel stall timers in mei_reset

2013-10-02 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Usyskin commit 4a704575cc1afb3b848f096778fa9b8d7b3d5813 upstream. Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer ticking and hence avoid

[ 18/57] mei: cancel stall timers in mei_reset

2013-10-02 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Usyskin commit 4a704575cc1afb3b848f096778fa9b8d7b3d5813 upstream. Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer ticking and hence avoid

[ 18/57] mei: cancel stall timers in mei_reset

2013-10-02 Thread Greg Kroah-Hartman
3.11-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Usyskin alexander.usys...@intel.com commit 4a704575cc1afb3b848f096778fa9b8d7b3d5813 upstream. Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer

[ 17/52] mei: cancel stall timers in mei_reset

2013-10-02 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: Alexander Usyskin alexander.usys...@intel.com commit 4a704575cc1afb3b848f096778fa9b8d7b3d5813 upstream. Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer

[char-misc-next 3/3] mei: cancel stall timers in mei_reset

2013-09-02 Thread Tomas Winkler
From: Alexander Usyskin Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer ticking and hence avoid recursive reset calls. Cc: # 3.9+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/amthif.c | 1 +

[char-misc-next 3/3] mei: cancel stall timers in mei_reset

2013-09-02 Thread Tomas Winkler
From: Alexander Usyskin alexander.usys...@intel.com Unset init_clients_timer and amthif_stall_timers in mei_reset in order to cancel timer ticking and hence avoid recursive reset calls. Cc: sta...@vger.kernel.org # 3.9+ Signed-off-by: Alexander Usyskin alexander.usys...@intel.com Signed-off-by: