Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-24 Thread Paul E. McKenney
On Mon, Feb 24, 2014 at 01:32:54AM +0100, Stefan Richter wrote: > On Feb 23 Paul E. McKenney wrote: > >>> Please see below for a patch against the current version of > >>> Documentation/memory-barriers.txt. Does this update help? > > Thank you, this clarifies it. > > [...] > A new nit: > > +The

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-24 Thread Paul E. McKenney
On Sun, Feb 23, 2014 at 07:09:55PM -0500, Peter Hurley wrote: > On 02/23/2014 06:50 PM, Paul E. McKenney wrote: > >On Sun, Feb 23, 2014 at 03:35:31PM -0500, Peter Hurley wrote: > >>Hi Paul, > >> > >>On 02/23/2014 11:37 AM, Paul E. McKenney wrote: > >>>commit aba6b0e82c9de53eb032844f1932599f148ff68d

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-23 Thread Stefan Richter
On Feb 23 Paul E. McKenney wrote: >>> Please see below for a patch against the current version of >>> Documentation/memory-barriers.txt. Does this update help? Thank you, this clarifies it. [...] A new nit: > +The operations will always occur in one of the following orders: > > - STORE *A,

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-23 Thread Peter Hurley
On 02/23/2014 06:50 PM, Paul E. McKenney wrote: On Sun, Feb 23, 2014 at 03:35:31PM -0500, Peter Hurley wrote: Hi Paul, On 02/23/2014 11:37 AM, Paul E. McKenney wrote: commit aba6b0e82c9de53eb032844f1932599f148ff68d Author: Paul E. McKenney Date: Sun Feb 23 08:34:24 2014 -0800 Document

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-23 Thread Paul E. McKenney
On Sun, Feb 23, 2014 at 03:35:31PM -0500, Peter Hurley wrote: > Hi Paul, > > On 02/23/2014 11:37 AM, Paul E. McKenney wrote: > >commit aba6b0e82c9de53eb032844f1932599f148ff68d > >Author: Paul E. McKenney > >Date: Sun Feb 23 08:34:24 2014 -0800 > > > > Documentation/memory-barriers.txt: Clar

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-23 Thread Peter Hurley
Hi Paul, On 02/23/2014 11:37 AM, Paul E. McKenney wrote: commit aba6b0e82c9de53eb032844f1932599f148ff68d Author: Paul E. McKenney Date: Sun Feb 23 08:34:24 2014 -0800 Documentation/memory-barriers.txt: Clarify release/acquire ordering This commit fixes a couple of typos and clarif

Re: memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-23 Thread Paul E. McKenney
On Sun, Feb 23, 2014 at 02:23:03AM +0100, Stefan Richter wrote: > Hi Paul, > > in patch "Documentation/memory-barriers.txt: Downgrade UNLOCK+BLOCK" (sic), > you wrote: > + Memory operations issued before the LOCK may be completed after the > + LOCK operation has completed. An smp_mb__befo

memory-barriers.txt again (was Re: [PATCH 4/9] firewire: don't use PREPARE_DELAYED_WORK)

2014-02-22 Thread Stefan Richter
Hi Paul, in patch "Documentation/memory-barriers.txt: Downgrade UNLOCK+BLOCK" (sic), you wrote: + Memory operations issued before the LOCK may be completed after the + LOCK operation has completed. An smp_mb__before_spinlock(), combined + with a following LOCK, orders prior loads agai