[PATCH] drivers/media/usb: fix memory leak in zr364xx_probe

2021-03-01 Thread Pavel Skripkin
syzbot reported memory leak in zr364xx_probe()[1]. The problem was in invalid error handling order. All error conditions rigth after v4l2_ctrl_handler_init() must call v4l2_ctrl_handler_free(). Reported-by: syzbot+efe9aefc31ae1e6f7...@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin

Re: memory leak in zr364xx_probe

2021-01-05 Thread Andy Shevchenko
On Thu, Dec 31, 2020 at 05:47:20PM -0300, Ezequiel Garcia wrote: > Let's see if this works: > > #syz test: https://gitlab.collabora.com/linux/0day.git > a1714d224e516b579d09cc1b4c3d85042e42f14c Thanks for the hint! > On Wed, 23 Dec 2020 at 12:27, syzbot > wrote: > > > > Hello, > > > > syzbot fo

Re: memory leak in zr364xx_probe

2020-12-31 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: BUG: unable to handle kernel NULL pointer dereference in __videobuf_free zr364xx 4-1:0.0: model 06d6:003b detected usb 4-1: 320x240 mode selected zr364xx: start read pipe failed BUG: kernel NULL pointer

Re: memory leak in zr364xx_probe

2020-12-31 Thread Ezequiel Garcia
Let's see if this works: #syz test: https://gitlab.collabora.com/linux/0day.git a1714d224e516b579d09cc1b4c3d85042e42f14c On Wed, 23 Dec 2020 at 12:27, syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:3644e2d2 mm/filemap: fix infinite loop in generic_file_buf.

Re: memory leak in zr364xx_probe

2020-12-30 Thread Andy Shevchenko
On Wed, Dec 23, 2020 at 5:26 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:3644e2d2 mm/filemap: fix infinite loop in generic_file_buf.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=16f80eff50 > kernel config:

memory leak in zr364xx_probe

2020-12-23 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3644e2d2 mm/filemap: fix infinite loop in generic_file_buf.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16f80eff50 kernel config: https://syzkaller.appspot.com/x/.config?x=37c889fb8b2761af das