Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
>> * Would you like to add a tag “link”? > > Are you okay with this one? > https://lkml.org/lkml/2018/1/15/411 Yes. > - resend as v2 I was unsure about your patch handling from the previous replies. > Also, patch contains all your changes, so you should be credited > somehow - hence the

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
>> * Would you like to add a tag “link”? > > Are you okay with this one? > https://lkml.org/lkml/2018/1/15/411 Yes. > - resend as v2 I was unsure about your patch handling from the previous replies. > Also, patch contains all your changes, so you should be credited > somehow - hence the

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread Ladislav Michl
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote: > > dev_dbg(dev, > > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > > - ver, tll->nch); > > + ver, nch); > > break; > > Does this format

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread Ladislav Michl
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote: > > dev_dbg(dev, > > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > > - ver, tll->nch); > > + ver, nch); > > break; > > Does this format

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
> dev_dbg(dev, >"USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > - ver, tll->nch); > + ver, nch); > break; Does this format string need an other indentation when you touch this statement? Regards,

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
> dev_dbg(dev, >"USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > - ver, tll->nch); > + ver, nch); > break; Does this format string need an other indentation when you touch this statement? Regards,

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread Ladislav Michl
On Mon, Jan 15, 2018 at 08:04:03PM +0100, SF Markus Elfring wrote: > >> So I hope that your solution approach will be also fine. > >> Will it supersede my proposal? > > > > Who knows, perhaps it would be the best if you could judge yourself... > > I am also curious on how other contributors will

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread Ladislav Michl
On Mon, Jan 15, 2018 at 08:04:03PM +0100, SF Markus Elfring wrote: > >> So I hope that your solution approach will be also fine. > >> Will it supersede my proposal? > > > > Who knows, perhaps it would be the best if you could judge yourself... > > I am also curious on how other contributors will

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
>> So I hope that your solution approach will be also fine. >> Will it supersede my proposal? > > Who knows, perhaps it would be the best if you could judge yourself... I am also curious on how other contributors will respond to your following update suggestion. > 8< > > Subject:

Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe()

2018-01-15 Thread SF Markus Elfring
>> So I hope that your solution approach will be also fine. >> Will it supersede my proposal? > > Who knows, perhaps it would be the best if you could judge yourself... I am also curious on how other contributors will respond to your following update suggestion. > 8< > > Subject: