Re: mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Boris Brezillon
On Sun, 2018-12-02 at 08:33:58 UTC, Yangtao Li wrote: > DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change > to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a > standard macro. > > Signed-off-by: Yangtao Li Applied to http://git.infradead.org/linux-mtd.git mtd

Re: [PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Frank Lee
On Sun, Dec 2, 2018 at 4:40 PM Boris Brezillon wrote: > > Should be [PATCH v4] > > On Sun, 2 Dec 2018 03:33:58 -0500 > Yangtao Li wrote: > > > DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change > > to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a > > standard

Re: [PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Boris Brezillon
Should be [PATCH v4] On Sun, 2 Dec 2018 03:33:58 -0500 Yangtao Li wrote: > DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change > to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a > standard macro. You still don't put spaces after commas or periods > > Signe

[PATCH] mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it

2018-12-02 Thread Yangtao Li
DEFINE_SHOW_ATTRIBUTE macro can help us simplify the code,so change to it.And change the DEBUGFS_RO_ATTR macro defined in some file to a standard macro. Signed-off-by: Yangtao Li --- drivers/mtd/devices/docg3.c| 16 drivers/mtd/devices/docg3.h| 11 --- drivers/mt