Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Jens Axboe
the request before >> we attempt to dereference it. >> >> Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") >> Signed-off-by: Jens Axboe <ax...@fb.com> > > Looks fine: > > Reviewed-by: Christoph Hellwig <h...@lst.de> Pushed, thanks. -- Jens Axboe

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Jens Axboe
gt;> we attempt to dereference it. >> >> Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") >> Signed-off-by: Jens Axboe > > Looks fine: > > Reviewed-by: Christoph Hellwig Pushed, thanks. -- Jens Axboe

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Christoph Hellwig
dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") > Signed-off-by: Jens Axboe <ax...@fb.com> Looks fine: Reviewed-by: Christoph Hellwig <h...@lst.de>

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Christoph Hellwig
On Fri, Apr 21, 2017 at 08:14:03AM -0600, Jens Axboe wrote: > From: Jens Axboe > Subject: [PATCH] mtip32xx: fix dereference of stack garbage > > We need to get the command payload from the request before > we attempt to dereference it. > > Fixes: 4dda4735c581 ("mt

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Jens Axboe
] mtip32xx: fix dereference of stack garbage We need to get the command payload from the request before we attempt to dereference it. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Jens Axboe <ax...@fb.com> diff --git a/drivers/block/mtip32xx/mtip

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Jens Axboe
e of stack garbage We need to get the command payload from the request before we attempt to dereference it. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Jens Axboe diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32

re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Colin Ian King
Hi, CoverityScan found an issue with the following part of the patch: - if (likely(!reserv)) - blk_mq_complete_request(rq, -ENODEV); - else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, >port->flags)) { + if (likely(!reserv)) { + cmd->status = -ENODEV; +

re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Colin Ian King
Hi, CoverityScan found an issue with the following part of the patch: - if (likely(!reserv)) - blk_mq_complete_request(rq, -ENODEV); - else if (test_bit(MTIP_PF_IC_ACTIVE_BIT, >port->flags)) { + if (likely(!reserv)) { + cmd->status = -ENODEV; +