Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2016-02-29 Thread Peter Hurley
Hi Brian, On 02/28/2016 07:56 PM, Brian Bloniarz wrote: > (Take 3, fix compile error in n_hdlc.c) > > Hi Peter, I saw Marc Aurele La France's proposed patch to n_tty to fix > OpenSSH, and your feedback. Patch below is an attempt to address that > feedback. Please let me know if this is the change

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2016-02-28 Thread Brian Bloniarz
(Take 3, fix compile error in n_hdlc.c) Hi Peter, I saw Marc Aurele La France's proposed patch to n_tty to fix OpenSSH, and your feedback. Patch below is an attempt to address that feedback. Please let me know if this is the change you envisioned; (see Marc's excellent original writeup for details

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2016-02-28 Thread Brian Bloniarz
(Take 2, email client woes) Peter, I saw Marc Aurele La France's proposed patch to n_tty to fix OpenSSH, and your feedback. Patch below is an attempt to address that feedback. Please let me know if this is the change you envisioned. See Marc's excellent original writeup for details on the issue.

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2016-02-28 Thread Brian Bloniarz
Hi Peter, I saw Marc Aurele La France's proposed patch to n_tty to fix OpenSSH, and your feedback. Patch below is an attempt to address that feedback. Please let me know if this is the change you envisioned; (see Marc's excellent original writeup for details on the issue). [PATCH] n_tty: wait for

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-18 Thread Marc Aurele La France
On Fri, 18 Dec 2015, Peter Hurley wrote: On 12/18/2015 06:26 AM, Marc Aurele La France wrote: On Fri, 11 Dec 2015, Peter Hurley wrote: On 12/11/2015 05:37 AM, Marc Aurele La France wrote: I am not asking to read data before it has been produced. I am puzzled that despite knowing that the da

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-18 Thread Peter Hurley
Hi Marc, On 12/18/2015 06:26 AM, Marc Aurele La France wrote: > On Fri, 11 Dec 2015, Peter Hurley wrote: >> On 12/11/2015 05:37 AM, Marc Aurele La France wrote: > >>> I am not asking to read data before it has been produced. I am puzzled >>> that despite knowing that the data exists, I can now b

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-18 Thread Marc Aurele La France
On Fri, 11 Dec 2015, Peter Hurley wrote: On 12/11/2015 05:37 AM, Marc Aurele La France wrote: I am not asking to read data before it has been produced. I am puzzled that despite knowing that the data exists, I can now be lied to when I try to retrieve it, when I wasn't before. We are talking

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-11 Thread Peter Hurley
On 12/11/2015 05:37 AM, Marc Aurele La France wrote: > On Thu, 10 Dec 2015, Peter Hurley wrote: >> On 12/10/2015 02:48 PM, Marc Aurele La France wrote: >>> On Thu, 10 Dec 2015, Peter Hurley wrote: On 12/09/2015 01:06 PM, Marc Aurele La France wrote: > > After sshd has been SIGCHLD'ed abou

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-11 Thread Marc Aurele La France
On Thu, 10 Dec 2015, Peter Hurley wrote: On 12/10/2015 02:48 PM, Marc Aurele La France wrote: On Thu, 10 Dec 2015, Peter Hurley wrote: On 12/09/2015 01:06 PM, Marc Aurele La France wrote: After sshd has been SIGCHLD'ed about the shell's termination, it continues to read the master pty until

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-10 Thread Peter Hurley
On 12/10/2015 02:48 PM, Marc Aurele La France wrote: > On Thu, 10 Dec 2015, Peter Hurley wrote: >> On 12/09/2015 01:06 PM, Marc Aurele La France wrote: >>> The following four commits are some of the changes that have been made >>> to the tty layer since kernel version 3.11: > >>> 1) f95499c3030fe1

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-10 Thread Marc Aurele La France
On Thu, 10 Dec 2015, Peter Hurley wrote: > On 12/09/2015 01:06 PM, Marc Aurele La France wrote: >> The following four commits are some of the changes that have been made >> to the tty layer since kernel version 3.11: >> 1) f95499c3030fe1bfad57745f2db1959c5b43dca8 >> n_tty: Don't wait for buffe

Re: n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-10 Thread Peter Hurley
On 12/09/2015 01:06 PM, Marc Aurele La France wrote: > Greetings. > > The following four commits are some of the changes that have been made > to the tty layer since kernel version 3.11: > > 1) f95499c3030fe1bfad57745f2db1959c5b43dca8 > n_tty: Don't wait for buffer work in read() loop > > 2)

n_tty: Check the other end of pty pair before returning EAGAIN on a read()

2015-12-09 Thread Marc Aurele La France
Greetings. The following four commits are some of the changes that have been made to the tty layer since kernel version 3.11: 1) f95499c3030fe1bfad57745f2db1959c5b43dca8 n_tty: Don't wait for buffer work in read() loop 2) f8747d4a466ab2cafe56112c51b3379f9fdb7a12 tty: Fix pty master read(