Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-05 Thread Andy Shevchenko
On Tue, May 5, 2020 at 3:59 AM Dejin Zheng wrote: > On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > > (Markus is clearly not taking the hint, but FYI for everyone else:) > Brian, Thanks very much for your reminder, These comments have always > bothered me. Now I can put it on my b

Re: net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> Brian, Thanks very much for your reminder, Reminders can hopefully trigger positive effects. > These comments have always bothered me. Thanks for such information. > Now I can put it on my blacklist. I find it unfortunate that you choose to adjust your communication preferences in this dir

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Dejin Zheng
On Mon, May 04, 2020 at 10:03:59AM -0700, Brian Norris wrote: > (Markus is clearly not taking the hint, but FYI for everyone else:) > > On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > > BTW, In the past week, you asked me to change the commit comments in my > > > 6 patches like this one.

Re: net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> Markus is not really providing any value to the community. The opinions can vary also around my contributions. > Just search for his recent mail history -- it's all silly commit message > nitpicking of little value. I dare to point questionable implementation (and/or wording) details out. >

Re: net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> Markus is not really providing any value to the community. The opinions can vary also around my contributions. > Just search for his recent mail history -- it's all silly commit message > nitpicking of little value. I dare to point questionable implementation (and/or wording) details out. >

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Brian Norris
(Markus is clearly not taking the hint, but FYI for everyone else:) On Mon, May 4, 2020 at 8:00 AM Markus Elfring wrote: > > BTW, In the past week, you asked me to change the commit comments in my > > 6 patches like this one. Let me return to the essence of patch, point > > out the code problems

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
>>> the related system resources were not released when pci_iomap() return >>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to >>> fix it. >> >> How do you think about a wording variant like the following? >> >>Subject: >>[PATCH v2] net: rtw88: Complete exception ha

Re: [PATCH] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Markus Elfring
> the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. How do you think about a wording variant like the following? Subject: [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_i

RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Tony Chuang
> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources > > the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. > > Fixes: e3037485c68ec1a ("r

[PATCH net v1] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Dejin Zheng
the related system resources were not released when pci_iomap() return error in the rtw_pci_io_mapping() function. add pci_release_regions() to fix it. Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver") Cc: Andy Shevchenko Signed-off-by: Dejin Zheng --- drivers/net/wireless/realtek/r