Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Julia Lawall writes: > On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> >> Move the jump label directly before the desired log statement >> >> so that the variable "err" will not be checked once more >> >> after it was determined that a function call failed. >> >> Use the identifier

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Julia Lawall writes: > On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> >> Move the jump label directly before the desired log statement >> >> so that the variable "err" will not be checked once more >> >> after it was determined that a function call failed. >> >> Use the

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 4 January 2016 at 11:05, Arend van Spriel wrote: > On 03-01-16 16:18, Rafał Miłecki wrote: >> On 3 January 2016 at 10:36, Arend van Spriel wrote: >>> On 02-01-16 12:21, SF Markus Elfring wrote: > Did you look at the resulting assembly code for different target > architectures?

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 03-01-16 16:18, Rafał Miłecki wrote: > On 3 January 2016 at 10:36, Arend van Spriel wrote: >> On 02-01-16 12:21, SF Markus Elfring wrote: Did you look at the resulting assembly code for different target architectures? >>> >>> Not yet. - Which execution system variants would you

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 4 January 2016 at 11:05, Arend van Spriel wrote: > On 03-01-16 16:18, Rafał Miłecki wrote: >> On 3 January 2016 at 10:36, Arend van Spriel wrote: >>> On 02-01-16 12:21, SF Markus Elfring wrote: > Did you look at the resulting assembly code for

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 03-01-16 16:18, Rafał Miłecki wrote: > On 3 January 2016 at 10:36, Arend van Spriel wrote: >> On 02-01-16 12:21, SF Markus Elfring wrote: Did you look at the resulting assembly code for different target architectures? >>> >>> Not yet. - Which execution system

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 3 January 2016 at 10:36, Arend van Spriel wrote: > On 02-01-16 12:21, SF Markus Elfring wrote: >>> Did you look at the resulting assembly code for different target >>> architectures? >> >> Not yet. - Which execution system variants would you recommend for >> further comparisons? > > Guess

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>>> What the patch tries to do is avoid the extra 'if (err)'. >> >> Yes. - I propose to look at related consequences together with the usage >> of a popular short jump label once more. > > When I read a subject saying "Better exception handling" it sounds like > a functional improvement. Your

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 12:21, SF Markus Elfring wrote: >> I have never seen much evolution going on in this area. > > I can get an other impression from a specific document for example. > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > > >> What the patch

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 12:21, SF Markus Elfring wrote: >> I have never seen much evolution going on in this area. > > I can get an other impression from a specific document for example. > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > > >> What the patch

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 3 January 2016 at 10:36, Arend van Spriel wrote: > On 02-01-16 12:21, SF Markus Elfring wrote: >>> Did you look at the resulting assembly code for different target >>> architectures? >> >> Not yet. - Which execution system variants would you recommend for >> further

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>>> What the patch tries to do is avoid the extra 'if (err)'. >> >> Yes. - I propose to look at related consequences together with the usage >> of a popular short jump label once more. > > When I read a subject saying "Better exception handling" it sounds like > a functional improvement. Your

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

> I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> I assume that a software development taste can evolve, can't it? > > So far, you have gotten several down votes for this kind of change, I am curious when more contributors will share corresponding opinions. > and no enthusiasm. How many software designers and developers can become

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "err" will not be checked once more > >> after it was determined that a function call failed. > >> Use the identifier "report_failure" instead of the label

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > >Why? I suggest to reconsider the places

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> Move the jump label directly before the desired log statement >> so that the variable "err" will not be checked once more >> after it was determined that a function call failed. >> Use the identifier "report_failure" instead of the label "err". > >Why? I suggest to reconsider the places

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

> I have never seen much evolution going on in this area. I can get an other impression from a specific document for example. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle > What the patch tries to do is avoid the extra 'if (err)'. Yes. - I

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

On 02-01-16 10:08, SF Markus Elfring wrote: >>> I assume that a software development taste can evolve, can't it? >> >> So far, you have gotten several down votes for this kind of change, > > I am curious when more contributors will share corresponding opinions. Let's burn some cycles on this

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Sat, 2 Jan 2016, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "err" will not be checked once more > >> after it was determined that a function call failed. > >> Use the identifier "report_failure" instead of the label

Re: net-libertas: Better exception handling in if_spi_host_to_card_worker()

>> I assume that a software development taste can evolve, can't it? > > So far, you have gotten several down votes for this kind of change, I am curious when more contributors will share corresponding opinions. > and no enthusiasm. How many software designers and developers can become

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Hello On 1/2/2016 12:33 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 22:27:20 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "err" will not be checked once more

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Fri, 1 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 22:27:20 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "err" will not be checked once

[PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

From: Markus Elfring Date: Fri, 1 Jan 2016 22:27:20 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "err" will not be checked once more after it was determined that a function call failed. Use the

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

On Fri, 1 Jan 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 22:27:20 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Hello On 1/2/2016 12:33 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 1 Jan 2016 22:27:20 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "err"

[PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

From: Markus Elfring Date: Fri, 1 Jan 2016 22:27:20 +0100 This issue was detected by using the Coccinelle software. Move the jump label directly before the desired log statement so that the variable "err" will not be checked once more after it was determined that