Re: nfsv2 ref leak in 2.6.24?

2007-10-21 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > > On Sat, 2007-10-20 at 17:35 -0400, Erez Zadok wrote: > > > Trond, I verified that w/ the above patch the problem is w/ nfs: the client > > leaves .nfsXXX files behind for every file unlinked while open. Let me know > > when you get a fi

Re: nfsv2 ref leak in 2.6.24?

2007-10-21 Thread Trond Myklebust
On Sat, 2007-10-20 at 17:35 -0400, Erez Zadok wrote: > Trond, I verified that w/ the above patch the problem is w/ nfs: the client > leaves .nfsXXX files behind for every file unlinked while open. Let me know > when you get a fix and I'll test it. Doh... Another typo. Trond ---

Re: nfsv2 ref leak in 2.6.24?

2007-10-20 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Erez Zadok writes: > In message <[EMAIL PROTECTED]>, Trond Myklebust writes: [...] > > Looking at > > nfs_proc_create(), there is indeed a missing call to > > nfs_mark_for_revalidate(). The reason why you need such a call being the > > usual one: NFSv2 doesn't provid

Re: nfsv2 ref leak in 2.6.24?

2007-10-20 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > > On Fri, 2007-10-19 at 22:33 -0400, Erez Zadok wrote: > > Trond, good news. I was able to narrow down the problem to purely the > > client-side, probably dcache/readdir related, and I have a shell script that > > deterministically trigger

Re: nfsv2 ref leak in 2.6.24?

2007-10-20 Thread Trond Myklebust
On Fri, 2007-10-19 at 22:33 -0400, Erez Zadok wrote: > Trond, good news. I was able to narrow down the problem to purely the > client-side, probably dcache/readdir related, and I have a shell script that > deterministically triggers the problem each time for me (this is a FC6 image > under Vmware

Re: nfsv2 ref leak in 2.6.24?

2007-10-19 Thread Erez Zadok
Trond, good news. I was able to narrow down the problem to purely the client-side, probably dcache/readdir related, and I have a shell script that deterministically triggers the problem each time for me (this is a FC6 image under Vmware 6.0.1). Here's a short shell script which reliably triggers

Re: nfsv2 ref leak in 2.6.24?

2007-10-19 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > > On Fri, 2007-10-19 at 17:40 -0400, Erez Zadok wrote: [...] > > Trond, I was able to narrow down the problem w/o using unionfs at all (yay! > > :-). All I do is setup a loop device, mkfs it as ext2, mount it, then > > export it to localho

Re: nfsv2 ref leak in 2.6.24?

2007-10-19 Thread Trond Myklebust
On Fri, 2007-10-19 at 17:40 -0400, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > > > > On Fri, 2007-10-19 at 01:49 -0400, Erez Zadok wrote: > > > I'm testing unionfs on top of nfsv2/3/4, using 2.6.24 as of linus's commit > > > 4fa4d23fa20de67df919030c1216295664866a

Re: nfsv2 ref leak in 2.6.24?

2007-10-19 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Trond Myklebust writes: > > On Fri, 2007-10-19 at 01:49 -0400, Erez Zadok wrote: > > I'm testing unionfs on top of nfsv2/3/4, using 2.6.24 as of linus's commit > > 4fa4d23fa20de67df919030c1216295664866ad7. A lot of my unionfs regression > > tests are failing on nfs

Re: nfsv2 ref leak in 2.6.24?

2007-10-19 Thread Trond Myklebust
On Fri, 2007-10-19 at 01:49 -0400, Erez Zadok wrote: > I'm testing unionfs on top of nfsv2/3/4, using 2.6.24 as of linus's commit > 4fa4d23fa20de67df919030c1216295664866ad7. A lot of my unionfs regression > tests are failing on nfs2, b/c files that should be deleted, aren't. It > feels like ther

nfsv2 ref leak in 2.6.24?

2007-10-18 Thread Erez Zadok
I'm testing unionfs on top of nfsv2/3/4, using 2.6.24 as of linus's commit 4fa4d23fa20de67df919030c1216295664866ad7. A lot of my unionfs regression tests are failing on nfs2, b/c files that should be deleted, aren't. It feels like there may be a ref leak that prevents the files from being deleted