Re: ns558 pci/isa change

2000-11-13 Thread Jeff Garzik
Pete Wyckoff wrote: > i = pci_module_init(&ns558_pci_driver); > if (i == 0) > have_pci_devices = 1; > > /* > * Probe for ISA ports. > */ > > + i = 0; you don't want to lose the error code. what you want to do is something like the attached patch... -

ns558 pci/isa change

2000-11-13 Thread Pete Wyckoff
My joystick stopped working at 2.4.0-test10 due to a patch to drivers/char/joystick/ns558.c that moves pci probing ahead of isa probing. The problem is that pci_module_init can return -ENODEV into i, which is then used to index the ISA portlist. ISA probing assumes that i is initialized to zero.