Re: oom-kill && frozen()

2013-11-13 Thread Oleg Nesterov
On 11/13, Peter Zijlstra wrote: > > On Wed, Nov 13, 2013 at 06:07:24PM +0100, Oleg Nesterov wrote: > > 4. Finally, change try_to_wake_up() path to do > > > > - p->state = TASK_WAKING; > > + p->state &= ~state; > > + if (p->state &

Re: oom-kill && frozen()

2013-11-13 Thread Peter Zijlstra
On Wed, Nov 13, 2013 at 06:07:24PM +0100, Oleg Nesterov wrote: > 4. Finally, change try_to_wake_up() path to do > > - p->state = TASK_WAKING; > + p->state &= ~state; > + if (p->state & ~(TASK_DEAD | TASK_WAKEKILL | > TASK_PARKED))

Re: oom-kill && frozen()

2013-11-13 Thread Oleg Nesterov
On 11/13, Tejun Heo wrote: > > Hello, > > On Tue, Nov 12, 2013 at 05:56:43PM +0100, Oleg Nesterov wrote: > > On 11/12, Oleg Nesterov wrote: > > > I am also wondering if it makes any sense to turn PF_FROZEN into > > > TASK_FROZEN, something like (incomplete, probably racy) patch below. > > > Note

Re: oom-kill frozen()

2013-11-13 Thread Oleg Nesterov
On 11/13, Tejun Heo wrote: Hello, On Tue, Nov 12, 2013 at 05:56:43PM +0100, Oleg Nesterov wrote: On 11/12, Oleg Nesterov wrote: I am also wondering if it makes any sense to turn PF_FROZEN into TASK_FROZEN, something like (incomplete, probably racy) patch below. Note that it actually

Re: oom-kill frozen()

2013-11-13 Thread Peter Zijlstra
On Wed, Nov 13, 2013 at 06:07:24PM +0100, Oleg Nesterov wrote: 4. Finally, change try_to_wake_up() path to do - p-state = TASK_WAKING; + p-state = ~state; + if (p-state ~(TASK_DEAD | TASK_WAKEKILL | TASK_PARKED))

Re: oom-kill frozen()

2013-11-13 Thread Oleg Nesterov
On 11/13, Peter Zijlstra wrote: On Wed, Nov 13, 2013 at 06:07:24PM +0100, Oleg Nesterov wrote: 4. Finally, change try_to_wake_up() path to do - p-state = TASK_WAKING; + p-state = ~state; + if (p-state ~(TASK_DEAD |

Re: oom-kill && frozen()

2013-11-12 Thread Tejun Heo
Hello, On Tue, Nov 12, 2013 at 05:56:43PM +0100, Oleg Nesterov wrote: > On 11/12, Oleg Nesterov wrote: > > I am also wondering if it makes any sense to turn PF_FROZEN into > > TASK_FROZEN, something like (incomplete, probably racy) patch below. > > Note that it actually adds the new state, not

oom-kill && frozen()

2013-11-12 Thread Oleg Nesterov
On 11/12, Oleg Nesterov wrote: > > I am also wondering if it makes any sense to turn PF_FROZEN into > TASK_FROZEN, something like (incomplete, probably racy) patch below. > Note that it actually adds the new state, not the the qualifier. As for the current usage of PF_FROZEN... David, it seems

oom-kill frozen()

2013-11-12 Thread Oleg Nesterov
On 11/12, Oleg Nesterov wrote: I am also wondering if it makes any sense to turn PF_FROZEN into TASK_FROZEN, something like (incomplete, probably racy) patch below. Note that it actually adds the new state, not the the qualifier. As for the current usage of PF_FROZEN... David, it seems that

Re: oom-kill frozen()

2013-11-12 Thread Tejun Heo
Hello, On Tue, Nov 12, 2013 at 05:56:43PM +0100, Oleg Nesterov wrote: On 11/12, Oleg Nesterov wrote: I am also wondering if it makes any sense to turn PF_FROZEN into TASK_FROZEN, something like (incomplete, probably racy) patch below. Note that it actually adds the new state, not the the