Re: oopses in test10-pre4 (was Re: [RFC] atomic pte updates and paechanges, take 3)

2000-10-20 Thread Ben LaHaise
On Thu, 19 Oct 2000, Linus Torvalds wrote: > I think you overlooked the fact that SHM mappings use the page cache, and > it's ok if such pages are dirty and writable - they will get written out > by the shm_swap() logic once there are no mappings active any more. > > I like the test per se,

Re: oopses in test10-pre4 (was Re: [RFC] atomic pte updates and paechanges, take 3)

2000-10-20 Thread Linus Torvalds
On Fri, 20 Oct 2000, Ben LaHaise wrote: > > The primary reason I added the BUG was that if this is valid, it means > that the pte has to be removed from the page tables first with > pte_get_and_clear since it can be modified by the other CPU. Although > this may be safe for shm, I think it's v

oopses in test10-pre4 (was Re: [RFC] atomic pte updates and paechanges, take 3)

2000-10-19 Thread Linus Torvalds
Ben, you added these two BUG() conditions in your atomic pte patch: > diff -ur v2.4.0-test10-pre2/mm/vmscan.c work-10-2/mm/vmscan.c > --- v2.4.0-test10-pre2/mm/vmscan.cFri Oct 13 17:18:37 2000 > +++ work-10-2/mm/vmscan.c Fri Oct 13 17:19:47 2000 > @@ -99,6 +98,10 @@ > if (PageSwa