Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-08 Thread Nick Piggin
On Saturday 08 September 2007 19:43, Goswin von Brederlow wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > Lustre should probably have to be ported over to write_begin/write_end in > > order to use it too. With the patches in -mm, if a filesystem is still > > using prepare_write/commit_write,

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-08 Thread Goswin von Brederlow
Nick Piggin <[EMAIL PROTECTED]> writes: > Lustre should probably have to be ported over to write_begin/write_end in > order to use it too. With the patches in -mm, if a filesystem is still using > prepare_write/commit_write, the vm reverts to a safe path which avoids > the deadlock (and allows

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-08 Thread Goswin von Brederlow
Nick Piggin [EMAIL PROTECTED] writes: Lustre should probably have to be ported over to write_begin/write_end in order to use it too. With the patches in -mm, if a filesystem is still using prepare_write/commit_write, the vm reverts to a safe path which avoids the deadlock (and allows

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-08 Thread Nick Piggin
On Saturday 08 September 2007 19:43, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: Lustre should probably have to be ported over to write_begin/write_end in order to use it too. With the patches in -mm, if a filesystem is still using prepare_write/commit_write, the vm

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 17:25, Nick Piggin wrote: > On Saturday 08 September 2007 07:12, Goswin von Brederlow wrote: > > Nick Piggin <[EMAIL PROTECTED]> writes: > > > On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: > > >> b) a segment boundary > > > > > > This is done, as

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 07:12, Goswin von Brederlow wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: > >> b) a segment boundary > > > > This is done, as I said, because of the deadlock issue. While the issue > > is more

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 07:00, Goswin von Brederlow wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > Anyway, there are fixes for this deadlock in Andrew's -mm tree, but > > also a workaround for the NFSD problem in git commit 29dbb3fc. Did > > you try a later kernel to see if it is fixed

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin <[EMAIL PROTECTED]> writes: > On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: >> Nick Piggin <[EMAIL PROTECTED]> writes: >> > So I believe the problem is that for a multi-segment iovec, we currently >> > prepare_write/commit_write once for each segment, right? We do

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin <[EMAIL PROTECTED]> writes: > Anyway, there are fixes for this deadlock in Andrew's -mm tree, but > also a workaround for the NFSD problem in git commit 29dbb3fc. Did > you try a later kernel to see if it is fixed there? I had a chance to look up that commit (git clone took a while

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin <[EMAIL PROTECTED]> writes: > On Thursday 06 September 2007 03:41, Bernd Schubert wrote: > Minor nit: when resubmitting a patch, you should include everything > (ie. the full changelog of problem statement and fix description) in a > single mail. It's just a bit easier... Will do

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > On Thursday 06 September 2007 03:41, Bernd Schubert wrote: > > Minor nit: when resubmitting a patch, you should include everything > > (ie. the full changelog of problem statement and fix

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Thursday 06 September 2007 03:41, Bernd Schubert wrote: > > This comment block should be: > > > > /** > > * generic_file_buffered_write - handle an iov > > * @iocb: file operations > > * @iov:vector of data to write > > * @nr_segs:number of iov segments > > * @pos:

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Thursday 06 September 2007 03:41, Bernd Schubert wrote: This comment block should be: /** * generic_file_buffered_write - handle an iov * @iocb: file operations * @iov:vector of data to write * @nr_segs:number of iov segments * @pos:position in the file

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: On Thursday 06 September 2007 03:41, Bernd Schubert wrote: Minor nit: when resubmitting a patch, you should include everything (ie. the full changelog of problem statement and fix

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin [EMAIL PROTECTED] writes: On Thursday 06 September 2007 03:41, Bernd Schubert wrote: Minor nit: when resubmitting a patch, you should include everything (ie. the full changelog of problem statement and fix description) in a single mail. It's just a bit easier... Will do next

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin [EMAIL PROTECTED] writes: Anyway, there are fixes for this deadlock in Andrew's -mm tree, but also a workaround for the NFSD problem in git commit 29dbb3fc. Did you try a later kernel to see if it is fixed there? I had a chance to look up that commit (git clone took a while so

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Goswin von Brederlow
Nick Piggin [EMAIL PROTECTED] writes: On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: So I believe the problem is that for a multi-segment iovec, we currently prepare_write/commit_write once for each segment, right? We do this It is

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 07:00, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: Anyway, there are fixes for this deadlock in Andrew's -mm tree, but also a workaround for the NFSD problem in git commit 29dbb3fc. Did you try a later kernel to see if it is fixed there?

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 07:12, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: b) a segment boundary This is done, as I said, because of the deadlock issue. While the issue is more completely

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-07 Thread Nick Piggin
On Saturday 08 September 2007 17:25, Nick Piggin wrote: On Saturday 08 September 2007 07:12, Goswin von Brederlow wrote: Nick Piggin [EMAIL PROTECTED] writes: On Saturday 08 September 2007 06:01, Goswin von Brederlow wrote: b) a segment boundary This is done, as I said, because of

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-05 Thread Bernd Schubert
Hello Randy, thanks for your review. On Wednesday 05 September 2007 17:35:29 Randy Dunlap wrote: > On Wed, 5 Sep 2007 15:45:36 +0200 Bernd Schubert wrote: > > Hi, > > meta-comments: > > filemap.c | 144 > > +- > > 1 file changed, 96

Re: patch: improve generic_file_buffered_write() (2nd try 1/2)

2007-09-05 Thread Bernd Schubert
Hello Randy, thanks for your review. On Wednesday 05 September 2007 17:35:29 Randy Dunlap wrote: On Wed, 5 Sep 2007 15:45:36 +0200 Bernd Schubert wrote: Hi, meta-comments: filemap.c | 144 +- 1 file changed, 96