Re: patch "staging: remove nokia_hp4p driver

2014-12-03 Thread Pavel Machek
Hi! > > "These are a lot of public functions. Are they all really needed or can > > the code be done smart." > > > > in TODO file. > > so what about all the other really major details that needed fixing. I mean > anybody who was compiling for OMAP platform could have fixed the tons and > tons

Re: patch staging: remove nokia_hp4p driver

2014-12-03 Thread Pavel Machek
Hi! These are a lot of public functions. Are they all really needed or can the code be done smart. in TODO file. so what about all the other really major details that needed fixing. I mean anybody who was compiling for OMAP platform could have fixed the tons and tons of inlines

Re: patch "staging: remove nokia_hp4p driver

2014-09-04 Thread Pavel Machek
Hi! > >> There are 3 major topics that needs addressing before this driver should > >> come anywhere near upstream kernel again, staging or otherwise. > >> > >> a) Convert to using device tree for device detection > >> > >> b) Convert to using hdev->setup for firmware loading > >> > >> c)

Re: patch staging: remove nokia_hp4p driver

2014-09-04 Thread Pavel Machek
Hi! There are 3 major topics that needs addressing before this driver should come anywhere near upstream kernel again, staging or otherwise. a) Convert to using device tree for device detection b) Convert to using hdev-setup for firmware loading c) Convert to using

Re: patch "staging: remove nokia_hp4p driver

2014-09-01 Thread Marcel Holtmann
Hi Pavel, > What is going on here? I get flamed for not cleaning up the driver, > because I cleaned it up before merging to -staging. Ok, so I did more > cleanups, sent 3 cleanup patches, no reaction on those, and now I got > a note that you are going to remove the driver...?

Re: patch staging: remove nokia_hp4p driver

2014-09-01 Thread Marcel Holtmann
Hi Pavel, What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that you are going to remove the driver...? For the 3 cleanup

Re: patch "staging: remove nokia_hp4p driver

2014-08-31 Thread Pavel Machek
Hi! > >>> What is going on here? I get flamed for not cleaning up the driver, > >>> because I cleaned it up before merging to -staging. Ok, so I did more > >>> cleanups, sent 3 cleanup patches, no reaction on those, and now I got > >>> a note that you are going to remove the driver...? > >> > >>

Re: patch "staging: remove nokia_hp4p driver

2014-08-31 Thread Pavel Machek
Hi! > > > > What is going on here? I get flamed for not cleaning up the driver, > > > > because I cleaned it up before merging to -staging. Ok, so I did more > > > > cleanups, sent 3 cleanup patches, no reaction on those, and now I got > > > > a note that you are going to remove the driver...? >

Re: patch "staging: remove nokia_hp4p driver

2014-08-31 Thread Pali Rohár
On Sunday 31 August 2014 01:09:01 Marcel Holtmann wrote: > Hi Pavel, > > >>> What is going on here? I get flamed for not cleaning up > >>> the driver, because I cleaned it up before merging to > >>> -staging. Ok, so I did more cleanups, sent 3 cleanup > >>> patches, no reaction on those, and now

Re: patch staging: remove nokia_hp4p driver

2014-08-31 Thread Pali Rohár
On Sunday 31 August 2014 01:09:01 Marcel Holtmann wrote: Hi Pavel, What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that

Re: patch staging: remove nokia_hp4p driver

2014-08-31 Thread Pavel Machek
Hi! What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that you are going to remove the driver...? For the 3

Re: patch staging: remove nokia_hp4p driver

2014-08-31 Thread Pavel Machek
Hi! What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that you are going to remove the driver...? For the 3 cleanup

Re: patch "staging: remove nokia_hp4p driver

2014-08-30 Thread Marcel Holtmann
Hi Pavel, >>> What is going on here? I get flamed for not cleaning up the driver, >>> because I cleaned it up before merging to -staging. Ok, so I did more >>> cleanups, sent 3 cleanup patches, no reaction on those, and now I got >>> a note that you are going to remove the driver...? >> >> For

Re: patch "staging: remove nokia_hp4p driver

2014-08-30 Thread Greg KH
On Sun, Aug 31, 2014 at 12:44:30AM +0200, Pavel Machek wrote: > Hi! > > > > > > > What is going on here? I get flamed for not cleaning up the driver, > > > because I cleaned it up before merging to -staging. Ok, so I did more > > > cleanups, sent 3 cleanup patches, no reaction on those, and now

Re: patch "staging: remove nokia_hp4p driver

2014-08-30 Thread Pavel Machek
Hi! > > > > What is going on here? I get flamed for not cleaning up the driver, > > because I cleaned it up before merging to -staging. Ok, so I did more > > cleanups, sent 3 cleanup patches, no reaction on those, and now I got > > a note that you are going to remove the driver...? > > For the

Re: patch "staging: remove nokia_hp4p driver

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 11:30:22PM +0200, Pavel Machek wrote: > Hi! > > > This is a note to let you know that I've just added the patch titled > > > > staging: remove nokia_hp4p driver > > -Re: [PATCH v6] Bluetooth: Add hci_h4p driver > > > > to my staging git tree which can be found at > >

Re: patch "staging: remove nokia_hp4p driver

2014-08-30 Thread Pavel Machek
Hi! > This is a note to let you know that I've just added the patch titled > > staging: remove nokia_hp4p driver > -Re: [PATCH v6] Bluetooth: Add hci_h4p driver > > to my staging git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > in the

Re: patch staging: remove nokia_hp4p driver

2014-08-30 Thread Pavel Machek
Hi! This is a note to let you know that I've just added the patch titled staging: remove nokia_hp4p driver -Re: [PATCH v6] Bluetooth: Add hci_h4p driver to my staging git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git in the

Re: patch staging: remove nokia_hp4p driver

2014-08-30 Thread Greg KH
On Sat, Aug 30, 2014 at 11:30:22PM +0200, Pavel Machek wrote: Hi! This is a note to let you know that I've just added the patch titled staging: remove nokia_hp4p driver -Re: [PATCH v6] Bluetooth: Add hci_h4p driver to my staging git tree which can be found at

Re: patch staging: remove nokia_hp4p driver

2014-08-30 Thread Pavel Machek
Hi! What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that you are going to remove the driver...? For the 3 cleanup

Re: patch staging: remove nokia_hp4p driver

2014-08-30 Thread Greg KH
On Sun, Aug 31, 2014 at 12:44:30AM +0200, Pavel Machek wrote: Hi! What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a

Re: patch staging: remove nokia_hp4p driver

2014-08-30 Thread Marcel Holtmann
Hi Pavel, What is going on here? I get flamed for not cleaning up the driver, because I cleaned it up before merging to -staging. Ok, so I did more cleanups, sent 3 cleanup patches, no reaction on those, and now I got a note that you are going to remove the driver...? For the 3 cleanup