Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking

2008-02-20 Thread Greg KH
On Wed, Feb 20, 2008 at 09:56:28AM +0200, Adrian Bunk wrote: > On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote: > > On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote: > > > The Coverity checker spotted the following inconsequent NULL checking > > > introduced by commit 3c75e23784

Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking

2008-02-19 Thread Adrian Bunk
On Tue, Feb 19, 2008 at 09:47:58PM -0800, Greg KH wrote: > On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote: > > The Coverity checker spotted the following inconsequent NULL checking > > introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb: > > > > <-- snip --> > > > > ...

Re: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking

2008-02-19 Thread Greg KH
On Tue, Feb 19, 2008 at 09:29:02PM +0200, Adrian Bunk wrote: > The Coverity checker spotted the following inconsequent NULL checking > introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb: > > <-- snip --> > > ... > int aer_osc_setup(struct pcie_device *pciedev) > { > ...v

pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking

2008-02-19 Thread Adrian Bunk
The Coverity checker spotted the following inconsequent NULL checking introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb: <-- snip --> ... int aer_osc_setup(struct pcie_device *pciedev) { ...v while (pdev->bus && pdev->bus->self) pdev = pd