The port close_delay and closing_wait parameters have already been by
tty_port_init() so drop the redundant driver initialisation to the
default values.
Signed-off-by: Johan Hovold
---
drivers/char/pcmcia/synclink_cs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/pcmcia
ws:
>
> p_drv = to_pcmcia_drv(dev->driver);
>
> and to_pcmcia_drv is a container_of operation on struct
> pcmcia_driver::drv which isn't the first member in struct
> pcmcia_driver.)
>
> Signed-off-by: Uwe Kleine-König
Applied to pcmcia-next, thanks.
Dominik
Am Fri, Mar 12, 2021 at 11:02:33AM + schrieb Lee Jones:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (6):
> pcmcia: rsrc_nonstatic: Demote
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/cistpl.c:88: warning: Function parameter or member 's' not
described in 'set_cis_map'
drivers/pcmcia/cistpl.c:88: warning: Function parameter or member
'card_offset' not described in 'set_c
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (6):
pcmcia: rsrc_nonstatic: Demote kernel-doc abuses
pcmcia: cistpl: Demote non-conformant kernel-doc headers to standard
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/rsrc_nonstatic.c:265: warning: Function parameter or member 's'
not described in 'readable'
drivers/pcmcia/rsrc_nonstatic.c:265: warning: Function parameter or member
'res' not described
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/pcmcia_resource.c:160: warning: Function parameter or member
'p_dev' not described in 'pcmcia_access_config'
drivers/pcmcia/pcmcia_resource.c:160: warning: Function parameter or member
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/rsrc_nonstatic.c:349: warning: Function parameter or member
'value' not described in 'do_validate_mem'
drivers/pcmcia/rsrc_nonstatic.c:349: warning: Excess function parameter
'validate' description
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/ds.c:96: warning: expecting prototype for
pcmcia_store_new_id(). Prototype was for new_id_store() instead
Cc: Dominik Brodowski
Cc: dahi...@users.sourceforge.net
Signed-off-by: Lee Jones
---
drivers/pcmcia/ds.c | 2 +-
1 file
Fixes the following W=1 kernel build warning(s):
drivers/pcmcia/pcmcia_cis.c:129: warning: Function parameter or member 'flags'
not described in 'pcmcia_io_cfg_data_width'
drivers/pcmcia/pcmcia_cis.c:154: warning: Function parameter or member 'tuple'
not descr
f operation on struct
pcmcia_driver::drv which isn't the first member in struct
pcmcia_driver.)
Signed-off-by: Uwe Kleine-König
---
drivers/pcmcia/ds.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pcmcia/ds.c b/drivers/pcmcia/ds.c
index 72114907c0e4..bb096a3b76aa 100644
--- a/
The pull request you sent on Fri, 26 Feb 2021 06:50:29 +0100:
> https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/360db2b422f16305e5b8523b4b730521fbc8fb5d
Thank you!
--
Deet-doot-dot, I a
Linus,
A lone PCMCIA change since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62:
Linux 5.11-rc2 (2021-01-03 15:55:30 -0800)
is available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
for you to fetch changes up to
Am Tue, Feb 23, 2021 at 05:26:50PM +0800 schrieb Yang Li:
> fixed the following coccicheck:
> ./drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for
> kobj_to_dev()
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Sorry, an equivalent patch is already in pcmcia-ne
fixed the following coccicheck:
./drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for
kobj_to_dev()
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/pcmcia/cistpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia
It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.
Signed-off-by: Xiaofei Tan
---
drivers/scsi/pcmcia/sym53c500_cs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/pcmcia/sym53c500_cs.c
b/drivers
Am Mon, Jan 04, 2021 at 09:59:30AM +0800 schrieb Tian Tao:
> fixed the following coccicheck:
> drivers/pcmcia/cistpl.c:1557:54-55: WARNING opportunity for kobj_to_dev()
> drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for kobj_to_dev()
>
> Signed-off-by: Tian Tao
Applied
fixed the following coccicheck:
drivers/pcmcia/cistpl.c:1557:54-55: WARNING opportunity for kobj_to_dev()
drivers/pcmcia/cistpl.c:1584:53-54: WARNING opportunity for kobj_to_dev()
Signed-off-by: Tian Tao
---
drivers/pcmcia/cistpl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The pull request you sent on Sat, 19 Dec 2020 08:18:38 +0100:
> https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/651283d57eb4107f4a81af282064e597e2f9b181
Thank you!
--
Deet-doot-dot, I a
rg/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
for you to fetch changes up to 70d3a462fc244b0580268cc8e6c47ae4463db68a:
pcmcia: omap: Fix error return code in omap_cf_probe() (2020-12-05 09:59:13
+0100)
Besides a few PCMCIA odd fixes, the NEC VRC4173 CARDU driver is
removed, as it has no
ch a case.
>
> Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards")
> Signed-off-by: Christophe JAILLET
Applied to pcmcia-next. Thanks!
Dominik
> > > - Introduced in commit
> > > 79a140932c776 ("[PATCH] mips: vR41xx updates")
> > > which is 2.6.11-rc3.
> > >
> > > - Provides ->register_callback which was removed in commit
> > > 7f316b033b36a ("[PATCH] pcmcia: re
Am Thu, Sep 10, 2020 at 10:05:24PM +0800 schrieb Jason Yan:
> Eliminate the following coccicheck warning:
>
> drivers/pcmcia/db1xxx_ss.c:455:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot
> Signed-off-by: Jason Yan
Applied to pcmcia-next.
Thanks,
Dominik
now applied those patches on the at91-drivers branch, please shout if you
> want them to go through your branch.
>
> [1/2] pcmcia: at91_cf: move definitions locally
> commit: 496e9b64d7297d3e6c209c51218cee2939694b25
> [2/2] pcmcia: at91_cf: re
Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li:
> When it fails to call of_get_property(), it just jumps to 'fail1',
> while the 'status' which will be returned is not updated.
>
> Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Ele
Am Wed, Nov 25, 2020 at 08:50:57PM +0800 schrieb Wang ShaoBo:
> Fix to return proper error code instaed of 0 in omap_cf_probe(), as done
> elsewhere in this function.
>
> Signed-off-by: Wang ShaoBo
Applied to pcmcia-next.
Thanks,
Dominik
ack which was removed in commit
> 7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
> which is v2.6.14-rc3
>
> - Uses INIT_WORK() with three arguments which was removed in commit
> 65f27f38446e1 ("WorkStruct: Pass the work_struct pointer instead
x updates")
> > which is 2.6.11-rc3.
> >
> > - Provides ->register_callback which was removed in commit
> > 7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
> > which is v2.6.14-rc3
> >
> > - Uses INIT_WORK() with
Fix to return proper error code instaed of 0 in omap_cf_probe(), as done
elsewhere in this function.
Signed-off-by: Wang ShaoBo
---
drivers/pcmcia/omap_cf.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c
index
hrough your branch.
[1/2] pcmcia: at91_cf: move definitions locally
commit: 496e9b64d7297d3e6c209c51218cee2939694b25
[2/2] pcmcia: at91_cf: remove platform data support
commit: 91be3e89f450aa738204f6629f06d8b0e3d8d77b
Best regards,
--
Alexandre Belloni
When it fails to call of_get_property(), it just jumps to 'fail1',
while the 'status' which will be returned is not updated.
Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Wei Li
---
drivers/pcmcia/electra_cf.c | 1
ack which was removed in commit
> 7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
> which is v2.6.14-rc3
>
> - Uses INIT_WORK() with three arguments which was removed in commit
> 65f27f38446e1 ("WorkStruct: Pass the work_struct pointer instead
This driver is the very definition of bitrotting:
- Introduced in commit
79a140932c776 ("[PATCH] mips: vR41xx updates")
which is 2.6.11-rc3.
- Provides ->register_callback which was removed in commit
7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
This driver is the very definition of bitrotting:
- Introduced in commit
79a140932c776 ("[PATCH] mips: vR41xx updates")
which is 2.6.11-rc3.
- Provides ->register_callback which was removed in commit
7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
Board file support has been removed for at91rm9200 back in 2014, make the
CF driver DT only.
Signed-off-by: Alexandre Belloni
---
drivers/pcmcia/Kconfig | 1 +
drivers/pcmcia/at91_cf.c | 38 --
2 files changed, 9 insertions(+), 30 deletions(-)
diff --git
struct at91_cf_data is only used in the driver since all the platforms moved
to device tree, move its definition locally.
Signed-off-by: Alexandre Belloni
---
drivers/pcmcia/at91_cf.c| 11 +++
include/linux/platform_data/atmel.h | 12
2 files changed, 11
This driver is the very definition of bitrotting:
- Introduced in commit
79a140932c776 ("[PATCH] mips: vR41xx updates")
which is 2.6.11-rc3.
- Provides ->register_callback which was removed in commit
7f316b033b36a ("[PATCH] pcmcia: remove socket register_callback")
Eliminate the following coccicheck warning:
drivers/pcmcia/db1xxx_ss.c:455:2-3: Unneeded semicolon
Reported-by: Hulk Robot
Signed-off-by: Jason Yan
---
drivers/pcmcia/db1xxx_ss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia
On Thu, Sep 10, 2020 at 10:05:24PM +0800, Jason Yan wrote:
> Eliminate the following coccicheck warning:
>
> drivers/pcmcia/db1xxx_ss.c:455:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot
> Signed-off-by: Jason Yan
Acked-by: Gustavo A. R. Silva
Thanks
--
Gustavo
>
ppropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
drivers/scsi/pcmcia/nsp_cs.c: note: in included file:
>> drivers/scsi/pcmcia/nsp_io.h:231:24: sparse: sparse: incorrect type in
>> argument 1 (different address spaces) @@ expected void
ing tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/scsi/pcmcia/nsp_cs.c:1669:34: sparse: sparse: incorrect type in
>> argument 1 (different address spaces) @@ expected void const volatile
>> [noderef] __iomem *addr @@
Have just had confirmation that the mmc_ricoh_mmc change works and
both PCMCIA slots now work as intended on Panasonic Toughbook CF-29 Mk
4 and 5.
Thank you to all who have made suggestions for this, your dedication
to Linux is amazing and your help with this is appreciated.
Stay safe.
Michael
ing tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/char/pcmcia/cm4000_cs.c:312:23: sparse: sparse: cast removes address
>> space '__iomem' of expression
>> drivers/char/pcmcia/cm4000_cs.c:312:23: sparse: sparse:
dale wrote:
>>> On Tue, 25 Feb 2020 23:51:05 -0500
>>> Arvind Sankar wrote:
>>>
>>>> On Tue, Feb 25, 2020 at 09:12:48PM -0600, Trevor Jacobs wrote:
>>>> > That's correct, I tested a bunch of the old distros including
>>>> &g
There is no need to populate an unused variable, even if the read is required.
Fixes the following W=1 kernel build warning(s):
drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_cs_message’:
drivers/scsi/pcmcia/nsp_cs.c:143:2: warning: function ‘nsp_cs_message’ might
be a candidate for
Fixes the following W=1 kernel build warning(s):
drivers/scsi/pcmcia/nsp_cs.c: In function ‘nsp_cs_message’:
drivers/scsi/pcmcia/nsp_cs.c:143:2: warning: function ‘nsp_cs_message’ might
be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
drivers/scsi/pcmcia/nsp_cs.c
following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
include/linux/byteorder/big_endian.h:8:2: sparse: sparse: inconsistent
configuration, needs CONFIG_CPU_BIG_ENDIAN
>> drivers/scsi/pcmcia/nsp_cs.c:1669:34: sparse: sparse: incorrec
ing tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> sound/pcmcia/vx/vxp_ops.c:50:16: sparse: sparse: cast removes address space
>> '__iomem' of expression
>> sound/pcmcia/vx/vxp_ops.c:50:16: sparse: sparse: incorrect type
='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/char/pcmcia/synclink_cs.c:340:17: sparse: sparse: cast removes
>> address space '
INVAL in such a case.
Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards")
Signed-off-by: Christophe JAILLET
---
drivers/pcmcia/electra_cf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c
in
On Wed, Jun 17, 2020 at 12:54 PM Christophe JAILLET
wrote:
>
> 'status' is known to be 0 at this point. It must be set to a meaningful
> value in order to return an error code if one of the 'of_get_property()'
> call fails.
>
> Return -EINVAL in such a
'status' is known to be 0 at this point. It must be set to a meaningful
value in order to return an error code if one of the 'of_get_property()'
call fails.
Return -EINVAL in such a case.
Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards&qu
The pull request you sent on Thu, 4 Jun 2020 18:52:33 +0200:
> https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a0a4d17e02a80a74a63c7cbb7bc8cea2f0b7d8b1
Thank you!
--
Deet-doot-dot, I a
Linus,
the following changes since b9bbe6ed63b2b9f2c9ee5cbd0f2c946a2723f4ce:
Linux 5.7-rc6 (2020-05-17 16:48:37 -0700)
are available from
https://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git pcmcia-next
up to 46d0797906633d82bd50ef26780ee39fac5d27d6:
pcmcia: make
On Mon, May 18, 2020 at 11:16:13AM +0200, Dominik Brodowski wrote:
> >
> > Signed-off-by: Gustavo A. R. Silva
>
> Applied to pcmcia-next.
>
Thanks, Dominik.
--
Gustavo
und with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva
Applied to pcmcia-next.
Thanks,
Dominik
f-by: Gustavo A. R. Silva
---
include/pcmcia/cistpl.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/pcmcia/cistpl.h b/include/pcmcia/cistpl.h
index 59a011101e0e..749320cc9aba 100644
--- a/include/pcmcia/cistpl.h
+++ b/include/pcmcia/cistpl.h
@@ -161,7 +161,7 @@ typed
Thanks Domunik I'll get onto this and report back the results.
On 22/10/2019, Dominik Brodowski wrote:
> On Tue, Oct 22, 2019 at 05:17:12AM +1100, Michael . wrote:
>> Thank you Dominik for looking at this for us and passing it on.
>>
>> Good morning Bjorn, thank you also for looking into this for
On Tue, Oct 22, 2019 at 05:17:12AM +1100, Michael . wrote:
> Thank you Dominik for looking at this for us and passing it on.
>
> Good morning Bjorn, thank you also for looking into this for us and
> thank you for CCing us into this as non of us are on the mailing list.
> One question how do we app
Thank you Dominik for looking at this for us and passing it on.
Good morning Bjorn, thank you also for looking into this for us and
thank you for CCing us into this as non of us are on the mailing list.
One question how do we apply this patch or is this for Dominik to try?
Cheers.
Michael
On 22/
On Sun, Oct 20, 2019 at 11:08:00AM +0200, Dominik Brodowski wrote:
> On the basis of the additional information (thanks), there might be a
> more specific path to investigate: It is that the PCI code does not
> enumerate the second cardbus bridge PCI function in the more recent 4.19
> kernel compar
/Wireless 2915ABG [Calexico2]
Network Connection (rev 05)
...
To the PCI folks: any idea on what may cause the second cardbus bridge PCI
device function to be missed? Are there any command line options the users
who reported this issue[*] may try?
As this isn't really a PCMCIA (16bit) issue, but
Hi all,
The pcmcia tree
(git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git#pcmcia-next)
has not been updated in more than a year, so I have removed it from
linux-next. Please let me know if/when you want it reinstated.
--
Cheers,
Stephen Rothwell
pgpbACrVOT79P.pgp
Description
Rather than poking at the smemc registers directly from the
pcmcia/pxa2xx_base driver, move those bits into machine file
to have a cleaner interface.
Cc: Dominik Brodowski
Signed-off-by: Arnd Bergmann
---
arch/arm/mach-pxa/generic.c | 29 ++
drivers/pcmcia/pxa2xx_base.c
The drivers/pcmcia/pxa2xx_*.c are essentially part of the
board files, but for historic reasons located in drivers/pcmcia.
Move them into the same place as the actual board file to avoid
lots of machine header inclusions.
Cc: Marek Vasut
Cc: Dominik Brodowski
Cc: Jonathan Cameron
Signed-off
Include for pcmcia_parse_tuple declaration
to fix the following sparse warning:
drivers/pcmcia/cistpl.c:1287:5: warning: symbol 'pcmcia_parse_tuple' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Dominik Brodowski
Cc: Greg Kroah-Hartman
Cc: li
Include cs_internal.h (and pcmcia/cistpl.h as required by
cs_internal.h) for the declearions of cb_alloc and cb_free
to silence the following sparse warnings;
drivers/pcmcia/cardbus.c:64:11: warning: symbol 'cb_alloc' was not declared.
Should it be static?
drivers/pcmcia/cardbus.c:103:
nasonic Toughbook CF-29 models (ranging from Mark 1
>> through to Mark 5). These Toughbooks have 2 PCMCIA card slots which
>> are used by a variety of people for different purposes. On the CF-29
>> Mark 1 through to Mark 3 these slots work without problem. On the
>> CF-29 M
ginated with the
> demise of kernel 2.6:32. First some background to the issue. We are
> all users of Panasonic Toughbook CF-29 models (ranging from Mark 1
> through to Mark 5). These Toughbooks have 2 PCMCIA card slots which
> are used by a variety of people for different purpose
:
- Swap pr_debug() for dev_dbg()
- Clarify commit summary message
drivers/pcmcia/i82092.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pcmcia/i82092.c b/drivers/pcmcia/i82092.c
index ec54a2aa5cb8..245d60189375 100644
--- a/drivers/pcmcia/i82092.c
+++ b/drivers
o: Adam Zerella
> To: linux-kernel@vger.kernel.org
> Signed-off-by: Adam Zerella
> ---
> drivers/pcmcia/i82092.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pcmcia/i82092.c b/drivers/pcmcia/i82092.c
> index ec54a2aa5cb8..e19295
As pointed out in https://kernelnewbies.org/KernelJanitors/Todo
this patch replaces the outdated macro of DPRINTK for pr_debug()
To: Dominik Brodowski
To: Thomas Gleixner
To: Greg Kroah-Hartman
To: Adam Zerella
To: linux-kernel@vger.kernel.org
Signed-off-by: Adam Zerella
---
drivers/pcmcia
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Reviewed-by: Kees Cook
Signed-off-by: James Morris
---
drivers/pcmcia/cistpl.c
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Reviewed-by: Kees Cook
---
drivers/pcmcia/cistpl.c | 5 +
include/linux
On Mon, Aug 05, 2019 at 02:49:42PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: db1xxx_defconfig mips):
>
> drivers/pcmcia/db1xxx_ss.c:257:3: warning: this statement m
Mark switch cases where we are expecting to fall through.
This patch fixes the following warnings (Building: db1xxx_defconfig mips):
drivers/pcmcia/db1xxx_ss.c:257:3: warning: this statement may fall through
[-Wimplicit-fallthrough=]
drivers/pcmcia/db1xxx_ss.c:269:3: warning: this statement may
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Reviewed-by: Kees Cook
---
drivers/pcmcia/cistpl.c | 5 +
include/linux
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by: Chuhong Yuan
---
drivers/pcmcia/yenta_socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index
Arnd,
> Move all of SCSI_LOWLEVEL_PCMCIA inside of the existing SCSI_LOWLEVEL
> section. Very few people use the PCMCIA support these days, and they
> likely don't mind having to turn on SCSI_LOWLEVEL as well. This way we
> avoid the link error and get a more sensible structure
We get a warning when CONFIG_SCSI_LOWLEVEL is disabled here:
WARNING: unmet direct dependencies detected for SCSI_FDOMAIN
Depends on [n]: SCSI_LOWLEVEL [=n] && SCSI [=y]
Selected by [m]:
- PCMCIA_FDOMAIN [=m] && SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] &&
We get a warning when CONFIG_SCSI_LOWLEVEL is disabled here:
WARNING: unmet direct dependencies detected for SCSI_FDOMAIN
Depends on [n]: SCSI_LOWLEVEL [=n] && SCSI [=y]
Selected by [m]:
- PCMCIA_FDOMAIN [=m] && SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] &&
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Reviewed-by: Kees Cook
---
drivers/pcmcia/cistpl.c | 5 +
include/linux
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Reviewed-by: Kees Cook
---
drivers/pcmcia/cistpl.c | 5 +
include/linux
On Thu, Jul 04, 2019 at 12:29:43AM +0800, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to sm
kmemdup rather than using kmalloc/kzalloc + memcpy.
Signed-off-by: Fuqian Huang
---
Changes in v2:
- Fix a typo in commit message (memset -> memcpy)
drivers/pcmcia/cistpl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistp
kmemdup rather than using kmalloc/kzalloc + memset.
Signed-off-by: Fuqian Huang
---
drivers/pcmcia/cistpl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index abd029945cc8..eff91726f121 100644
--- a/drivers/pcmcia
On Fri, Jun 21, 2019 at 05:03:46PM -0700, Matthew Garrett wrote:
> From: David Howells
>
> Prohibit replacement of the PCMCIA Card Information Structure when the
> kernel is locked down.
>
> Suggested-by: Dominik Brodowski
> Signed-off-by: David Howells
Reviewed-
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 5 +
include/linux/security.h | 1
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 4
include/linux/security.h | 1
use surprises
> > for users that have SCSI_LOWLEVEL disabled.
>
> It seems messy to me that PCMCIA lives outside of the LOWLEVEL section.
>
> Given that the number of users that rely on PCMCIA for their system disk
> is probably pretty low, I think I'm leaning towards clea
Arnd,
> Move the common support outside of the SCSI_LOWLEVEL section.
> Alternatively, we could move all of SCSI_LOWLEVEL_PCMCIA into
> SCSI_LOWLEVEL. This would be more sensible, but might cause surprises
> for users that have SCSI_LOWLEVEL disabled.
It seems messy to me that
We get a warning when CONFIG_SCSI_LOWLEVEL is disabled here:
WARNING: unmet direct dependencies detected for SCSI_FDOMAIN
Depends on [n]: SCSI_LOWLEVEL [=n] && SCSI [=y]
Selected by [m]:
- PCMCIA_FDOMAIN [=m] && SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] &&
Ondrej,
> Add PCMCIA card support to Future Domain SCSI driver.
>
> Tested with IBM SCSI PCMCIA Adapter 40G1890.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Add PCMCIA card support to Future Domain SCSI driver.
Tested with IBM SCSI PCMCIA Adapter 40G1890.
Signed-off-by: Ondrej Zary
---
drivers/scsi/fdomain.c | 7 ++-
drivers/scsi/pcmcia/Kconfig | 10 +
drivers/scsi/pcmcia/Makefile | 1 +
drivers/scsi/pcmcia/fdomain_cs.c
On Tue, Apr 16, 2019 at 08:45:44PM +0300, Mohan Kumar wrote:
> Switch hardcoded function name with a reference to __func__ making the
> code more maintainable
Thanks for your patch. Are there any other patches pending to this driver?
As noted in Kconfig, the TCIC host briges "are only found on a
Switch hardcoded function name with a reference to __func__ making the
code more maintainable
WARNING: Prefer using '"%s...", __func__' to using function's name, in a
string
Signed-off-by: Mohan Kumar
---
drivers/pcmcia/tcic.c | 4 ++--
1 file changed, 2 insertions
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 4
1 file changed, 4 insertions(+)
diff --git a
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 4
1 file changed, 4 insertions(+)
diff --git a
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
cc: linux-pcm...@lists.infradead.org
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 3 +++
1 file
Formatting of Kconfig files doesn't look so pretty, so let the
Great White Handkerchief come around and clean it up.
Signed-off-by: Enrico Weigelt, metux IT consult
---
drivers/pcmcia/Kconfig | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/dr
1 - 100 of 1373 matches
Mail list logo
