Re: perf: easily crash kernel with rapl event close

2015-01-22 Thread Vince Weaver
On Thu, 22 Jan 2015, Stephane Eranian wrote: > Fix looks like this: > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_rapl.c > b/arch/x86/kernel/cpu/perf_event_intel_rapl.c > index 6e434f8..c4bb8b8 100644 > --- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c > +++ b/arch/x86/kernel/cpu/perf_eve

Re: perf: easily crash kernel with rapl event close

2015-01-22 Thread Stephane Eranian
On Thu, Jan 22, 2015 at 1:39 PM, Stephane Eranian wrote: > On Thu, Jan 22, 2015 at 2:17 AM, Peter Zijlstra wrote: >> On Wed, Jan 21, 2015 at 09:13:11PM -0800, Stephane Eranian wrote: >>> Vince, >>> >>> On Wed, Jan 21, 2015 at 10:55 AM, Vince Weaver >>> wrote: >>> > Hello >>> > >>> > on my haswe

Re: perf: easily crash kernel with rapl event close

2015-01-22 Thread Stephane Eranian
On Thu, Jan 22, 2015 at 2:17 AM, Peter Zijlstra wrote: > On Wed, Jan 21, 2015 at 09:13:11PM -0800, Stephane Eranian wrote: >> Vince, >> >> On Wed, Jan 21, 2015 at 10:55 AM, Vince Weaver >> wrote: >> > Hello >> > >> > on my haswell system, running 3.19-rc5, and with >> > echo "0" > /proc/

Re: perf: easily crash kernel with rapl event close

2015-01-22 Thread Peter Zijlstra
On Wed, Jan 21, 2015 at 09:13:11PM -0800, Stephane Eranian wrote: > Vince, > > On Wed, Jan 21, 2015 at 10:55 AM, Vince Weaver > wrote: > > Hello > > > > on my haswell system, running 3.19-rc5, and with > > echo "0" > /proc/sys/kernel/perf_event_paranoid > > > > I can easily crash my syst

Re: perf: easily crash kernel with rapl event close

2015-01-21 Thread Stephane Eranian
Vince, On Wed, Jan 21, 2015 at 10:55 AM, Vince Weaver wrote: > Hello > > on my haswell system, running 3.19-rc5, and with > echo "0" > /proc/sys/kernel/perf_event_paranoid > > I can easily crash my system with the attached test program that simply > opens a RAPL event and then closes it.

perf: easily crash kernel with rapl event close

2015-01-21 Thread Vince Weaver
Hello on my haswell system, running 3.19-rc5, and with echo "0" > /proc/sys/kernel/perf_event_paranoid I can easily crash my system with the attached test program that simply opens a RAPL event and then closes it. This bug was found by the perf_fuzzer. It looks like somehow rapl_pmu get