Re: phy: cpcap-usb: Add CPCAP PMIC USB support

2017-06-06 Thread Tony Lindgren
* Colin Ian King [170605 10:58]: > Hi Tony, > > While running static analysis on linux-next, CoverityScan picked up a > NULL pointer deference on ddata->pins when calling pinctrl_lookup_state: > > 466ddata->pins = devm_pinctrl_get(ddata->dev); > >1. Condition IS_ERR(ddata->pins), ta

re: phy: cpcap-usb: Add CPCAP PMIC USB support

2017-06-05 Thread Colin Ian King
Hi Tony, While running static analysis on linux-next, CoverityScan picked up a NULL pointer deference on ddata->pins when calling pinctrl_lookup_state: 466ddata->pins = devm_pinctrl_get(ddata->dev); 1. Condition IS_ERR(ddata->pins), taking true branch. 467if (IS_ERR(ddata->pi

Re: [PATCHv4] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-06-01 Thread Kishon Vijay Abraham I
On Tuesday 23 May 2017 06:07 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for the SoC U

[PATCHv4] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-22 Thread Tony Lindgren
Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a multiplexing USB PHY. This USB PHY can operate at least in four modes using pin multiplexing and two control GPIOS: - Pass through companion PHY for the SoC USB PHY - ULPI PHY for the SoC - Pass through USB for the modem - UART

Re: [PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-08 Thread Tony Lindgren
* Kishon Vijay Abraham I [170507 23:23]: > Hi Tony, > > On Monday 10 April 2017 09:49 AM, Tony Lindgren wrote: > > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > > multiplexing USB PHY. > > > > This USB PHY can operate at least in four modes using pin multiplexing > > and

Re: [PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-05-07 Thread Kishon Vijay Abraham I
Hi Tony, On Monday 10 April 2017 09:49 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for

[PATCHv3] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-04-09 Thread Tony Lindgren
Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a multiplexing USB PHY. This USB PHY can operate at least in four modes using pin multiplexing and two control GPIOS: - Pass through companion PHY for the SoC USB PHY - ULPI PHY for the SoC - Pass through USB for the modem - UART

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-04-03 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I [170330 04:51]: > On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > > Seems this can be also done when implementing PM runtime handling. > > If you want some of these changes done for the initial patch, > > please let me know. > > I think it's better we get ex

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-30 Thread Kishon Vijay Abraham I
Hi Tony, On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [170326 23:27]: >> On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: >>> +static const struct phy_ops ops = { >>> + .owner = THIS_MODULE, >>> +}; >> >> Given that this phy doesn't have any

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-28 Thread Rob Herring
On Wed, Mar 22, 2017 at 04:46:02PM -0700, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY for th

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-27 Thread Tony Lindgren
* Kishon Vijay Abraham I [170326 23:27]: > On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: > > +static const struct phy_ops ops = { > > + .owner = THIS_MODULE, > > +}; > > Given that this phy doesn't have any phy_ops, Is there a reason for > registering > this phy with the ph

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-26 Thread Kishon Vijay Abraham I
Hi Tony, On Thursday 23 March 2017 05:16 AM, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY fo

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-25 Thread Tony Lindgren
://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-cpcap-usb-Add-CPCAP-PMIC-USB-support/20170324-061112 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > next > config: x86_64-randconfig-a0-03260238 (attached as .config) > compiler: gcc-4.4 (Debian 4.4.7

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-25 Thread kbuild test robot
Hi Tony, [auto build test ERROR on phy/next] [also build test ERROR on v4.11-rc3 next-20170324] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tony-Lindgren/phy-cpcap-usb-Add-CPCAP-PMIC-USB

[PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-22 Thread Tony Lindgren
Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a multiplexing USB PHY. This USB PHY can operate at least in four modes using pin multiplexing and two control GPIOS: - Pass through companion PHY for the SoC USB PHY - ULPI PHY for the SoC - Pass through USB for the modem - UART

Re: [PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-22 Thread Tony Lindgren
* Sebastian Reichel [170321 19:20]: > Hi, > > On Thu, Mar 16, 2017 at 08:51:52PM -0700, Tony Lindgren wrote: > > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > > multiplexing USB PHY. > > > > This USB PHY can operate at least in four modes using pin multiplexing > > and t

Re: [PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-21 Thread Sebastian Reichel
Hi, On Thu, Mar 16, 2017 at 08:51:52PM -0700, Tony Lindgren wrote: > Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a > multiplexing USB PHY. > > This USB PHY can operate at least in four modes using pin multiplexing > and two control GPIOS: > > - Pass through companion PHY f

[PATCH] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-03-16 Thread Tony Lindgren
Some Motorola phones like droid 4 use a custom CPCAP PMIC that has a multiplexing USB PHY. This USB PHY can operate at least in four modes using pin multiplexing and two control GPIOS: - Pass through companion PHY for the SoC USB PHY - ULPI PHY for the SoC - Pass through USB for the modem - UART