Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-13 Thread Johannes Thumshirn
On Wed, Apr 12, 2017 at 07:30:22PM +0200, Christoph Hellwig wrote: > > shows some have been done. I wonder whether marking > > pci_enable_msix_exact() would cause a lot of warnings though. An > > allyesconfig build would tell... > > It would cause lots of warnings. The problem with __deprecated

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-13 Thread Johannes Thumshirn
On Wed, Apr 12, 2017 at 07:30:22PM +0200, Christoph Hellwig wrote: > > shows some have been done. I wonder whether marking > > pci_enable_msix_exact() would cause a lot of warnings though. An > > allyesconfig build would tell... > > It would cause lots of warnings. The problem with __deprecated

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 07:28:59PM +0200, Borislav Petkov wrote: > On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote: > > Did we ever do this for deprecated APIs before? For now I'm just watching > > Linux-next and sending gentle reminders :) > > $ git grep __deprecated > >

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 07:28:59PM +0200, Borislav Petkov wrote: > On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote: > > Did we ever do this for deprecated APIs before? For now I'm just watching > > Linux-next and sending gentle reminders :) > > $ git grep __deprecated > >

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Borislav Petkov
On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote: > Did we ever do this for deprecated APIs before? For now I'm just watching > Linux-next and sending gentle reminders :) $ git grep __deprecated shows some have been done. I wonder whether marking pci_enable_msix_exact() would

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Borislav Petkov
On Wed, Apr 12, 2017 at 07:16:22PM +0200, Christoph Hellwig wrote: > Did we ever do this for deprecated APIs before? For now I'm just watching > Linux-next and sending gentle reminders :) $ git grep __deprecated shows some have been done. I wonder whether marking pci_enable_msix_exact() would

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 11:21:01AM +0200, Borislav Petkov wrote: > Do we need to mark pci_enable_msix_exact() deprecated or so, or maybe a > checkpatch rule? Did we ever do this for deprecated APIs before? For now I'm just watching Linux-next and sending gentle reminders :)

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
On Wed, Apr 12, 2017 at 11:21:01AM +0200, Borislav Petkov wrote: > Do we need to mark pci_enable_msix_exact() deprecated or so, or maybe a > checkpatch rule? Did we ever do this for deprecated APIs before? For now I'm just watching Linux-next and sending gentle reminders :)

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Borislav Petkov
On Wed, Apr 12, 2017 at 08:06:00AM +0200, Christoph Hellwig wrote: > Hi Sergey, > > you're new thunderx_edac driver uses pci_enable_msix_exact for no > good reason. Can you please switch it to use pci_alloc_irq_vectors > before it gets merged to mainline? Do we need to mark

Re: please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Borislav Petkov
On Wed, Apr 12, 2017 at 08:06:00AM +0200, Christoph Hellwig wrote: > Hi Sergey, > > you're new thunderx_edac driver uses pci_enable_msix_exact for no > good reason. Can you please switch it to use pci_alloc_irq_vectors > before it gets merged to mainline? Do we need to mark

please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
Hi Sergey, you're new thunderx_edac driver uses pci_enable_msix_exact for no good reason. Can you please switch it to use pci_alloc_irq_vectors before it gets merged to mainline? Thanks, Christoph

please use pci_alloc_irq_vectors in thunderx_edac.

2017-04-12 Thread Christoph Hellwig
Hi Sergey, you're new thunderx_edac driver uses pci_enable_msix_exact for no good reason. Can you please switch it to use pci_alloc_irq_vectors before it gets merged to mainline? Thanks, Christoph