Re: possible deadlock in pipe_lock (2)

2019-02-12 Thread Jan Kara
On Tue 12-02-19 15:39:38, Amir Goldstein wrote: > > > My other thought is that perhaps sb_start_write() should invoke > > > s_ops->start_write() so that overlay can do the freeze protection on > > > the upper early. > > > > So my understanding of overlayfs is pretty basic so I'm sorry if I miss >

Re: possible deadlock in pipe_lock (2)

2019-02-12 Thread Miklos Szeredi
On Tue, Feb 12, 2019 at 2:39 PM Amir Goldstein wrote: > > > > My other thought is that perhaps sb_start_write() should invoke > > > s_ops->start_write() so that overlay can do the freeze protection on > > > the upper early. > > > > So my understanding of overlayfs is pretty basic so I'm sorry if

Re: possible deadlock in pipe_lock (2)

2019-02-12 Thread Amir Goldstein
> > My other thought is that perhaps sb_start_write() should invoke > > s_ops->start_write() so that overlay can do the freeze protection on > > the upper early. > > So my understanding of overlayfs is pretty basic so I'm sorry if I miss > something. If I'm right, we have three superblocks here:

Re: possible deadlock in pipe_lock (2)

2019-02-12 Thread Jan Kara
On Mon 11-02-19 15:33:38, Miklos Szeredi wrote: > On Mon, Feb 11, 2019 at 2:08 PM Amir Goldstein wrote: > > > > On Mon, Feb 11, 2019 at 2:37 PM Miklos Szeredi wrote: > > > > > > On Mon, Feb 11, 2019 at 1:06 PM Miklos Szeredi wrote: > > > > > > > > On Mon, Feb 11, 2019 at 8:38 AM Amir Goldstein

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Amir Goldstein
On Mon, Feb 11, 2019 at 5:40 PM Miklos Szeredi wrote: > > On Mon, Feb 11, 2019 at 4:07 PM Amir Goldstein wrote: > > > > On Mon, Feb 11, 2019 at 4:33 PM Miklos Szeredi wrote: > > > > > > On Mon, Feb 11, 2019 at 2:08 PM Amir Goldstein wrote: > > > > > > > > On Mon, Feb 11, 2019 at 2:37 PM Miklos

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Miklos Szeredi
On Mon, Feb 11, 2019 at 2:08 PM Amir Goldstein wrote: > > On Mon, Feb 11, 2019 at 2:37 PM Miklos Szeredi wrote: > > > > On Mon, Feb 11, 2019 at 1:06 PM Miklos Szeredi wrote: > > > > > > On Mon, Feb 11, 2019 at 8:38 AM Amir Goldstein wrote: > > > > > > > > On Sun, Feb 10, 2019 at 8:23 PM syzbot

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Miklos Szeredi
On Mon, Feb 11, 2019 at 4:07 PM Amir Goldstein wrote: > > On Mon, Feb 11, 2019 at 4:33 PM Miklos Szeredi wrote: > > > > On Mon, Feb 11, 2019 at 2:08 PM Amir Goldstein wrote: > > > > > > On Mon, Feb 11, 2019 at 2:37 PM Miklos Szeredi wrote: > > > > > > > > On Mon, Feb 11, 2019 at 1:06 PM Miklos

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Amir Goldstein
On Mon, Feb 11, 2019 at 4:33 PM Miklos Szeredi wrote: > > On Mon, Feb 11, 2019 at 2:08 PM Amir Goldstein wrote: > > > > On Mon, Feb 11, 2019 at 2:37 PM Miklos Szeredi wrote: > > > > > > On Mon, Feb 11, 2019 at 1:06 PM Miklos Szeredi wrote: > > > > > > > > On Mon, Feb 11, 2019 at 8:38 AM Amir

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Amir Goldstein
On Mon, Feb 11, 2019 at 2:37 PM Miklos Szeredi wrote: > > On Mon, Feb 11, 2019 at 1:06 PM Miklos Szeredi wrote: > > > > On Mon, Feb 11, 2019 at 8:38 AM Amir Goldstein wrote: > > > > > > On Sun, Feb 10, 2019 at 8:23 PM syzbot > > > wrote: > > > > > > -> #1 (_i_mutex_key[depth]){+.+.}: > > > >

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Miklos Szeredi
On Mon, Feb 11, 2019 at 1:06 PM Miklos Szeredi wrote: > > On Mon, Feb 11, 2019 at 8:38 AM Amir Goldstein wrote: > > > > On Sun, Feb 10, 2019 at 8:23 PM syzbot > > wrote: > > > > -> #1 (_i_mutex_key[depth]){+.+.}: > > > down_write+0x38/0x90 kernel/locking/rwsem.c:70 > > >

Re: possible deadlock in pipe_lock (2)

2019-02-11 Thread Miklos Szeredi
On Mon, Feb 11, 2019 at 8:38 AM Amir Goldstein wrote: > > On Sun, Feb 10, 2019 at 8:23 PM syzbot > wrote: > > -> #1 (_i_mutex_key[depth]){+.+.}: > > down_write+0x38/0x90 kernel/locking/rwsem.c:70 > > inode_lock include/linux/fs.h:757 [inline] > >

Re: possible deadlock in pipe_lock (2)

2019-02-10 Thread Amir Goldstein
On Sun, Feb 10, 2019 at 8:23 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:74e96711e337 Merge tag 'platform-drivers-x86-v5.0-2' of gi.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=11225b2740 > kernel config:

possible deadlock in pipe_lock (2)

2019-02-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:74e96711e337 Merge tag 'platform-drivers-x86-v5.0-2' of gi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11225b2740 kernel config: https://syzkaller.appspot.com/x/.config?x=8f00801d7b7c4fe6