Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-09 Thread Boqun Feng
On Mon, Nov 09, 2020 at 09:57:05AM +, Filipe Manana wrote: > > > On 09/11/20 08:44, Boqun Feng wrote: > > Hi Filipe, > > > > On Thu, Nov 05, 2020 at 09:10:12AM +0800, Boqun Feng wrote: > >> On Wed, Nov 04, 2020 at 07:54:40PM +, Filipe Manana wrote: > >> [...] > >>> > >>> Ok, so I ran 5.1

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-09 Thread Filipe Manana
On 09/11/20 08:44, Boqun Feng wrote: > Hi Filipe, > > On Thu, Nov 05, 2020 at 09:10:12AM +0800, Boqun Feng wrote: >> On Wed, Nov 04, 2020 at 07:54:40PM +, Filipe Manana wrote: >> [...] >>> >>> Ok, so I ran 5.10-rc2 plus your two patches (the fix and the debug one): >>> >>> diff --git a/kern

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-09 Thread Boqun Feng
Hi Filipe, On Thu, Nov 05, 2020 at 09:10:12AM +0800, Boqun Feng wrote: > On Wed, Nov 04, 2020 at 07:54:40PM +, Filipe Manana wrote: > [...] > > > > Ok, so I ran 5.10-rc2 plus your two patches (the fix and the debug one): > > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-04 Thread Boqun Feng
On Wed, Nov 04, 2020 at 07:54:40PM +, Filipe Manana wrote: [...] > > Ok, so I ran 5.10-rc2 plus your two patches (the fix and the debug one): > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > index b71ad8d9f1c9..b31d4ad482c7 100644 > --- a/kernel/locking/lockdep.c > +++ b

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-04 Thread Filipe Manana
On 04/11/20 09:49, Filipe Manana wrote: > > > On 04/11/20 03:44, Boqun Feng wrote: >> On Wed, Nov 04, 2020 at 10:22:36AM +0800, Boqun Feng wrote: >>> On Tue, Nov 03, 2020 at 07:44:29PM +, Filipe Manana wrote: On 03/11/20 14:08, Boqun Feng wrote: > Hi Filipe, > >

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-04 Thread Filipe Manana
On 04/11/20 03:44, Boqun Feng wrote: > On Wed, Nov 04, 2020 at 10:22:36AM +0800, Boqun Feng wrote: >> On Tue, Nov 03, 2020 at 07:44:29PM +, Filipe Manana wrote: >>> >>> >>> On 03/11/20 14:08, Boqun Feng wrote: Hi Filipe, On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Boqun Feng
On Wed, Nov 04, 2020 at 10:22:36AM +0800, Boqun Feng wrote: > On Tue, Nov 03, 2020 at 07:44:29PM +, Filipe Manana wrote: > > > > > > On 03/11/20 14:08, Boqun Feng wrote: > > > Hi Filipe, > > > > > > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: > > >> Hello, > > >> > > >> I'

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Boqun Feng
On Tue, Nov 03, 2020 at 07:44:29PM +, Filipe Manana wrote: > > > On 03/11/20 14:08, Boqun Feng wrote: > > Hi Filipe, > > > > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: > >> Hello, > >> > >> I've recently started to hit a warning followed by tasks hanging after > >> attemp

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Filipe Manana
On 03/11/20 14:08, Boqun Feng wrote: > Hi Filipe, > > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: >> Hello, >> >> I've recently started to hit a warning followed by tasks hanging after >> attempts to freeze a filesystem. A git bisection pointed to the >> following commit: >>

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Filipe Manana
On 03/11/20 14:08, Boqun Feng wrote: > Hi Filipe, > > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: >> Hello, >> >> I've recently started to hit a warning followed by tasks hanging after >> attempts to freeze a filesystem. A git bisection pointed to the >> following commit: >>

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Boqun Feng
Hi Filipe, On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: > Hello, > > I've recently started to hit a warning followed by tasks hanging after > attempts to freeze a filesystem. A git bisection pointed to the > following commit: > > commit 4d004099a668c41522242aa146a38cc4eb59cb1e

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Filipe Manana
On 03/11/20 10:15, Jan Kara wrote: > On Mon 02-11-20 17:58:54, Filipe Manana wrote: >> >> >> On 26/10/20 15:22, Peter Zijlstra wrote: >>> On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: >> That smells like th

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-03 Thread Jan Kara
On Mon 02-11-20 17:58:54, Filipe Manana wrote: > > > On 26/10/20 15:22, Peter Zijlstra wrote: > > On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: > >> On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: > That smells like the same issue reported here: > >

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-11-02 Thread Filipe Manana
On 26/10/20 15:22, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: >> On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: That smells like the same issue reported here: https://lkml.kernel.org/r/20201022111700.gz2...@hirez

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-27 Thread Anatoly Pugachev
On Mon, Oct 26, 2020 at 6:23 PM Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: > > On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: > > > > That smells like the same issue reported here: > > > > > > > > > > > > https://lkml.kernel.org/r/202

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread David Sterba
On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: > > > That smells like the same issue reported here: > > > > > > > > > https://lkml.kernel.org/r/20201022111700.gz2...@hirez.programming.kicks-ass.net > > > > > > Ma

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 01:55:24PM +0100, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: > > > That smells like the same issue reported here: > > > > > > > > > https://lkml.kernel.org/r/20201022111700.gz2...@hirez.programming.kicks-ass.net > > > > > > Ma

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Filipe Manana
On 26/10/20 12:55, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: >>> That smells like the same issue reported here: >>> >>> >>> https://lkml.kernel.org/r/20201022111700.gz2...@hirez.programming.kicks-ass.net >>> >>> Make sure you have commit: >>> >>>

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 11:56:03AM +, Filipe Manana wrote: > > That smells like the same issue reported here: > > > > > > https://lkml.kernel.org/r/20201022111700.gz2...@hirez.programming.kicks-ass.net > > > > Make sure you have commit: > > > > f8e48a3dca06 ("lockdep: Fix preemption WAR

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 12:55:41PM +0100, Jan Kara wrote: > > Make sure you have commit: > > > > f8e48a3dca06 ("lockdep: Fix preemption WARN for spurious IRQ-enable") > > > > (in Linus' tree by now) and do you have CONFIG_DEBUG_PREEMPT enabled? > > Hum, I am at 5.10-rc1 now and above mentioned

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Filipe Manana
On 26/10/20 11:55, Jan Kara wrote: > On Mon 26-10-20 12:40:09, Peter Zijlstra wrote: >> On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: >>> Hello, >>> >>> I've recently started to hit a warning followed by tasks hanging after >>> attempts to freeze a filesystem. A git bisection po

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Filipe Manana
On 26/10/20 11:40, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: >> Hello, >> >> I've recently started to hit a warning followed by tasks hanging after >> attempts to freeze a filesystem. A git bisection pointed to the >> following commit: >> >> commit 4d

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Jan Kara
On Mon 26-10-20 12:40:09, Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: > > Hello, > > > > I've recently started to hit a warning followed by tasks hanging after > > attempts to freeze a filesystem. A git bisection pointed to the > > following commit: > >

Re: possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 11:26:49AM +, Filipe Manana wrote: > Hello, > > I've recently started to hit a warning followed by tasks hanging after > attempts to freeze a filesystem. A git bisection pointed to the > following commit: > > commit 4d004099a668c41522242aa146a38cc4eb59cb1e > Author: Pe

possible lockdep regression introduced by 4d004099a668 ("lockdep: Fix lockdep recursion")

2020-10-26 Thread Filipe Manana
Hello, I've recently started to hit a warning followed by tasks hanging after attempts to freeze a filesystem. A git bisection pointed to the following commit: commit 4d004099a668c41522242aa146a38cc4eb59cb1e Author: Peter Zijlstra Date: Fri Oct 2 11:04:21 2020 +0200 lockdep: Fix lockdep r