Re: possible new false positive in checkpatch

2016-06-11 Thread Tal Shorer
On Tue, Sep 15, 2015 at 6:01 PM, Andy Whitcroft wrote: > On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote: > >> > Yes it feels like that should be eliding them completely, and likely any >> > following space as well, something like this: >> > >> > $s =~ s/$;+\s*//g; >> >

Re: possible new false positive in checkpatch

2015-10-26 Thread Tal Shorer
ping? Is there a plan to fix it? should I send your fix? (kinda plagiarism) next release? (which would mean the unnecessary warnings will exist in 4.3 :<) On Tue, Sep 15, 2015 at 6:01 PM, Andy Whitcroft wrote: > On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote: > >> > Yes it feels like

Re: possible new false positive in checkpatch

2015-09-15 Thread Andy Whitcroft
On Tue, Sep 15, 2015 at 05:50:40PM +0300, Tal Shorer wrote: > > Yes it feels like that should be eliding them completely, and likely any > > following space as well, something like this: > > > > $s =~ s/$;+\s*//g; > > $c =~ s/$;+\s*//g; > > > Replacing the problematic lines with th

Re: possible new false positive in checkpatch

2015-09-15 Thread Tal Shorer
On Mon, Sep 14, 2015 at 1:27 PM, Andy Whitcroft wrote: > > On Sat, Sep 12, 2015 at 03:13:31PM +0300, Tal Shorer wrote: > > Since my last pull from upstream (today) , I started seeing some > > checkpatch warnings regarding suspect code indent I believe are false > > positive. Take this code for exa

Re: possible new false positive in checkpatch

2015-09-14 Thread Andy Whitcroft
On Sat, Sep 12, 2015 at 03:13:31PM +0300, Tal Shorer wrote: > Since my last pull from upstream (today) , I started seeing some > checkpatch warnings regarding suspect code indent I believe are false > positive. Take this code for example: > > static int foo(void) > { > while (bar()) >

possible new false positive in checkpatch

2015-09-12 Thread Tal Shorer
Since my last pull from upstream (today) , I started seeing some checkpatch warnings regarding suspect code indent I believe are false positive. Take this code for example: static int foo(void) { while (bar()) /* do nothing */; } When running checkpath on it, the following