[PATCH 0/2] (Was: pppd service crash in linux-3.13.6)

2014-03-17 Thread Oleg Nesterov
On 03/15, Peter Hurley wrote: > > On 03/14/2014 05:04 PM, Oleg Nesterov wrote: >> >> But it can't even know who called call_usermodehelper(). Besides, >> cgroup_release_agent() uses UMH_WAIT_EXEC, so the caller can continue >> and disappear completely before the usermode process has any chance >> t

Re: pppd service crash in linux-3.13.6

2014-03-15 Thread Peter Hurley
On 03/14/2014 05:04 PM, Oleg Nesterov wrote: On 03/14, Peter Hurley wrote: On 03/14/2014 03:23 PM, Oleg Nesterov wrote: On 03/14, Peter Hurley wrote: Yes, cgroup_release_agent() is the work function that is scheduled. which requires both namespace and tty facilities. Hmm... why? The exi

Re: pppd service crash in linux-3.13.6

2014-03-14 Thread Oleg Nesterov
On 03/14, Peter Hurley wrote: > > On 03/14/2014 03:23 PM, Oleg Nesterov wrote: >> On 03/14, Peter Hurley wrote: >>> > Yes, cgroup_release_agent() is the work function that is scheduled. > >>> which requires both namespace and tty facilities. >> >> Hmm... why? >> >> The exiting task obviously can't

Re: pppd service crash in linux-3.13.6

2014-03-14 Thread Peter Hurley
On 03/14/2014 03:23 PM, Oleg Nesterov wrote: On 03/14, Peter Hurley wrote: On 03/13/2014 01:06 PM, Oleg Nesterov wrote: OTOH, why we should delay disassociate_ctty? IOW, do you see any potential problem with the trivial patch below? Won't work. cgroup_exit() can exec a userspace process (

Re: pppd service crash in linux-3.13.6

2014-03-14 Thread Oleg Nesterov
On 03/14, Peter Hurley wrote: > >> On 03/13/2014 01:06 PM, Oleg Nesterov wrote: >>> >>> OTOH, why we should delay disassociate_ctty? IOW, do you see any >>> potential problem with the trivial patch below? > > Won't work. > > cgroup_exit() can exec a userspace process (the notify_on_exit() facility)

Re: pppd service crash in linux-3.13.6

2014-03-14 Thread Peter Hurley
On 03/14/2014 10:19 AM, Peter Hurley wrote: Plus, proc_exit_connector() uses netlink which uses user_ns. Actually, I think this can be safely ignored since if the netlink socket was tied to a user_ns which has just been freed in exit_task_namespace() then the socket could not be open in another

Re: pppd service crash in linux-3.13.6

2014-03-14 Thread Peter Hurley
[ +cc Eric Biederman ] On 03/13/2014 01:55 PM, Peter Hurley wrote: Hi Oleg, On 03/13/2014 01:06 PM, Oleg Nesterov wrote: On 03/10, Peter Hurley wrote: [ +cc Oleg Nesterov ] Thanks. The NULL ptr dereference is from following the current->nsproxy ptr in ppp_register_channel(). This was br

Re: pppd service crash in linux-3.13.6

2014-03-13 Thread Peter Hurley
Hi Oleg, On 03/13/2014 01:06 PM, Oleg Nesterov wrote: On 03/10, Peter Hurley wrote: [ +cc Oleg Nesterov ] Thanks. The NULL ptr dereference is from following the current->nsproxy ptr in ppp_register_channel(). This was broken by commit 8aac62706adaaf0fab02c4327761561c8bda9448 Author: Oleg

Re: pppd service crash in linux-3.13.6

2014-03-13 Thread Oleg Nesterov
On 03/10, Peter Hurley wrote: > > [ +cc Oleg Nesterov ] Thanks. > The NULL ptr dereference is from following the current->nsproxy ptr > in ppp_register_channel(). > > This was broken by > > commit 8aac62706adaaf0fab02c4327761561c8bda9448 > Author: Oleg Nesterov > Date: Fri Jun 14 21:09:49 2013

Re: pppd service crash in linux-3.13.6

2014-03-12 Thread Sree Harsha Totakura
On 03/10/2014 08:54 PM, Ben Hutchings wrote: > You should send the 'Oops' messages which should be further up the > log file. Attached is a file containing the oops message. Sree Mar 8 18:46:32 iris kernel: [29267.060816] PPP BSD Compression module registered Mar 8 18:46:32 iris kernel: [29267

Re: pppd service crash in linux-3.13.6

2014-03-10 Thread Ben Hutchings
On Mon, 2014-03-10 at 17:56 +0100, Sree Harsha Totakura wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > Using linux-3.13.6, I am observing the following output from the pppd > kernel thread. This happens when I try to suspend my computer and it > *stops* the computer from su

Re: pppd service crash in linux-3.13.6

2014-03-10 Thread Peter Hurley
[ +cc Oleg Nesterov ] On 03/10/2014 12:56 PM, Sree Harsha Totakura wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Using linux-3.13.6, I am observing the following output from the pppd kernel thread. This happens when I try to suspend my computer and it *stops* the computer from susp

pppd service crash in linux-3.13.6

2014-03-10 Thread Sree Harsha Totakura
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Using linux-3.13.6, I am observing the following output from the pppd kernel thread. This happens when I try to suspend my computer and it *stops* the computer from suspending. I am using ppp via a bluetooth modem. Trace: [22735.115313] PM: Syn