Re: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Al Viro
On Fri, Aug 17, 2018 at 08:51:42AM +0530, Srikanth Korangala Hari wrote: > > Thanks for the patch! Do you have a reproducer or is this theoretical? > > This will affect if it should go to stable or not. > > Dear Luis, this is theoretical as I observed in most of the call's to api - > "proc_mkdir"

RE: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Srikanth Korangala Hari
> It is fine to crash because /proc is not modular. Dear Alexey, this was theoretical solution. If you feel this should crash instead if the call fail's then ignore the patch. Regards, Srikanth  

RE: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Srikanth Korangala Hari
> Thanks for the patch! Do you have a reproducer or is this theoretical? > This will affect if it should go to stable or not. Dear Luis, this is theoretical as I observed in most of the call's to api - "proc_mkdir" the NULL check is being done. Hence I thought of adding one here. Regards, Srikan

Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Luis Chamberlain
On Thu, Aug 16, 2018 at 03:04:13PM +0530, Srikanth K H wrote: > If the make directory for "sys" interface fail's then its > dereferenced without even checking for its validity which > will lead to crash, hence added preventive code to check > for NULL and accordingly dereference. > > Signed-off-by

Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Alexey Dobriyan
On Thu, Aug 16, 2018 at 03:04:13PM +0530, Srikanth K H wrote: > If the make directory for "sys" interface fail's then its > dereferenced without even checking for its validity which > will lead to crash, hence added preventive code to check > for NULL and accordingly dereference. > --- a/fs/proc/p

[PATCH 1/1] Preventive patch in the proc file-system to handle NULL check.

2018-08-16 Thread Srikanth K H
If the make directory for "sys" interface fail's then its dereferenced without even checking for its validity which will lead to crash, hence added preventive code to check for NULL and accordingly dereference. Signed-off-by: Srikanth K H --- fs/proc/proc_sysctl.c | 2 ++ 1 file changed, 2 inser

Re: A question about proc file system

2012-11-28 Thread Alan Cox
On Wed, 28 Nov 2012 02:55:30 + "Yangbin (Robin)" wrote: > Hi all: > > I write a kernel module which make a dir and create a file in proc file > system. > I use proc_mkdir() and create_proc_entry() in init and use > remove_proc_entry() in exit. > Now

A question about proc file system

2012-11-27 Thread Yangbin (Robin)
Hi all: I write a kernel module which make a dir and create a file in proc file system. I use proc_mkdir() and create_proc_entry() in init and use remove_proc_entry() in exit. Now I got a problem during my test: 1. open terminal A, insmod and cd into the dir the module created in proc

Max size of writing to the proc file system

2005-03-09 Thread Kristian Sørensen
Hi all! What is the maximal data I can write to a /proc file? I write two kilo bytes, but buffer in the proc_write function only contains 1003 bytes :-(( Cheers, Kristian. -- Kristian Sørensen - The Umbrella Project -- Security for Consumer Electronics http://umbrella.sourceforge.net - To

proc file system

2001-03-30 Thread Srinivas Surabhi
hi everybody, kindly give me a idea how to write a file into proc filesystem. i.e functions to be used?system calls to be be called? adv .thanks for giving imm. reply srinivas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR