Re: pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Benjamin Herrenschmidt
On Wed, 2007-07-25 at 18:30 -0500, Dave McCracken wrote: > On Wednesday 25 July 2007, Benjamin Herrenschmidt wrote: > > Depends... if you have CONFIG_HIGHMEM and not CONFIG_HIGHPTE, you are > > wasting time going through kmap_atomic unnecessarily no ? it will probably > > not do anything because th

Re: pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Dave McCracken
On Wednesday 25 July 2007, Benjamin Herrenschmidt wrote: > Depends... if you have CONFIG_HIGHMEM and not CONFIG_HIGHPTE, you are > wasting time going through kmap_atomic unnecessarily no ? it will probably > not do anything because the PTE page is in lowmem but still... Probably not much time. Yo

Re: pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 01:18 +0200, Andreas Schwab wrote: > Satya <[EMAIL PROTECTED]> writes: > > > hello, > > The implementation of pte_offset_map() for ppc assumes that PTEs are > > kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of > > pte_offset_map() as follows (include/asm-p

Re: pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Andreas Schwab
Satya <[EMAIL PROTECTED]> writes: > hello, > The implementation of pte_offset_map() for ppc assumes that PTEs are > kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of > pte_offset_map() as follows (include/asm-ppc/pgtable.h): > > #define pte_offset_map(dir, addr) \

Re: pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Benjamin Herrenschmidt
On Wed, 2007-07-25 at 17:16 -0500, Satya wrote: > hello, > The implementation of pte_offset_map() for ppc assumes that PTEs are > kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of > pte_offset_map() as follows (include/asm-ppc/pgtable.h): > > #define pte_offset_map(dir, addr)

pte_offset_map for ppc assumes HIGHPTE

2007-07-25 Thread Satya
hello, The implementation of pte_offset_map() for ppc assumes that PTEs are kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of pte_offset_map() as follows (include/asm-ppc/pgtable.h): #define pte_offset_map(dir, addr) \ ((pte_t *) kmap_atomic(pmd_page(*(dir