Re: qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

2017-05-09 Thread SF Markus Elfring
> The only benefit is a little bit higher performance. I would prefer such a small code reduction. I am not so concerned about an other readability impression at this place. > But for debugfs this won't be necessary. I would appreciate also another improvement there. Regards, Markus

Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

2017-05-09 Thread Stefan Wahren
Am 08.05.2017 um 19:29 schrieb SF Markus Elfring: > From: Markus Elfring > Date: Mon, 8 May 2017 19:21:27 +0200 > > A bit of data was put into a sequence by separate function calls. > Print the same data together with adjusted seq_printf() calls instead. Sorry, i'm not happy with this patch. It d

[PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 19:21:27 +0200 A bit of data was put into a sequence by separate function calls. Print the same data together with adjusted seq_printf() calls instead. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- driver