Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Julia Lawall
On Fri, 27 Dec 2013, Andrew Morton wrote: > On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall > wrote: > > > The function cmos_do_probe contains the code: > > > > if (is_hpet_enabled()) { > > int err; > > > >

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Andrew Morton
On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall wrote: > The function cmos_do_probe contains the code: > > if (is_hpet_enabled()) { > int err; > > rtc_cmos_int_handler = hpet_rtc_interrupt; > err =

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Julia Lawall
On Fri, 27 Dec 2013, Alessandro Zummo wrote: > On Wed, 25 Dec 2013 20:32:12 +0100 (CET) > Julia Lawall wrote: > > > > Is it intentional that the error code returned by > > hpet_register_irq_handler is put ina local variable that will not be seen > > at label cleanup1? The return value is

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Alessandro Zummo
On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall wrote: > Is it intentional that the error code returned by > hpet_register_irq_handler is put ina local variable that will not be seen > at label cleanup1? The return value is retval, which is 0 at this point. Well, I'd say it's an

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Alessandro Zummo
On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall julia.law...@lip6.fr wrote: Is it intentional that the error code returned by hpet_register_irq_handler is put ina local variable that will not be seen at label cleanup1? The return value is retval, which is 0 at this point. Well,

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Julia Lawall
On Fri, 27 Dec 2013, Alessandro Zummo wrote: On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall julia.law...@lip6.fr wrote: Is it intentional that the error code returned by hpet_register_irq_handler is put ina local variable that will not be seen at label cleanup1? The return

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Andrew Morton
On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall julia.law...@lip6.fr wrote: The function cmos_do_probe contains the code: if (is_hpet_enabled()) { int err; rtc_cmos_int_handler = hpet_rtc_interrupt;

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Julia Lawall
On Fri, 27 Dec 2013, Andrew Morton wrote: On Wed, 25 Dec 2013 20:32:12 +0100 (CET) Julia Lawall julia.law...@lip6.fr wrote: The function cmos_do_probe contains the code: if (is_hpet_enabled()) { int err;

question about drivers/rtc/rtc-cmos.c

2013-12-25 Thread Julia Lawall
The function cmos_do_probe contains the code: if (is_hpet_enabled()) { int err; rtc_cmos_int_handler = hpet_rtc_interrupt; err = hpet_register_irq_handler(cmos_interrupt); if (err !=

question about drivers/rtc/rtc-cmos.c

2013-12-25 Thread Julia Lawall
The function cmos_do_probe contains the code: if (is_hpet_enabled()) { int err; rtc_cmos_int_handler = hpet_rtc_interrupt; err = hpet_register_irq_handler(cmos_interrupt); if (err !=