Re: race in audit_log_untrusted_string for task_struct::comm

On Saturday, March 15, 2014 07:28:46 PM Richard Guy Briggs wrote: > I'm inclined to go get_task_comm() in all 5 locations, but if we care > more about locking overhead, I'll switch to memcpy(). > > Steve, do we care about the integrity of the comm field? In the case of interpreters, its about the

race in audit_log_untrusted_string for task_struct::comm

Hi, I'm investigating a race in audit_log_untrusted_string() in the case of task_struct::comm. Originally from commit 0a4ff8c2 audit_log_task() currently hands task_struct::comm directly to audit_log_untrusted_string() which can race if another task/thread on another CPU modifies it between the t