Re: add Packet hub driver for Topcliff Platform controller hub

2013-01-08 Thread Arnd Bergmann
On Tuesday 08 January 2013, Dan Carpenter wrote: > On Tue, Jan 08, 2013 at 10:49:14AM +, Arnd Bergmann wrote: > > On Monday 07 January 2013, Dan Carpenter wrote: > > > Sorry my question is about an old patch. Smatch complains because we > > > only pass a PAGE_SIZE buffer to sysfs files so the

Re: add Packet hub driver for Topcliff Platform controller hub

2013-01-08 Thread Dan Carpenter
On Tue, Jan 08, 2013 at 10:49:14AM +, Arnd Bergmann wrote: > On Monday 07 January 2013, Dan Carpenter wrote: > > Sorry my question is about an old patch. Smatch complains because we > > only pass a PAGE_SIZE buffer to sysfs files so the test for > > "if (count > PCH_PHUB_OROM_SIZE) {" makes it

Re: add Packet hub driver for Topcliff Platform controller hub

2013-01-08 Thread Dan Carpenter
On Tue, Jan 08, 2013 at 07:30:34PM +0900, Tomoya MORINAGA wrote: > Hi Dan, > > On Mon, Jan 7, 2013 at 6:02 PM, Dan Carpenter > wrote: > > The patch cf4ece53460c: "add Packet hub driver for Topcliff Platform > > controller hub" from Sep 1, 2010, leads to the following warning: > > drivers/misc/pc

Re: add Packet hub driver for Topcliff Platform controller hub

2013-01-08 Thread Arnd Bergmann
On Monday 07 January 2013, Dan Carpenter wrote: > Sorry my question is about an old patch. Smatch complains because we > only pass a PAGE_SIZE buffer to sysfs files so the test for > "if (count > PCH_PHUB_OROM_SIZE) {" makes it think we are overflowing. > In fact, count is never more than 4096 so

Re: add Packet hub driver for Topcliff Platform controller hub

2013-01-08 Thread Tomoya MORINAGA
Hi Dan, On Mon, Jan 7, 2013 at 6:02 PM, Dan Carpenter wrote: > The patch cf4ece53460c: "add Packet hub driver for Topcliff Platform > controller hub" from Sep 1, 2010, leads to the following warning: > drivers/misc/pch_phub.c:596 pch_phub_bin_write() > error: buffer overflow 'buf' 4096 <

re: add Packet hub driver for Topcliff Platform controller hub

2013-01-07 Thread Dan Carpenter
Hi Masayuki Ohtak, The patch cf4ece53460c: "add Packet hub driver for Topcliff Platform controller hub" from Sep 1, 2010, leads to the following warning: drivers/misc/pch_phub.c:596 pch_phub_bin_write() error: buffer overflow 'buf' 4096 <= 15359 Sorry my question is about an old patch.