Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-12 Thread Colin Ian King
On 12/03/2021 12:45, Andy Shevchenko wrote: > On Thu, Mar 11, 2021 at 1:26 PM Colin Ian King > wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> On 3/11/21 11:57 AM, Colin Ian King wrote: > For the PIN_MAP_TYPE_CONFIGS_PIN and PIN_MAP_TYPE_CONFIGS_GROUP setting->type cases the

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-12 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 1:26 PM Colin Ian King wrote: > On 11/03/2021 11:16, Michal Simek wrote: > > On 3/11/21 11:57 AM, Colin Ian King wrote: > >> For the PIN_MAP_TYPE_CONFIGS_PIN and PIN_MAP_TYPE_CONFIGS_GROUP > >> setting->type cases the loop can break out with ret not being set. Since > >>

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Linus Walleij
On Thu, Mar 11, 2021 at 12:28 PM Michal Simek wrote: > > It will take me 2 hours to re-run the analysis, but from eyeballing the > > code I think the assignments will fix this. > > would be good if you can rerun it and get back to us on this. > I will wait if something else will pop up and then

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Colin Ian King
On 11/03/2021 11:28, Michal Simek wrote: > > > On 3/11/21 12:24 PM, Colin Ian King wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> >>> >>> On 3/11/21 11:57 AM, Colin Ian King wrote: Hi, Static analysis on linux-next with Coverity has found a potential issue in

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Michal Simek
On 3/11/21 12:24 PM, Colin Ian King wrote: > On 11/03/2021 11:16, Michal Simek wrote: >> >> >> On 3/11/21 11:57 AM, Colin Ian King wrote: >>> Hi, >>> >>> Static analysis on linux-next with Coverity has found a potential issue >>> in drivers/pinctrl/core.c with the following commit: >>> >>>

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Colin Ian King
On 11/03/2021 11:16, Michal Simek wrote: > > > On 3/11/21 11:57 AM, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next with Coverity has found a potential issue >> in drivers/pinctrl/core.c with the following commit: >> >> commit 0952b7ec1614abf232e921aac0cc2bca8e60e162 >> Author:

Re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Michal Simek
On 3/11/21 11:57 AM, Colin Ian King wrote: > Hi, > > Static analysis on linux-next with Coverity has found a potential issue > in drivers/pinctrl/core.c with the following commit: > > commit 0952b7ec1614abf232e921aac0cc2bca8e60e162 > Author: Michal Simek > Date: Wed Mar 10 09:16:54 2021

re: pinctrl: core: Handling pinmux and pinconf separately

2021-03-11 Thread Colin Ian King
Hi, Static analysis on linux-next with Coverity has found a potential issue in drivers/pinctrl/core.c with the following commit: commit 0952b7ec1614abf232e921aac0cc2bca8e60e162 Author: Michal Simek Date: Wed Mar 10 09:16:54 2021 +0100 pinctrl: core: Handling pinmux and pinconf separately