Re: security/loadpin: Allow to exclude specific file types

2019-06-04 Thread Ke Wu
I sent out a new patch according to your last suggestion. Please take a look. Thanks! On Fri, May 31, 2019 at 1:33 PM Kees Cook wrote: > > On Fri, May 31, 2019 at 11:03:17AM -0700, Ke Wu wrote: > > I think Coverity is correct. Note that it's the size of > > kernel_read_file_str (rather than excl

Re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Kees Cook
On Fri, May 31, 2019 at 11:03:17AM -0700, Ke Wu wrote: > I think Coverity is correct. Note that it's the size of > kernel_read_file_str (rather than exclude_read_files) doesn't equal to > ignore_read_file_id. > > This is because READING_MAX_ID is also an element in > kernel_read_file_str, which ma

Re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Ke Wu
I think Coverity is correct. Note that it's the size of kernel_read_file_str (rather than exclude_read_files) doesn't equal to ignore_read_file_id. This is because READING_MAX_ID is also an element in kernel_read_file_str, which makes the size of kernel_read_file_str to be READING_MAX_ID+1. I will

Re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Colin Ian King
On 31/05/2019 15:44, Kees Cook wrote: > On Fri, May 31, 2019 at 11:46:29AM +0100, Colin Ian King wrote: >> Hi, >> >> Static analysis with Coverity on linux-next has found a potential issue >> with the following commit: >> >> commit 1633a4f04cc171fc638deb5c95af96032d3c591b >> Author: Ke Wu >> Date:

Re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Kees Cook
On Fri, May 31, 2019 at 11:46:29AM +0100, Colin Ian King wrote: > Hi, > > Static analysis with Coverity on linux-next has found a potential issue > with the following commit: > > commit 1633a4f04cc171fc638deb5c95af96032d3c591b > Author: Ke Wu > Date: Thu May 30 12:22:08 2019 -0700 > > sec

re: security/loadpin: Allow to exclude specific file types

2019-05-31 Thread Colin Ian King
Hi, Static analysis with Coverity on linux-next has found a potential issue with the following commit: commit 1633a4f04cc171fc638deb5c95af96032d3c591b Author: Ke Wu Date: Thu May 30 12:22:08 2019 -0700 security/loadpin: Allow to exclude specific file types 209for (j = 0;