Re: reinstate dm target local ioctl support

2016-01-29 Thread Andy Whitcroft
On Fri, Jan 29, 2016 at 01:57:12PM +, Alasdair G Kergon wrote: > On Thu, Jan 28, 2016 at 01:50:19PM +, Andy Whitcroft wrote: > > However this also removed the possibility of a dm target having target > > specific ioctls. Currently this is not used by any in-tree targets but > > was utilise

Re: reinstate dm target local ioctl support

2016-01-29 Thread Alasdair G Kergon
On Thu, Jan 28, 2016 at 01:50:19PM +, Andy Whitcroft wrote: > However this also removed the possibility of a dm target having target > specific ioctls. Currently this is not used by any in-tree targets but > was utilised by the flashcache out-of-tree module. What data is being passed in and

Re: [dm-devel] reinstate dm target local ioctl support

2016-01-29 Thread Joe Thornber
On Thu, Jan 28, 2016 at 01:50:19PM +, Andy Whitcroft wrote: > How would we feel about carrying something like the patch below in > mainline to allow for such target local ioctls. You can send a dm message to individual targets. No need for target specific ioctls. - Joe

Re: reinstate dm target local ioctl support

2016-01-28 Thread Christoph Hellwig
On Thu, Jan 28, 2016 at 01:50:19PM +, Andy Whitcroft wrote: > However this also removed the possibility of a dm target having target > specific ioctls. Currently this is not used by any in-tree targets but > was utilised by the flashcache out-of-tree module. > > How would we feel about carryi

reinstate dm target local ioctl support

2016-01-28 Thread Andy Whitcroft
With the commit below the dm ioctl support was reordered so that the target only had to identify the underlying device, the dm_blk_ioctl() itself then applied those ioctls to the appropriate device: commit e56f81e0b01ef4e45292d8c1e19edd4d09724e14 Author: Christoph Hellwig Date: Thu Oct 15