Re: [PATCH] Re: reiserfs: still problems with tail conversion

2001-02-26 Thread Ken Moffat
Chris, it works nicely here (i586, 32Mb, Red Hat's gcc-2.96-69). Thanks. Ken On Sun, 25 Feb 2001, Chris Mason wrote: > > Hi guys, > > This patch should take care of the other cause for null bytes > in small files. It has been through a few hours of testing, > with some of the usual load p

Re: [PATCH] Re: reiserfs: still problems with tail conversion

2001-02-26 Thread Erik Mouw
On Mon, Feb 26, 2001 at 12:07:04PM +0100, Erik Mouw wrote: > On Sun, Feb 25, 2001 at 09:40:44PM -0500, Chris Mason wrote: > > Any testing on non-production machines would be appreciated, > > I'll forward to Linus/Alan once I've gotten more feedback. > > Yes, this did the trick, I can't repeat it

Re: [PATCH] Re: reiserfs: still problems with tail conversion

2001-02-26 Thread Erik Mouw
On Sun, Feb 25, 2001 at 09:40:44PM -0500, Chris Mason wrote: > This patch should take care of the other cause for null bytes > in small files. It has been through a few hours of testing, > with some of the usual load programs + Erik's code concurrently. > > I'll let things run overnight to try a

[PATCH] Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Chris Mason
Hi guys, This patch should take care of the other cause for null bytes in small files. It has been through a few hours of testing, with some of the usual load programs + Erik's code concurrently. I'll let things run overnight to try and find more bugs. The patch is against 2.4.2, and does a f

Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Chris Mason
Ok, found it. It is related to the last null byte problem in that it also only happens when the direct item is split between two blocks. This is more likely as the tail increases in size, which is why you saw it on larger small files. The bug is in the code that zeros the unused part of the un

Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Erik Mouw
On Sun, Feb 25, 2001 at 05:37:52PM +0100, Erik Mouw wrote: > I upgraded to 2.4.2, and initially I couldn't reproduce the problem. > Besides the kernel version difference, another difference was the fact > that I did the 2.4.2. test on a freshly booted system, while the > 2.4.2-pre4 test was done o

Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Erik Mouw
On Fri, Feb 23, 2001 at 11:19:49PM +0100, Erik Mouw wrote: > On Fri, Feb 23, 2001 at 05:10:46PM -0500, Chris Mason wrote: > > Many thanks for sending along a test program for reproducing. But, it > > doesn't seem to reproduce the problem here, how many times did you have to > > run it to see the

Re: reiserfs: still problems with tail conversion

2001-02-25 Thread Alan Cox
> I have seen null byte corruptions in syslog files with ext2 in various > kernels. So perhaps it is a general VFS problem? Im very dubious. The post fsck nulls in syslog case is a well understood one with the box crashing as it extends the file and never gets to commit the data bytes. Different

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Mike Galbraith
On Sun, 25 Feb 2001, Bernd Eckenfels wrote: > In article <87861.983061717@tiny> you wrote: > > Exactly. The tail conversion code depends heavily on the page up to date > > bit being set right. It is more than possible that I've screwed up > > something there, and the code thinks a page is v

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Bernd Eckenfels
In article <87861.983061717@tiny> you wrote: > Exactly. The tail conversion code depends heavily on the page up to date > bit being set right. It is more than possible that I've screwed up > something there, and the code thinks a page is valid when it really isn't. I have seen null byte cor

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Chris Mason
On Saturday, February 24, 2001 08:53:15 PM + Alan Cox <[EMAIL PROTECTED]> wrote: >> 32Mb. The test results vary depending on what else is on the partition, >> but in each case the last file affected is 01017 and there are sequences >> of previous_number+4, for up to 8 files (but next file a

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Alan Cox
> 32Mb. The test results vary depending on what else is on the partition, > but in each case the last file affected is 01017 and there are sequences > of previous_number+4, for up to 8 files (but next file after this might be > previous+7 or previous +15, or sporadic). From other problems I've see

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Ken Moffat
(reisertest) I get the same problems with straight 2.4.2, machine is a k5 with 32Mb. The test results vary depending on what else is on the partition, but in each case the last file affected is 01017 and there are sequences of previous_number+4, for up to 8 files (but next file after this might b

Re: [lkml]Re: reiserfs: still problems with tail conversion

2001-02-24 Thread thunder7
On Sat, Feb 24, 2001 at 04:45:04PM +0100, Arjan Filius wrote: > Hello, > > I tried Erik's trigger-program. > > After some test i thing it's memory related, and it seems to match the > other reports i saw on lkm. > With my 384M ram i was not able te reproduce it. > With "mem=32M" linux hang while

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Chris Mason
On Saturday, February 24, 2001 04:45:04 PM +0100 Arjan Filius <[EMAIL PROTECTED]> wrote: > Hello, > > I tried Erik's trigger-program. > > After some test i thing it's memory related, and it seems to match the > other reports i saw on lkm. > With my 384M ram i was not able te reproduce it. > W

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread Arjan Filius
Hello, I tried Erik's trigger-program. After some test i thing it's memory related, and it seems to match the other reports i saw on lkm. With my 384M ram i was not able te reproduce it. With "mem=32M" linux hang while starting a test oracle-db. However i tried (not repeated tests, and after a f

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread John E. Adams
On Friday 23 February 2001 16:18, Erik Mouw wrote: > Hi all, > > I am running linux-2.4.2-pre4 with Chris Mason's tailconversion bug fix > applied, but I still have problems with null bytes in files. I wrote a > little test program that clearly shows the problem: I tried the test pgm. First run d

Re: reiserfs: still problems with tail conversion

2001-02-24 Thread thunder7
On Fri, Feb 23, 2001 at 11:19:49PM +0100, Erik Mouw wrote: > I got them immediately at the first run, which more or less was what I > expected because reiserfs ate one of my mailfolders that way (only a > CVS log folder, so nothing special was lost). You have to remove the > files between runs, ot

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Meino Christian Cramer
From: Michal Gornisiewicz <[EMAIL PROTECTED]> Subject: Re: reiserfs: still problems with tail conversion Date: Sat, 24 Feb 2001 10:52:07 +0800 Message-ID: <[EMAIL PROTECTED]> I'm running 2.4.2ac3 and tried also the reisertest program. No problems here... The created files are

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Michal Gornisiewicz
On Saturday 24 February 2001 06:19, Erik Mouw wrote: > I'll upgrade to linux-2.4.2 to see if it solves the problem. (was > running 2.4.2-pre4 + your patch) > > > Erik I'm running 2.4.2 and I get similar results using your test program. This is on an IBM 390 Laptop. P2-233, 96mb RAM, 3.2gb HDD. S

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Oliver Teuber
On Fri, Feb 23, 2001 at 05:10:46PM -0500, Chris Mason wrote: > On Friday, February 23, 2001 10:18:56 PM +0100 Erik Mouw > <[EMAIL PROTECTED]> wrote: > > I am running linux-2.4.2-pre4 with Chris Mason's tailconversion bug fix > > applied, but I still have problems with null bytes in files. I wrote

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Erik Mouw
On Fri, Feb 23, 2001 at 05:10:46PM -0500, Chris Mason wrote: > Many thanks for sending along a test program for reproducing. But, it > doesn't seem to reproduce the problem here, how many times did you have to > run it to see the null bytes? Do you remove the files between runs? I got them imme

Re: reiserfs: still problems with tail conversion

2001-02-23 Thread Chris Mason
On Friday, February 23, 2001 10:18:56 PM +0100 Erik Mouw <[EMAIL PROTECTED]> wrote: > Hi all, > > I am running linux-2.4.2-pre4 with Chris Mason's tailconversion bug fix > applied, but I still have problems with null bytes in files. I wrote a > little test program that clearly shows the proble

reiserfs: still problems with tail conversion

2001-02-23 Thread Erik Mouw
Hi all, I am running linux-2.4.2-pre4 with Chris Mason's tailconversion bug fix applied, but I still have problems with null bytes in files. I wrote a little test program that clearly shows the problem: /* reisertest.c: test for tailconversion bug in reiserfs * * Compile with: gcc -O2 -o reis