Re: reiserfs NET=n build error

2006-12-04 Thread Neil Brown
On Monday December 4, [EMAIL PROTECTED] wrote: > > Ingo, Neil: > > Al has summarized that csum_partial() is arch-specific. > However, drivers/md/md.c uses it. Yep. > > Does that mean that RAID volumes are not portable across > (some) architectures? Yep. version-0.90 superblocks are already n

Re: reiserfs NET=n build error

2006-12-04 Thread Randy Dunlap
On Tue, 28 Nov 2006 11:47:57 -0800 Randy Dunlap wrote: > On Sun, 19 Nov 2006 17:32:11 -0500 Jeff Mahoney wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Al Viro wrote: > > > On Sun, Nov 19, 2006 at 11:04:33AM -0800, Randy Dunlap wrote: > > >> Andi Kleen wrote: > > > I

Re: reiserfs NET=n build error

2006-11-28 Thread Randy Dunlap
On Sun, 19 Nov 2006 17:32:11 -0500 Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Al Viro wrote: > > On Sun, Nov 19, 2006 at 11:04:33AM -0800, Randy Dunlap wrote: > >> Andi Kleen wrote: > > I would copy a relatively simple C implementation, like > > arch/h8300/

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Al Viro wrote: > On Sun, Nov 19, 2006 at 11:04:33AM -0800, Randy Dunlap wrote: >> Andi Kleen wrote: > I would copy a relatively simple C implementation, like > arch/h8300/lib/checksum.c As long as the h8300 version has the same output as

Re: reiserfs NET=n build error

2006-11-19 Thread Randy Dunlap
On Sun, 19 Nov 2006 20:57:11 + Al Viro wrote: > On Sun, Nov 19, 2006 at 11:04:33AM -0800, Randy Dunlap wrote: > > Andi Kleen wrote: > > >>>I would copy a relatively simple C implementation, like > > >>>arch/h8300/lib/checksum.c > > >>As long as the h8300 version has the same output as the x86

Re: reiserfs NET=n build error

2006-11-19 Thread Al Viro
On Sun, Nov 19, 2006 at 11:04:33AM -0800, Randy Dunlap wrote: > Andi Kleen wrote: > >>>I would copy a relatively simple C implementation, like > >>>arch/h8300/lib/checksum.c > >>As long as the h8300 version has the same output as the x86 version. > > > >The trouble is that the different architectu

Re: reiserfs NET=n build error

2006-11-19 Thread Al Viro
On Sun, Nov 19, 2006 at 12:09:22PM -0500, Jeff Mahoney wrote: > > I would copy a relatively simple C implementation, like > > arch/h8300/lib/checksum.c > > As long as the h8300 version has the same output as the x86 version. As the matter of fact, h8300 version is severely broken and no, it defi

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: >>> I would copy a relatively simple C implementation, like >>> arch/h8300/lib/checksum.c >> As long as the h8300 version has the same output as the x86 version. > > The trouble is that the different architecture have different outp

Re: reiserfs NET=n build error

2006-11-19 Thread Randy Dunlap
Andi Kleen wrote: I would copy a relatively simple C implementation, like arch/h8300/lib/checksum.c As long as the h8300 version has the same output as the x86 version. The trouble is that the different architecture have different output for csum_partial. So you already got a bug when someon

Re: reiserfs NET=n build error

2006-11-19 Thread Andi Kleen
> > I would copy a relatively simple C implementation, like > > arch/h8300/lib/checksum.c > > As long as the h8300 version has the same output as the x86 version. The trouble is that the different architecture have different output for csum_partial. So you already got a bug when someone wants

Re: reiserfs NET=n build error

2006-11-19 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andi Kleen wrote: > On Sunday 19 November 2006 05:22, Randy Dunlap wrote: >> With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with >> >> Kernel: arch/x86_64/boot/bzImage is ready (#15) >> Building modules, stage 2. >> MODPOST 13

Re: [discuss] Re: reiserfs NET=n build error

2006-11-19 Thread Andi Kleen
> Therefore, an EXPORT_SYMBOL in a lib-y object is a bug. True. I think that got added when the EXPORT_SYMBOL was moved into the individual .c file. It would be better to move it back into some other file inside a #ifdef CONFIG_NET. And fix reiserfs to not use it because it shouldn't anyways.

Re: reiserfs NET=n build error

2006-11-19 Thread Adrian Bunk
On Sat, Nov 18, 2006 at 08:22:06PM -0800, Randy Dunlap wrote: > With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with > > Kernel: arch/x86_64/boot/bzImage is ready (#15) > Building modules, stage 2. > MODPOST 137 modules > WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] u

Re: reiserfs NET=n build error

2006-11-18 Thread Andi Kleen
On Sunday 19 November 2006 05:22, Randy Dunlap wrote: > With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with > > Kernel: arch/x86_64/boot/bzImage is ready (#15) > Building modules, stage 2. > MODPOST 137 modules > WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined

reiserfs NET=n build error

2006-11-18 Thread Randy Dunlap
With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with Kernel: arch/x86_64/boot/bzImage is ready (#15) Building modules, stage 2. MODPOST 137 modules WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 on