RE: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-10 Thread David Laight
From: j...@joshtriplett.org > On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: > > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > > > From: Alistair Popple > > > Date: Thu, 6 Mar 2014 14:52:25 +1100 > > > > > > > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIE

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Sat, 2014-03-08 at 02:04 +0300, Dan Carpenter wrote: > On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote: > > On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: > > > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > > > > From: Alistair Popple > > > > Date:

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Dan Carpenter
On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote: > On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: > > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > > > From: Alistair Popple > > > Date: Thu, 6 Mar 2014 14:52:25 +1100 > > > > > > > + out_be32(d

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
On Fri, 2014-03-07 at 13:30 -0800, j...@joshtriplett.org wrote: > On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: > > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > > > From: Alistair Popple > > > Date: Thu, 6 Mar 2014 14:52:25 +1100 > > > > > > > + out_be32(dev->reg

Re: rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread josh
On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote: > On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > > From: Alistair Popple > > Date: Thu, 6 Mar 2014 14:52:25 +1100 > > > > > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN > > > + | WKUP_ETH_TX_OE | WKUP_ET

rfc: checkpatch logical line continuations (was IBM Akebono: Add support for a new PHY interface to the IBM emac driver)

2014-03-07 Thread Joe Perches
(added some cc's) On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote: > From: Alistair Popple > Date: Thu, 6 Mar 2014 14:52:25 +1100 > > > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN > > +| WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); > > When an expression spans multiple l