Re: [PATCH v3] samsung-laptop: enable better lid handling

2015-02-06 Thread Darren Hart
On Thu, Jan 29, 2015 at 01:04:37PM +, Julijonas Kikutis wrote: > Some Samsung laptops with SABI3 delay the sleep for 10 seconds after > the lid is closed and do not wake up from sleep after the lid is opened. > A SABI command is needed to enable the better behavior. > > Command = 0x6e, d0 = 0x

Re: [PATCH v2] samsung-laptop: enable better lid handling

2015-01-29 Thread Julijonas Kikutis
> Patch is generally fine, thanks for addressing my comments. Prior to merging I > always run checkpatch.pl just in case I missed anything obvious: > > $ scripts/checkpatch.pl ~/samsung/01-lid-handling.patch > WARNING: Prefer kstrto to single variable sscanf > #219: FILE: drivers/platform/x86/sam

[PATCH v3] samsung-laptop: enable better lid handling

2015-01-29 Thread Julijonas Kikutis
Some Samsung laptops with SABI3 delay the sleep for 10 seconds after the lid is closed and do not wake up from sleep after the lid is opened. A SABI command is needed to enable the better behavior. Command = 0x6e, d0 = 0x81 enables this behavior. Returns d0 = 0x01. Command = 0x6e, d0 = 0x80 disabl

Re: [PATCH v2] samsung-laptop: enable better lid handling

2015-01-28 Thread Darren Hart
On Tue, Jan 27, 2015 at 01:26:06PM +, Julijonas Kikutis wrote: > Some Samsung laptops with SABI3 delay the sleep for 10 seconds after > the lid is closed and do not wake up from sleep after the lid is opened. > A SABI command is needed to enable the better behavior. > > Command = 0x6e, d0 = 0x

Re: [PATCH] samsung-laptop: enable better lid handling

2015-01-27 Thread Julijonas Kikutis
> > However, a user with another laptop in the bug report says that "power > > button has to be pressed twice to wake the machine" in this mode. > > This is with this patch applied? No, the commenter in bugzilla reports that it happened after manually outputting the command to debugfs. Of course,

[PATCH v2] samsung-laptop: enable better lid handling

2015-01-27 Thread Julijonas Kikutis
Some Samsung laptops with SABI3 delay the sleep for 10 seconds after the lid is closed and do not wake up from sleep after the lid is opened. A SABI command is needed to enable the better behavior. Command = 0x6e, d0 = 0x81 enables this behavior. Returns d0 = 0x01. Command = 0x6e, d0 = 0x80 disabl

Re: [PATCH] samsung-laptop: enable better lid handling

2015-01-27 Thread Corentin Chary
On Tue, Jan 27, 2015 at 2:52 AM, Darren Hart wrote: > On Thu, Dec 11, 2014 at 09:18:35PM +, Julijonas Kikutis wrote: > > Hi Julijonas, > > Please Cc the maintainer listed in the MAINTERS file for a faster response. The easiest to do that is to use " git send-email --cc-cmd=scripts/get_maintai

Re: [PATCH] samsung-laptop: enable better lid handling

2015-01-26 Thread Darren Hart
On Thu, Dec 11, 2014 at 09:18:35PM +, Julijonas Kikutis wrote: Hi Julijonas, Please Cc the maintainer listed in the MAINTERS file for a faster response. > Some Samsung laptops with SABI3 delay the sleep for 10 seconds after > the lid is closed and do not wake up from sleep after the lid is o

samsung-laptop: enable better lid handling

2015-01-14 Thread Julijonas Kikutis
Hello, I sent the patch to linux-kernel, platform-driver-x86, and to the maintainer of samsung-laptop a month ago and have not received any response. Any response would be welcome. I have some additional thoughts about the patch. I don't know whether it is a

[PATCH] samsung-laptop: enable better lid handling

2014-12-11 Thread Julijonas Kikutis
Some Samsung laptops with SABI3 delay the sleep for 10 seconds after the lid is closed and do not wake up from sleep after the lid is opened. A SABI command is needed to enable the better behavior. Command = 0x6e, d0 = 0x81 enables this behavior. Returns d0 = 0x01. Command = 0x6e, d0 = 0x80 disabl