Re: sata_sil 3112 activity LED patch

2005-07-15 Thread Christian Kroll
On Fri, Jul 15, 2005 at 02:57PM +0900, Aric Cyr wrote: > Out of curiosity, did the LED > usage change at all before and after the patch, or was it totally > unaffected. I would guess the latter. It was totally unaffected. If the LED is turned on by the BIOS (while it examines the bus at boot time

Re: sata_sil 3112 activity LED patch

2005-07-14 Thread Aric Cyr
On Fri, Jul 15, 2005 at 04:15:12AM +0200, Christian Kroll wrote: > I have tested the patch against my DawiControl DC-150 RAID controller > which is basically an add-on card with a SiI 3112 ASIC and a flash ROM. > The activity LED of my case is directly connected to the add-on card. > > Unfortunate

Re: sata_sil 3112 activity LED patch

2005-07-14 Thread Christian Kroll
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, I have tested the patch against my DawiControl DC-150 RAID controller which is basically an add-on card with a SiI 3112 ASIC and a flash ROM. The activity LED of my case is directly connected to the add-on card. Unfortunately your patch doesn'

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
On Thu, Jul 07 2005, Aric Cyr wrote: > > There's also an existing variant of this in the block layer, the > > activity_fn, that we use on the ibook/powerbook to use the sleep led as > > an activity light. Just in case you prefer that to overloading the bmdma > > start/stop handlers. > > You sugges

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Aric Cyr
On Thu, Jul 07, 2005 at 02:47:03PM +0200, Jens Axboe wrote: > On Wed, Jul 06 2005, Jeff Garzik wrote: > > I don't think its ugly, necessarily. I do worry about the flash memory > > stuff, though, which is why I don't want to merge this upstream for now. > > > > For your patch specifically, it wo

Re: sata_sil 3112 activity LED patch

2005-07-07 Thread Jens Axboe
On Wed, Jul 06 2005, Jeff Garzik wrote: > Aric Cyr wrote: > >After finally getting fed up with not having my activity light working > >for my SATA drives, I came up with a small patch (more like hack) to > >make it work. It works quite well, but I'm afraid that there are many > >restriction that t

Re: sata_sil 3112 activity LED patch

2005-07-06 Thread Jeff Garzik
Aric Cyr wrote: After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this patch does not check for that it probably should

sata_sil 3112 activity LED patch

2005-07-05 Thread Aric Cyr
After finally getting fed up with not having my activity light working for my SATA drives, I came up with a small patch (more like hack) to make it work. It works quite well, but I'm afraid that there are many restriction that this patch does not check for that it probably should... so consider th