Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 09:15:21PM +0900, Sergey Senozhatsky wrote: > > I'll repost my patches now; otherwise I'll forget again anyway. > > #define printk printk_deferred > > should also do the trick and... make the kernel great again! :) That makes the kernel die silently, instead of first

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 09:15:21PM +0900, Sergey Senozhatsky wrote: > > I'll repost my patches now; otherwise I'll forget again anyway. > > #define printk printk_deferred > > should also do the trick and... make the kernel great again! :) That makes the kernel die silently, instead of first

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 14:07), Peter Zijlstra wrote: [..] > > Nah.. WARN's _should_ not trigger. If they do we fix that. > > > > Getting a lockdep splat after a WARN is something I can live with. > > > > And you really don't want that deferred nonsense for WARNs, because that > > means you'll risk not

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 14:07), Peter Zijlstra wrote: [..] > > Nah.. WARN's _should_ not trigger. If they do we fix that. > > > > Getting a lockdep splat after a WARN is something I can live with. > > > > And you really don't want that deferred nonsense for WARNs, because that > > means you'll risk not

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 02:05:32PM +0200, Peter Zijlstra wrote: > (please linewrap normal text at 72 chars) > > On Thu, Sep 28, 2017 at 11:45:30AM +, Levin, Alexander (Sasha Levin) > wrote: > > Okay, that seems to have delt with the callbacks supressed issue. > > > > I also seem to be

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 02:05:32PM +0200, Peter Zijlstra wrote: > (please linewrap normal text at 72 chars) > > On Thu, Sep 28, 2017 at 11:45:30AM +, Levin, Alexander (Sasha Levin) > wrote: > > Okay, that seems to have delt with the callbacks supressed issue. > > > > I also seem to be

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
(please linewrap normal text at 72 chars) On Thu, Sep 28, 2017 at 11:45:30AM +, Levin, Alexander (Sasha Levin) wrote: > Okay, that seems to have delt with the callbacks supressed issue. > > I also seem to be hitting it as a result of the scheduler triggering a > WARN, where

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
(please linewrap normal text at 72 chars) On Thu, Sep 28, 2017 at 11:45:30AM +, Levin, Alexander (Sasha Levin) wrote: > Okay, that seems to have delt with the callbacks supressed issue. > > I also seem to be hitting it as a result of the scheduler triggering a > WARN, where

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 11:45), Levin, Alexander (Sasha Levin) wrote: [..] > Now I'm not sure what's your approach here, do we keep converting printk to > printk_deferred one by one until we whacked every mole? well... basically, yes. -ss

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 11:45), Levin, Alexander (Sasha Levin) wrote: [..] > Now I'm not sure what's your approach here, do we keep converting printk to > printk_deferred one by one until we whacked every mole? well... basically, yes. -ss

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 13:47), Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote: > > --- > > > > lib/ratelimit.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > > index

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 13:47), Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote: > > --- > > > > lib/ratelimit.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > > index

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 08:36:07PM +0900, Sergey Senozhatsky wrote: >On (09/28/17 19:30), Sergey Senozhatsky wrote: >> lib/ratelimit.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lib/ratelimit.c b/lib/ratelimit.c >> index 08f8043cac61..bddc55834c2e 100644 >> ---

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 08:36:07PM +0900, Sergey Senozhatsky wrote: >On (09/28/17 19:30), Sergey Senozhatsky wrote: >> lib/ratelimit.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/lib/ratelimit.c b/lib/ratelimit.c >> index 08f8043cac61..bddc55834c2e 100644 >> ---

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote: > --- > > lib/ratelimit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > index 08f8043cac61..bddc55834c2e 100644 > --- a/lib/ratelimit.c > +++ b/lib/ratelimit.c >

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 07:30:32PM +0900, Sergey Senozhatsky wrote: > --- > > lib/ratelimit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > index 08f8043cac61..bddc55834c2e 100644 > --- a/lib/ratelimit.c > +++ b/lib/ratelimit.c >

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 08:13:26PM +0900, Sergey Senozhatsky wrote: > On (09/28/17 11:04), Levin, Alexander (Sasha Levin) wrote: > > On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: > > >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > > >> Hi all, > > >> > > >> I seem

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 08:13:26PM +0900, Sergey Senozhatsky wrote: > On (09/28/17 11:04), Levin, Alexander (Sasha Levin) wrote: > > On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: > > >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > > >> Hi all, > > >> > > >> I seem

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 19:30), Sergey Senozhatsky wrote: > lib/ratelimit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > index 08f8043cac61..bddc55834c2e 100644 > --- a/lib/ratelimit.c > +++ b/lib/ratelimit.c > @@ -48,7 +48,8 @@ int

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 19:30), Sergey Senozhatsky wrote: > lib/ratelimit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/ratelimit.c b/lib/ratelimit.c > index 08f8043cac61..bddc55834c2e 100644 > --- a/lib/ratelimit.c > +++ b/lib/ratelimit.c > @@ -48,7 +48,8 @@ int

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 11:04), Levin, Alexander (Sasha Levin) wrote: > On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: > >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > >> Hi all, > >> > >> I seem to be hitting the following warning when offlining CPUs on the > >> latest

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
On (09/28/17 11:04), Levin, Alexander (Sasha Levin) wrote: > On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: > >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > >> Hi all, > >> > >> I seem to be hitting the following warning when offlining CPUs on the > >> latest

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: >> Hi all, >> >> I seem to be hitting the following warning when offlining CPUs on the >> latest -next kernel: >> >> [289683102.607076] Unregister pv shared memory for cpu

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Levin, Alexander (Sasha Levin)
On Thu, Sep 28, 2017 at 11:38:47AM +0200, Peter Zijlstra wrote: >On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: >> Hi all, >> >> I seem to be hitting the following warning when offlining CPUs on the >> latest -next kernel: >> >> [289683102.607076] Unregister pv shared memory for cpu

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
Hi all, Peter, thanks for Cc-ing. On (09/28/17 11:38), Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > > Hi all, > > > > I seem to be hitting the following warning when offlining CPUs on the > > latest -next kernel: > > > > [289683102.607076] Unregister

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sergey Senozhatsky
Hi all, Peter, thanks for Cc-ing. On (09/28/17 11:38), Peter Zijlstra wrote: > On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > > Hi all, > > > > I seem to be hitting the following warning when offlining CPUs on the > > latest -next kernel: > > > > [289683102.607076] Unregister

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > Hi all, > > I seem to be hitting the following warning when offlining CPUs on the > latest -next kernel: > > [289683102.607076] Unregister pv shared memory for cpu 8 > [289683102.622922] select_fallback_rq: 3 callbacks suppressed

Re: sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Peter Zijlstra
On Thu, Sep 28, 2017 at 02:19:46AM -0700, Sasha Levin wrote: > Hi all, > > I seem to be hitting the following warning when offlining CPUs on the > latest -next kernel: > > [289683102.607076] Unregister pv shared memory for cpu 8 > [289683102.622922] select_fallback_rq: 3 callbacks suppressed

sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sasha Levin
Hi all, I seem to be hitting the following warning when offlining CPUs on the latest -next kernel: [289683102.607076] Unregister pv shared memory for cpu 8 [289683102.622922] select_fallback_rq: 3 callbacks suppressed [289683102.625834] process 8583 (trinity-c78) no longer affine to cpu8

sched: serial port lockdep warning when offlining CPUs

2017-09-28 Thread Sasha Levin
Hi all, I seem to be hitting the following warning when offlining CPUs on the latest -next kernel: [289683102.607076] Unregister pv shared memory for cpu 8 [289683102.622922] select_fallback_rq: 3 callbacks suppressed [289683102.625834] process 8583 (trinity-c78) no longer affine to cpu8