[patch 2/3] sdio: set the functions' block size

2007-08-08 Thread David Vrabel
-- David Vrabel, Software Engineer, Drivers group Tel: +44 (0)1223 692562 CSR plc, Churchill House, Cambridge Business Park, Cowley Road, CB4 0WZ . sdio: set the functions' block size Before a driver is probed, set the function's block size to the default so the driver is sure the

Re: [patch 2/4] sdio: set the functions' block size

2007-08-08 Thread David Vrabel
Pierre Ossman wrote: > On Wed, 08 Aug 2007 10:46:24 +0100 > David Vrabel <[EMAIL PROTECTED]> wrote: > >> Pierre Ossman wrote: A driver might enable/disable a function multiple times but there's no need to set the block size every time. >>> Why would it want to do that? >> A function enab

Re: [patch 2/4] sdio: set the functions' block size

2007-08-08 Thread Pierre Ossman
On Wed, 08 Aug 2007 10:46:24 +0100 David Vrabel <[EMAIL PROTECTED]> wrote: > Pierre Ossman wrote: > > > >> A driver might enable/disable a function multiple > >> times but there's no need to set the block size every time. > > > > Why would it want to do that? > > A function enable/disable cycle

Re: [patch 2/4] sdio: set the functions' block size

2007-08-08 Thread David Vrabel
Pierre Ossman wrote: > >> A driver might enable/disable a function multiple >> times but there's no need to set the block size every time. > > Why would it want to do that? A function enable/disable cycle should act as a per-function reset. David -- David Vrabel, Software Engineer, Drivers gro

Re: [patch 2/4] sdio: set the functions' block size

2007-08-07 Thread Pierre Ossman
On Tue, 07 Aug 2007 18:20:26 +0100 David Vrabel <[EMAIL PROTECTED]> wrote: > Pierre Ossman wrote: > > On Tue, 07 Aug 2007 13:54:32 +0100 > > David Vrabel <[EMAIL PROTECTED]> wrote: > > > >> > >> Index: mmc/drivers/mmc/core/sdio.c > >>

Re: [patch 2/4] sdio: set the functions' block size

2007-08-07 Thread David Vrabel
Pierre Ossman wrote: > On Tue, 07 Aug 2007 13:54:32 +0100 > David Vrabel <[EMAIL PROTECTED]> wrote: > >> >> Index: mmc/drivers/mmc/core/sdio.c >> === >> --- mmc.orig/drivers/mmc/core/sdio.c 2007-08-07 >> 00:38:33.0 +0100 +++

Re: [patch 2/4] sdio: set the functions' block size

2007-08-07 Thread Pierre Ossman
On Tue, 07 Aug 2007 13:54:32 +0100 David Vrabel <[EMAIL PROTECTED]> wrote: > > Index: mmc/drivers/mmc/core/sdio.c > === > --- mmc.orig/drivers/mmc/core/sdio.c 2007-08-07 > 00:38:33.0 +0100 +++ mmc/drivers/mmc/core/sdio.c >

[patch 2/4] sdio: set the functions' block size

2007-08-07 Thread David Vrabel
-- David Vrabel, Software Engineer, Drivers group Tel: +44 (0)1223 692562 CSR plc, Churchill House, Cambridge Business Park, Cowley Road, CB4 0WZ . sdio: set the functions' block size During function initialization, set the functions' block size to the largest that's suppor

Re: sdio: set the functions' block size

2007-08-06 Thread David Vrabel
Pierre Ossman wrote: > On Tue, 31 Jul 2007 16:36:32 +0100 > David Vrabel <[EMAIL PROTECTED]> wrote: > >> Prior to calling the driver's probe(), set the functions' block size >> to the largest that's supported by both the card and the driver. >> >> Signed-off-by: David Vrabel <[EMAIL PROTECTED]> >>

Re: sdio: set the functions' block size

2007-08-04 Thread Pierre Ossman
On Tue, 31 Jul 2007 16:36:32 +0100 David Vrabel <[EMAIL PROTECTED]> wrote: > Prior to calling the driver's probe(), set the functions' block size > to the largest that's supported by both the card and the driver. > > Signed-off-by: David Vrabel <[EMAIL PROTECTED]> > Why a maximum size for the d

sdio: set the functions' block size

2007-07-31 Thread David Vrabel
Prior to calling the driver's probe(), set the functions' block size to the largest that's supported by both the card and the driver. Signed-off-by: David Vrabel <[EMAIL PROTECTED]> --- commit 6d367fd822cbb2b8089ab7ef83f706f1984ab25b tree 8c9cc84b4c8c1c8f959abe540aa02f14aa95c51d parent 51755c3d59