Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-05-12 Thread Pavel Machek
On Wed 2015-05-06 11:45:04, Russell King - ARM Linux wrote: > On Tue, Apr 28, 2015 at 11:28:53AM -0400, Nicolas Pitre wrote: > > On Tue, 28 Apr 2015, Russell King - ARM Linux wrote: > > > > > On Fri, Apr 24, 2015 at 03:46:56PM +0200, Geert Uytterhoeven wrote: > > > > So please optimize ARM's _memc

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-05-06 Thread Nicolas Pitre
On Wed, 6 May 2015, Russell King - ARM Linux wrote: > On Tue, Apr 28, 2015 at 11:28:53AM -0400, Nicolas Pitre wrote: > > On Tue, 28 Apr 2015, Russell King - ARM Linux wrote: > > > > > On Fri, Apr 24, 2015 at 03:46:56PM +0200, Geert Uytterhoeven wrote: > > > > So please optimize ARM's _memcpy_from

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-05-06 Thread Russell King - ARM Linux
On Tue, Apr 28, 2015 at 11:28:53AM -0400, Nicolas Pitre wrote: > On Tue, 28 Apr 2015, Russell King - ARM Linux wrote: > > > On Fri, Apr 24, 2015 at 03:46:56PM +0200, Geert Uytterhoeven wrote: > > > So please optimize ARM's _memcpy_fromio(), _memcpy_toio(), and > > > _memset_io(). > > > That will

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-28 Thread Nicolas Pitre
On Tue, 28 Apr 2015, Russell King - ARM Linux wrote: > On Fri, Apr 24, 2015 at 03:46:56PM +0200, Geert Uytterhoeven wrote: > > So please optimize ARM's _memcpy_fromio(), _memcpy_toio(), and _memset_io(). > > That will benefit other drivers on ARM, too. > > That's not going to happen. > > I've ha

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-28 Thread Russell King - ARM Linux
On Fri, Apr 24, 2015 at 03:46:56PM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 24, 2015 at 3:40 PM, Tomi Valkeinen wrote: > > On 24/04/15 16:29, Pavel Machek wrote: > >> On Fri 2015-04-10 12:35:52, Archit Taneja wrote: > That said, if the fb is in RAM, and is only written by the CPU, I thi

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-26 Thread Pavel Machek
On Fri 2015-04-24 15:46:56, Geert Uytterhoeven wrote: > On Fri, Apr 24, 2015 at 3:40 PM, Tomi Valkeinen wrote: > > On 24/04/15 16:29, Pavel Machek wrote: > >> On Fri 2015-04-10 12:35:52, Archit Taneja wrote: > That said, if the fb is in RAM, and is only written by the CPU, I think > a no

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-24 Thread Geert Uytterhoeven
On Fri, Apr 24, 2015 at 3:40 PM, Tomi Valkeinen wrote: > On 24/04/15 16:29, Pavel Machek wrote: >> On Fri 2015-04-10 12:35:52, Archit Taneja wrote: That said, if the fb is in RAM, and is only written by the CPU, I think a normal memcpy() for fb_memcpy_fromfb() should be fine... >>> >>> I

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-24 Thread Tomi Valkeinen
On 24/04/15 16:29, Pavel Machek wrote: > Hi! > > On Fri 2015-04-10 12:35:52, Archit Taneja wrote: >>> That said, if the fb is in RAM, and is only written by the CPU, I think >>> a normal memcpy() for fb_memcpy_fromfb() should be fine... >> >> I didn't test for performance regressions when I posted

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-24 Thread Pavel Machek
> > The difference is probably caused by memcpy() vs memcpy_fromio(). The > > comment above memcpy_fromio() says "This needs to be optimized". I think > > generally speaking memcpy_fromio() is correct for a framebuffer. > > > > That said, if the fb is in RAM, and is only written by the CPU, I thi

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-24 Thread Pavel Machek
Hi! On Fri 2015-04-10 12:35:52, Archit Taneja wrote: > >That said, if the fb is in RAM, and is only written by the CPU, I think > >a normal memcpy() for fb_memcpy_fromfb() should be fine... > > I didn't test for performance regressions when I posted this patch. > > A look at _memcpy_fromio in ar

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-09 Thread Arnd Bergmann
On Thursday 09 April 2015 14:34:26 Tomi Valkeinen wrote: > On 09/04/15 14:21, Tomi Valkeinen wrote: > > On 09/04/15 14:06, Pavel Machek wrote: > >> On Tue 2015-04-07 14:19:33, Geert Uytterhoeven wrote: > >>> Hi Pavel, > >>> > >>> On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: > I have an

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-09 Thread Tomi Valkeinen
On 09/04/15 14:21, Tomi Valkeinen wrote: > On 09/04/15 14:06, Pavel Machek wrote: >> On Tue 2015-04-07 14:19:33, Geert Uytterhoeven wrote: >>> Hi Pavel, >>> >>> On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: I have an socfpga board, which uses has simple framebuffer implemented in t

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-09 Thread Tomi Valkeinen
On 09/04/15 14:06, Pavel Machek wrote: > On Tue 2015-04-07 14:19:33, Geert Uytterhoeven wrote: >> Hi Pavel, >> >> On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: >>> I have an socfpga board, which uses has simple framebuffer implemented >>> in the FPGA. On 3.15, framebuffer is fast: >>> >>> ro

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-09 Thread Pavel Machek
On Tue 2015-04-07 14:19:33, Geert Uytterhoeven wrote: > Hi Pavel, > > On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: > > I have an socfpga board, which uses has simple framebuffer implemented > > in the FPGA. On 3.15, framebuffer is fast: > > > > root@wagabuibui:~# time cat /dev/fb0 > /dev/n

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-07 Thread Marek Vasut
On Tuesday, April 07, 2015 at 02:19:33 PM, Geert Uytterhoeven wrote: > Hi Pavel, > > On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: > > I have an socfpga board, which uses has simple framebuffer implemented > > in the FPGA. On 3.15, framebuffer is fast: > > > > root@wagabuibui:~# time cat /

Re: simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-07 Thread Geert Uytterhoeven
Hi Pavel, On Tue, Apr 7, 2015 at 2:12 PM, Pavel Machek wrote: > I have an socfpga board, which uses has simple framebuffer implemented > in the FPGA. On 3.15, framebuffer is fast: > > root@wagabuibui:~# time cat /dev/fb0 > /dev/null > real 0m 0.00s > user 0m 0.00s > sy

simple framebuffer slower by factor of 20, on socfpga (arm) platform

2015-04-07 Thread Pavel Machek
Hi! I have an socfpga board, which uses has simple framebuffer implemented in the FPGA. On 3.15, framebuffer is fast: root@wagabuibui:~# time cat /dev/fb0 > /dev/null real 0m 0.00s user 0m 0.00s sys0m 0.00s on 3.18, this takes 220msec. Similar slowdown