Re: skge missing ifdefs.

2005-08-23 Thread Al Viro
On Mon, Aug 22, 2005 at 01:42:18PM -0700, Andrew Morton wrote: > Al Viro <[EMAIL PROTECTED]> wrote: > > > > mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] <<'EOF' > > > > Could you copy a mailing list on patches, please? Ask and you shall regret it - next iteration of patchbomb

Re: skge missing ifdefs.

2005-08-23 Thread Roman Zippel
Hi, On Tue, 23 Aug 2005, Al Viro wrote: > As for your s/thread_info/stack/ - I don't believe it's doable in mainline > right now. It's definitely separate from m68k merge and should not be > mixed into it. Moreover, mandatory changes to every platform arch-specific > code over basically

Re: skge missing ifdefs.

2005-08-23 Thread Al Viro
On Tue, Aug 23, 2005 at 12:24:19AM +0200, Roman Zippel wrote: > Hi, > > On Mon, 22 Aug 2005, Andrew Morton wrote: > > > Al Viro <[EMAIL PROTECTED]> wrote: > > > > > > mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] <<'EOF' > > > > > > > > Could you copy a mailing list on

Re: skge missing ifdefs.

2005-08-23 Thread Al Viro
On Tue, Aug 23, 2005 at 12:24:19AM +0200, Roman Zippel wrote: Hi, On Mon, 22 Aug 2005, Andrew Morton wrote: Al Viro [EMAIL PROTECTED] wrote: mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] 'EOF' wonders what the other 45 patches did Could you copy a mailing

Re: skge missing ifdefs.

2005-08-23 Thread Roman Zippel
Hi, On Tue, 23 Aug 2005, Al Viro wrote: As for your s/thread_info/stack/ - I don't believe it's doable in mainline right now. It's definitely separate from m68k merge and should not be mixed into it. Moreover, mandatory changes to every platform arch-specific code over basically cosmetic

Re: skge missing ifdefs.

2005-08-23 Thread Al Viro
On Mon, Aug 22, 2005 at 01:42:18PM -0700, Andrew Morton wrote: Al Viro [EMAIL PROTECTED] wrote: mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] 'EOF' wonders what the other 45 patches did Could you copy a mailing list on patches, please? Ask and you shall regret it -

Re: skge missing ifdefs.

2005-08-22 Thread Roman Zippel
Hi, On Mon, 22 Aug 2005, Andrew Morton wrote: > Al Viro <[EMAIL PROTECTED]> wrote: > > > > mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] <<'EOF' > > > > Could you copy a mailing list on patches, please? Seconded. Al, I'd like to know which of the m68k related patches you

Re: skge missing ifdefs.

2005-08-22 Thread Andrew Morton
Al Viro <[EMAIL PROTECTED]> wrote: > > mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] <<'EOF' Could you copy a mailing list on patches, please? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: skge missing ifdefs.

2005-08-22 Thread Dave Jones
On Mon, Aug 22, 2005 at 01:23:33PM -0700, Andrew Morton wrote: > Dave Jones <[EMAIL PROTECTED]> wrote: > > > > On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: > > > On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: > > > > with CONFIG_PM undefined, the build breaks

Re: skge missing ifdefs.

2005-08-22 Thread Al Viro
On Mon, Aug 22, 2005 at 01:23:33PM -0700, Andrew Morton wrote: > Works for me. CONFIG_PM=n, CONFIG_SKGE=y or m, CONFIG_SK98LIN=y or m. > > btw, is one of the recent `%td' fans going to, like, implement it in > printk()? Sent to Linus, sits in his queue... Last iteration had been mail -s

Re: skge missing ifdefs.

2005-08-22 Thread David S. Miller
From: Dave Jones <[EMAIL PROTECTED]> Date: Mon, 22 Aug 2005 15:59:13 -0400 > This is still broken afaics in todays -git. They are certainly there in Linus's current GIT tree. ... #ifdef CONFIG_PM static int skge_suspend(struct pci_dev *pdev, pm_message_t state) ... static int

Re: skge missing ifdefs.

2005-08-22 Thread Andrew Morton
Dave Jones <[EMAIL PROTECTED]> wrote: > > On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: > > On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: > > > with CONFIG_PM undefined, the build breaks due to > > > undefined symbols. > > > > akpm already sent a fix to Linus. >

Re: skge missing ifdefs.

2005-08-22 Thread Dave Jones
On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: > On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: > > with CONFIG_PM undefined, the build breaks due to > > undefined symbols. > > akpm already sent a fix to Linus. This is still broken afaics in todays -git.

Re: skge missing ifdefs.

2005-08-22 Thread Dave Jones
On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: with CONFIG_PM undefined, the build breaks due to undefined symbols. akpm already sent a fix to Linus. This is still broken afaics in todays -git.

Re: skge missing ifdefs.

2005-08-22 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Mon, 22 Aug 2005 15:59:13 -0400 This is still broken afaics in todays -git. They are certainly there in Linus's current GIT tree. ... #ifdef CONFIG_PM static int skge_suspend(struct pci_dev *pdev, pm_message_t state) ... static int skge_resume(struct

Re: skge missing ifdefs.

2005-08-22 Thread Andrew Morton
Dave Jones [EMAIL PROTECTED] wrote: On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: with CONFIG_PM undefined, the build breaks due to undefined symbols. akpm already sent a fix to Linus. This is still

Re: skge missing ifdefs.

2005-08-22 Thread Al Viro
On Mon, Aug 22, 2005 at 01:23:33PM -0700, Andrew Morton wrote: Works for me. CONFIG_PM=n, CONFIG_SKGE=y or m, CONFIG_SK98LIN=y or m. btw, is one of the recent `%td' fans going to, like, implement it in printk()? Sent to Linus, sits in his queue... Last iteration had been mail -s '[PATCH]

Re: skge missing ifdefs.

2005-08-22 Thread Dave Jones
On Mon, Aug 22, 2005 at 01:23:33PM -0700, Andrew Morton wrote: Dave Jones [EMAIL PROTECTED] wrote: On Mon, Aug 01, 2005 at 04:38:18PM -0400, Jeff Garzik wrote: On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: with CONFIG_PM undefined, the build breaks due to

Re: skge missing ifdefs.

2005-08-22 Thread Andrew Morton
Al Viro [EMAIL PROTECTED] wrote: mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] 'EOF' wonders what the other 45 patches did Could you copy a mailing list on patches, please? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: skge missing ifdefs.

2005-08-22 Thread Roman Zippel
Hi, On Mon, 22 Aug 2005, Andrew Morton wrote: Al Viro [EMAIL PROTECTED] wrote: mail -s '[PATCH] (45/46) %t... in vsnprintf' [EMAIL PROTECTED] 'EOF' wonders what the other 45 patches did Could you copy a mailing list on patches, please? Seconded. Al, I'd like to know which of the m68k

skge missing ifdefs.

2005-08-01 Thread Dave Jones
with CONFIG_PM undefined, the build breaks due to undefined symbols. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> -- linux-2.6.12/drivers/net/sk98lin/skge.c~ 2005-08-01 16:32:42.0 -0400 +++ linux-2.6.12/drivers/net/sk98lin/skge.c 2005-08-01 16:33:10.0 -0400 @@ -5233,8

Re: skge missing ifdefs.

2005-08-01 Thread Jeff Garzik
On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: > with CONFIG_PM undefined, the build breaks due to > undefined symbols. akpm already sent a fix to Linus. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: skge missing ifdefs.

2005-08-01 Thread Jeff Garzik
On Mon, Aug 01, 2005 at 04:34:42PM -0400, Dave Jones wrote: with CONFIG_PM undefined, the build breaks due to undefined symbols. akpm already sent a fix to Linus. Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

skge missing ifdefs.

2005-08-01 Thread Dave Jones
with CONFIG_PM undefined, the build breaks due to undefined symbols. Signed-off-by: Dave Jones [EMAIL PROTECTED] -- linux-2.6.12/drivers/net/sk98lin/skge.c~ 2005-08-01 16:32:42.0 -0400 +++ linux-2.6.12/drivers/net/sk98lin/skge.c 2005-08-01 16:33:10.0 -0400 @@ -5233,8