Re: slub: fix leak of 'name' in sysfs_slab_add

2014-03-07 Thread Christoph Lameter
On Fri, 7 Mar 2014, Dave Jones wrote: > > Since this function was modified in the mmotm tree, I would propose > > something like this on top of mmotm to avoid further merge conflicts: > > Looks good to me. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscrib

Re: slub: fix leak of 'name' in sysfs_slab_add

2014-03-07 Thread Dave Jones
On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote: > [adding Andrew to Cc] > > On 03/07/2014 01:11 AM, Dave Jones wrote: > > The failure paths of sysfs_slab_add don't release the allocation of 'name' > > made by create_unique_id() a few lines above the context of the diff below

Re: slub: fix leak of 'name' in sysfs_slab_add

2014-03-06 Thread Vladimir Davydov
[adding Andrew to Cc] On 03/07/2014 01:11 AM, Dave Jones wrote: > The failure paths of sysfs_slab_add don't release the allocation of 'name' > made by create_unique_id() a few lines above the context of the diff below. > Create a common exit path to make it more obvious what needs freeing. > > Si

slub: fix leak of 'name' in sysfs_slab_add

2014-03-06 Thread Dave Jones
The failure paths of sysfs_slab_add don't release the allocation of 'name' made by create_unique_id() a few lines above the context of the diff below. Create a common exit path to make it more obvious what needs freeing. Signed-off-by: Dave Jones diff --git a/mm/slub.c b/mm/slub.c index 25f14ad8