Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-31 Thread daniel
On Wed, Jul 29, 2020 at 02:28:01AM +0200, Paul Cercueil wrote: > > > Le mer. 29 juil. 2020 à 0:00, dan...@ffwll.ch a écrit : > > On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > > > Hi Paul. > > > > > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > > > Here

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread Paul Cercueil
Le mer. 29 juil. 2020 à 0:00, dan...@ffwll.ch a écrit : On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: Hi Paul. On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > Here are a few cleanups to the ingenic-drm driver. > - some error paths were missing and have be

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread daniel
On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote: > Hi Paul. > > On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > > Here are a few cleanups to the ingenic-drm driver. > > - some error paths were missing and have been added; > > - the mode validation has been moved to th

Re: [PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread Sam Ravnborg
Hi Paul. On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote: > Here are a few cleanups to the ingenic-drm driver. > - some error paths were missing and have been added; > - the mode validation has been moved to the .mode_valid helper callback. > > Cheers, > -Paul > > Paul Cercueil (2)

[PATCH 0/2] Small cleanups to ingenic-drm driver

2020-07-28 Thread Paul Cercueil
Here are a few cleanups to the ingenic-drm driver. - some error paths were missing and have been added; - the mode validation has been moved to the .mode_valid helper callback. Cheers, -Paul Paul Cercueil (2): drm/ingenic: Handle errors of drm_atomic_get_plane_state drm/ingenic: Validate mode

[PATCH] x86: intel_tlb_table: small cleanups

2019-09-15 Thread Sylvain 'ythier' Hitier
Remove the unneeded backslash at EOL: that's not a macro. And let's please checkpatch by aligning to open parenthesis. For 0x4f descriptor, remove " */" from the info field. For 0xc2 descriptor, sync the beginning of info to match the tlb_type. (The value of info fields could be made more regular

Re: [PATCH 0/5] EDAC: Small cleanups and fixes

2019-09-04 Thread Borislav Petkov
On Mon, Sep 02, 2019 at 05:17:16PM -0300, Mauro Carvalho Chehab wrote: > > Robert Richter (5): > > EDAC: Prefer 'unsigned int' to bare use of 'unsigned' > > EDAC, mc_sysfs: Change dev_ch_attribute->channel to unsigned int > > EDAC, mc_sysfs: Remove pointless gotos > > EDAC, mc_sysfs: Make d

Re: [PATCH 0/5] EDAC: Small cleanups and fixes

2019-09-02 Thread Mauro Carvalho Chehab
Em Mon, 2 Sep 2019 12:33:38 + Robert Richter escreveu: > A bunch of cleanups and fixes for issues found while working with the > code. Changes are individual and independent from each other. They can > be applied separately (only #4 depends on #3). > > Also updating the reviewer's entry as I

[PATCH 0/5] EDAC: Small cleanups and fixes

2019-09-02 Thread Robert Richter
A bunch of cleanups and fixes for issues found while working with the code. Changes are individual and independent from each other. They can be applied separately (only #4 depends on #3). Also updating the reviewer's entry as I will be able to do some reviews for edac code. Note that patch #3 is

[PATCH 0/4] gpio: stp-xway: small cleanups and improvements

2019-07-02 Thread Martin Blumenstingl
This series brings a few small cleanups and improvements to the stp-xway driver: - enable compile-testing - preparation for whenever the lantiq target switches to the common clock framework - easier to read (for me) None of these fixes any known bugs so there's no Fixes tag anywhere.

[PATCH 3/4] powerpc/livepatch: small cleanups in save_stack_trace_tsk_reliable()

2019-01-22 Thread Joe Lawrence
Mostly cosmetic changes: - Group common stack pointer code at the top - Simplify the first frame logic - Code stackframe iteration into for...loop construct - Check for trace->nr_entries overflow before adding any into the array Suggested-by: Nicolai Stange Signed-off-by: Joe Lawrence --- arch

[PATCH 0/3] of: overlay: Small cleanups

2018-03-09 Thread Geert Uytterhoeven
Hi all, This patch series contains two forgotten updates for the recent conversion to FDT overlays, and removes a function that was never used (not even in out-of-tree overlay ConfigFS ;-). Geert Uytterhoeven (3): of: Documentation: Fix forgotten reference to of_overlay_apply() of: ov

[PATCH 0/2] net: thunderx: Small cleanups

2016-02-18 Thread Robert Richter
From: Robert Richter Sending two small cleanups of the driver fixing issues found during code review. Robert Richter (2): net: thunderx: Fix const type in nicvf_set_rxfh() net, thunderx: Use bool in structs where possible drivers/net/ethernet/cavium/thunder/nic.h | 12

[PATCH 0/2] cpufreq: ondemand: Small cleanups

2016-02-16 Thread Rafael J. Wysocki
Hi, Two cleanups for the ondemand governor. [1/2] rearranges some code to avoid duplication. [2/2] drops a governor-specific callback that's never used. Both on top of the linux-next branch of the linux-pm.git tree from today. Thanks, Rafael

[PATCH 0/2] irqchip/gic-v3: Small cleanups for 4.4

2015-12-07 Thread Marc Zyngier
Thomas, Jason, I've been sitting on a couple of one-liners that affect GICv3. Nothing dramatic (and certainly nothing that affects mainline today), but they do get in the way of a KVM/ARM series that is aimed at 4.5 [1], and I'd like to make sure we don't have too many ordering issues. Alternativ

[PATCH 0/2] mfd: cros_ec: Small cleanups

2015-05-20 Thread Javier Martinez Canillas
Hello Lee, These two patches were posted before as a part of the "mfd: cros_ec: Add multi EC and proto v3 support" [0] series but I split on a new series because these are simple enough and you already ack them so should not be blocked by the more controversial ones. I kept the original history

Re: [PATCH 0/2] kmx61: Small cleanups

2014-11-22 Thread Jonathan Cameron
On 17/11/14 15:09, Daniel Baluta wrote: > On Mon, Nov 17, 2014 at 4:59 PM, Jonathan Cameron wrote: >> >> >> On November 17, 2014 1:18:34 PM GMT+00:00, Daniel Baluta >> wrote: >>> This is a small cleanup patchset, that: >>> * makes it clear that kmx61 uses only the micro part of scale >>>

Re: [PATCH 0/2] kmx61: Small cleanups

2014-11-17 Thread Daniel Baluta
On Mon, Nov 17, 2014 at 4:59 PM, Jonathan Cameron wrote: > > > On November 17, 2014 1:18:34 PM GMT+00:00, Daniel Baluta > wrote: >>This is a small cleanup patchset, that: >> * makes it clear that kmx61 uses only the micro part of scale >> * use macro instead of hardcoded value for dr

Re: [PATCH 0/2] kmx61: Small cleanups

2014-11-17 Thread Jonathan Cameron
On November 17, 2014 1:18:34 PM GMT+00:00, Daniel Baluta wrote: >This is a small cleanup patchset, that: > * makes it clear that kmx61 uses only the micro part of scale > * use macro instead of hardcoded value for driver name > >Jonathan, if you think it's worth it, these could be s

[PATCH 0/2] kmx61: Small cleanups

2014-11-17 Thread Daniel Baluta
This is a small cleanup patchset, that: * makes it clear that kmx61 uses only the micro part of scale * use macro instead of hardcoded value for driver name Jonathan, if you think it's worth it, these could be squased together with the initial patch submitted in testing: 61

[PATCH 0/2] intel-rst: Small cleanups

2014-09-16 Thread Peter Ujfalusi
Hi, While trying to figure out why the intel-rst driver was not probing on my new laptop (which turned out to be a differnet issue) I looked at the intel-rst driver for clues and while reading the code I thought that these small changes might be a good thing to send upstream. Regards, Peter --- P

[PATCH 0/2] staging: rtl8723au: Small cleanups

2014-08-07 Thread Andreas Schlick
Andreas Schlick (2): staging: rtl8723au: Move open braces to the previous line. staging: rtl8723au: Remove unnecessary bit masking. drivers/staging/rtl8723au/core/rtw_efuse.c | 34 ++ 1 file changed, 11 insertions(+), 23 deletions(-) -- 2.0.4 -- To unsubscribe f

[PATCH 0/4] drm/exynos/mixer: small cleanups

2014-05-04 Thread Daniel Kurtz
I don't actually have a way of testing the video processor changes, but they seem correct from looking at the code. Hopefully someone has a way of testing them. Daniel Kurtz (4): drm/exynos/mixer: move format definitions to regs-mixer drm/exynos/mixer: use MXR_GRP_SXY_SY drm/exynos/mixer: p

Re: [6/9] thermal: exynos: small cleanups to prepare for adding exynos5440 driver

2013-04-12 Thread amit daniel kachhap
Hi Eduardo, On Fri, Apr 12, 2013 at 2:24 AM, Eduardo Valentin wrote: > Amit, > > > On 26-03-2013 07:33, Amit Daniel Kachhap wrote: >> >> Add calib mode, trigger types and trigger_enable array. This is needed >> for adding exynos5440 TMU driver. >> > >

Re: [6/9] thermal: exynos: small cleanups to prepare for adding exynos5440 driver

2013-04-11 Thread Eduardo Valentin
Amit, On 26-03-2013 07:33, Amit Daniel Kachhap wrote: Add calib mode, trigger types and trigger_enable array. This is needed for adding exynos5440 TMU driver. I dont think the above are small cleanups. I d rather split this patch into three, one per change and describe them properly

[PATCH 6/9] thermal: exynos: small cleanups to prepare for adding exynos5440 driver

2013-03-26 Thread Amit Daniel Kachhap
Add calib mode, trigger types and trigger_enable array. This is needed for adding exynos5440 TMU driver. Signed-off-by: Amit Daniel Kachhap --- drivers/thermal/samsung/exynos4210_thermal.c | 30 include/linux/platform_data/exynos_thermal.h | 32 +-

Re: [PATCH 0/6] some small cleanups for palmas and DT support

2012-09-19 Thread Graeme Gregory
On 19/09/12 16:30, Samuel Ortiz wrote: > Hi Graeme, > > On Tue, Aug 28, 2012 at 01:47:34PM +0200, Graeme Gregory wrote: >> This series does a couple of small improvements to the palmas mfd and >> regulator drivers. It does a little re-organisation of the header file >> to better implement DT in reg

Re: [PATCH 0/6] some small cleanups for palmas and DT support

2012-09-19 Thread Samuel Ortiz
Hi Graeme, On Tue, Aug 28, 2012 at 01:47:34PM +0200, Graeme Gregory wrote: > This series does a couple of small improvements to the palmas mfd and > regulator drivers. It does a little re-organisation of the header file > to better implement DT in regulator driver and then add DT handling. I appli

[PATCH 0/6] some small cleanups for palmas and DT support

2012-08-28 Thread Graeme Gregory
This series does a couple of small improvements to the palmas mfd and regulator drivers. It does a little re-organisation of the header file to better implement DT in regulator driver and then add DT handling. Graeme -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v3

2012-08-20 Thread Frederic Weisbecker
On Mon, Aug 20, 2012 at 10:40:12AM +0200, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > Hi, > > > > In this v3: > > > > - Rebase against latest tip:sched/core > > - Added acks from Martin > > - Refined help text for the consolidated CONFIG_VIRT_CPU_ACCOUNTING option > > in the 1st

[PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v3

2012-08-17 Thread Frederic Weisbecker
Hi, In this v3: - Rebase against latest tip:sched/core - Added acks from Martin - Refined help text for the consolidated CONFIG_VIRT_CPU_ACCOUNTING option in the 1st patch. You can pull from: git://github.com/fweisbec/linux-dynticks.git virt-cputime-v3 Thanks. Frederic Weisbecker (4):

Re: [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v2

2012-08-14 Thread Frederic Weisbecker
On Tue, Aug 14, 2012 at 04:16:46PM +0200, Frederic Weisbecker wrote: > Hi, > > No fundamental change in this release but a rebase to solve conflicts > against latest tip:/sched/core commits. > > Thanks. This can be pulled from: git://github.com/fweisbec/linux-dynticks.git virt-cputime-v

[PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation v2

2012-08-14 Thread Frederic Weisbecker
Hi, No fundamental change in this release but a rebase to solve conflicts against latest tip:/sched/core commits. Thanks. Frederic Weisbecker (4): cputime: Generalize CONFIG_VIRT_CPU_ACCOUNTING sched: Move cputime code to its own file cputime: Consolidate vtime handling on context switch

Re: [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation

2012-08-03 Thread Frederic Weisbecker
2012/7/9 Frederic Weisbecker : > On Tue, Jun 19, 2012 at 03:43:07PM +0200, Frederic Weisbecker wrote: >> Not sure to which tree this should go. The scheduler one may be. >> Anyway if you're fine with it, it is pullable at: >> >> git://github.com/fweisbec/linux-dynticks.git >> virt-cputime > >

Re: [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation

2012-07-09 Thread Benjamin Herrenschmidt
On Mon, 2012-07-09 at 19:50 +0200, Frederic Weisbecker wrote: > On Tue, Jun 19, 2012 at 03:43:07PM +0200, Frederic Weisbecker wrote: > > Not sure to which tree this should go. The scheduler one may be. > > Anyway if you're fine with it, it is pullable at: > > > > git://github.com/fweisbec/linux-dy

Re: [PATCH 0/4] cputime: Virtual cputime accounting small cleanups and consolidation

2012-07-09 Thread Frederic Weisbecker
On Tue, Jun 19, 2012 at 03:43:07PM +0200, Frederic Weisbecker wrote: > Not sure to which tree this should go. The scheduler one may be. > Anyway if you're fine with it, it is pullable at: > > git://github.com/fweisbec/linux-dynticks.git > virt-cputime Ping. Are you guys fine with the patchs

small cleanups

2008-02-04 Thread Pavel Machek
These are small cleanups all over the tree. Please apply, Signed-off-by: Pavel Machek <[EMAIL PROTECTED]> diff --git a/fs/select.c b/fs/select.c index 47f4792..c414aed 100644 --- a/fs/select.c +++ b/fs/select.c @@ -260,7 +260,7 @@ int do_select(int n, fd_set_bits *fds, s

Re: [PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup (V2)

2007-05-06 Thread Christoph Hellwig
On Sun, May 06, 2007 at 01:47:54PM -0400, Josef 'Jeff' Sipek wrote: > (For changes since V1, see the end of this email.) > > The following 2 patches are trivial cleanups to do_path_lookup in namei.c. > Since these changes are trivial, they can go into 2.6.22-rc1 without any > problems. > > Josef

[PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup (V2)

2007-05-06 Thread Josef 'Jeff' Sipek
(For changes since V1, see the end of this email.) The following 2 patches are trivial cleanups to do_path_lookup in namei.c. Since these changes are trivial, they can go into 2.6.22-rc1 without any problems. Josef 'Jeff' Sipek (2): fs: Fix indentation in do_path_lookup fs: Use path_w

[PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup

2007-05-05 Thread Josef 'Jeff' Sipek
The following 2 patches are trivial cleanups to do_path_lookup in namei.c. Since these changes are trivial, they can go into 2.6.22-rc1 without any problems. Josef 'Jeff' Sipek (2): fs: Fix indentation in do_path_lookup fs: Use path_walk in do_path_lookup diffstat for good measure:

[PATCH 04/13] fs/unionfs/: Several small cleanups in unionfs_interpose

2007-03-04 Thread Josef 'Jeff' Sipek
1) No need to lock the inode - lockdep was complaining about potential circular dependency 2) No need to use temporary variable for iunique() inode number 3) Removed unneeded comment Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 11 ++- 1 files changed,

Re: [ckrm-tech] [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Balbir Singh
Paul Menage wrote: > On 1/15/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> While writing/extending the cpuacct container, I found it useful to >> know if the container resource group we are controlling is really mounted. >> Controllers can try and avoid doing work when not mounted and start >> whe

Re: [ckrm-tech] [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Paul Menage
On 1/15/07, Balbir Singh <[EMAIL PROTECTED]> wrote: While writing/extending the cpuacct container, I found it useful to know if the container resource group we are controlling is really mounted. Controllers can try and avoid doing work when not mounted and start when the subsystem is mounted. Al

Re: [ckrm-tech] [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Balbir Singh
Paul Menage wrote: > On 1/15/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> In sched.c, account_user_time() can be called with the task p set to >> rq->idle. >> Since idle tasks do not belong to any container, this was causing a panic in >> task_ca() in cpu_acct.c. > > How come that didn't cause

Re: [PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Paul Menage
On 1/15/07, Balbir Singh <[EMAIL PROTECTED]> wrote: In sched.c, account_user_time() can be called with the task p set to rq->idle. Since idle tasks do not belong to any container, this was causing a panic in task_ca() in cpu_acct.c. How come that didn't cause a problem on x86_64? If this is an

[PATCH 1/1] Fix a panic while mouting containers on powerpc and some other small cleanups (Re: [ckrm-tech] [PATCH 4/6] containers: Simple CPU accounting container subsystem)

2007-01-15 Thread Balbir Singh
Balbir Singh wrote: > Paul Menage wrote: >> On 1/10/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >>> I have run into a problem running this patch on a powerpc box. Basically, >>> the machine panics as soon as I mount the container filesystem with >> This is a multi-processor system? >> > Hi, Paul, >

Re: [2.6 patch] lib/sort.c: small cleanups

2005-09-04 Thread Ingo Oeser
On Saturday 03 September 2005 15:25, Adrian Bunk wrote: > This patch contains the following small cleanups: > - make two needlessly global functions static > - every file should #include the header files containing the prototypes > of it's global functions While this is a n

[2.6 patch] lib/sort.c: small cleanups

2005-09-03 Thread Adrian Bunk
This patch contains the following small cleanups: - make two needlessly global functions static - every file should #include the header files containing the prototypes of it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.13-mm1-full/lib/sort.c.old

[2.6 patch] drivers/char/drm/: small cleanups

2005-09-01 Thread Adrian Bunk
This patch contains the following small cleanups: - make two needlessly global functions static - drm_sysfs.c: every file should #include the header with the prototypes of the global functions it is offering Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This pat

[2.6 patch] drivers/char/drm/: small cleanups

2005-08-24 Thread Adrian Bunk
This patch contains the following small cleanups: - make two needlessly global functions static - drm_sysfs.c: every file should #include the header with the prototypes of the global functions it is offering Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/ch

Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

2005-03-23 Thread Jeff Garzik
Randy.Dunlap wrote: Christoph Lameter wrote: We just send an update to Andrew and Jeff that also fixes this issue. Sadly that patch is >300k so we cannot post it to the list. you can post it to netdev@oss.sgi.com it doesn't seem to block large patches. Well, it's still not kosher to send large pa

Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

2005-03-23 Thread Christoph Lameter
On Wed, 23 Mar 2005, Randy.Dunlap wrote: > Christoph Lameter wrote: > > We just send an update to Andrew and Jeff that also fixes this issue. > > Sadly that patch is >300k so we cannot post it to the list. > > you can post it to netdev@oss.sgi.com > it doesn't seem to block large patches. Ok. Sen

Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

2005-03-23 Thread Randy.Dunlap
Christoph Lameter wrote: We just send an update to Andrew and Jeff that also fixes this issue. Sadly that patch is >300k so we cannot post it to the list. you can post it to netdev@oss.sgi.com it doesn't seem to block large patches. -- ~Randy - To unsubscribe from this list: send the line "unsubscr

Re: [-mm patch] drivers/net/chelsio/osdep.h: small cleanups

2005-03-23 Thread Christoph Lameter
We just send an update to Andrew and Jeff that also fixes this issue. Sadly that patch is >300k so we cannot post it to the list. On Thu, 24 Mar 2005, Adrian Bunk wrote: > The #define MODVERSIONS doesn't make sense. > > And there's no need to #ifdef an #include . > > Signed-off-by: Adrian Bunk <[

[-mm patch] drivers/net/chelsio/osdep.h: small cleanups

2005-03-23 Thread Adrian Bunk
The #define MODVERSIONS doesn't make sense. And there's no need to #ifdef an #include . Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h.old 2005-03-24 01:20:02.0 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/net/chelsio/osdep.h

[2.6 patch] drivers/char/mwave/smapi.c: small cleanups

2005-02-24 Thread Adrian Bunk
This patch contains the following cleanups: - make the needlessly global function smapi_request static - #if 0 the currently unused function SmapiQuerySystemID Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 31 Jan 2005 drivers/char/mwave/smapi.c | 16 +++

[2.6 patch] drivers/char/mwave/smapi.c: small cleanups

2005-01-31 Thread Adrian Bunk
This patch contains the following cleanups: - make the needlessly global function smapi_request static - #if 0 the currently unused function SmapiQuerySystemID Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/char/mwave/smapi.c | 16 1 files changed, 8 insertions(+)

[FIX] Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-30 Thread Al Viro
On Sun, Jan 30, 2005 at 12:54:30AM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sun, 30 Jan 2005 00:46:24 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > Hi, > > > > > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bun

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Bartlomiej Zolnierkiewicz
On Sun, 30 Jan 2005 00:46:24 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch makes the needlessly global function is

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Adrian Bunk
On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > Hi, > > On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > > This patch makes the needlessly global function isp16_init static. > > > > As a result, it turned out that both this function and som

Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Bartlomiej Zolnierkiewicz
Hi, On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch makes the needlessly global function isp16_init static. > > As a result, it turned out that both this function and some other code > are only required #ifdef MODULE. Your patch is correct but it is wrong.

[2.6 patch] drivers/cdrom/isp16.c: small cleanups

2005-01-29 Thread Adrian Bunk
This patch makes the needlessly global function isp16_init static. As a result, it turned out that both this function and some other code are only required #ifdef MODULE. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/cdrom/isp16.c | 13 - drivers/cdrom/isp16.h |

RE: [2.6 patch] drivers/block/cpqarray.c: small cleanups

2005-01-25 Thread Miller, Mike (OS Dev)
> -Original Message- > This patch contains the following cleanups: > - make cpqarray_pci_device_id static > - merge cpqarray_init_step2 into cpqarray_init and make it static > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Mike Miller <[EMAIL PROTECTED]> > > --- > > drive

[2.6 patch] drivers/block/cpqarray.c: small cleanups

2005-01-25 Thread Adrian Bunk
This patch contains the following cleanups: - make cpqarray_pci_device_id static - merge cpqarray_init_step2 into cpqarray_init and make it static Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/block/cpqarray.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-)