Re: smart gcc inliner...

2007-03-30 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: > On Tue, Mar 27, 2007 at 07:55:38PM -0700, Jeremy Fitzhardinge wrote: > >> Andi Kleen wrote: >> >>> init functions should only ever be called from other init functions. >>> >>> So this should not happen. If it happens the annotations need to be fixed. >>> >> I've

Re: smart gcc inliner...

2007-03-30 Thread Adrian Bunk
On Tue, Mar 27, 2007 at 07:55:38PM -0700, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > > init functions should only ever be called from other init functions. > > > > So this should not happen. If it happens the annotations need to be fixed. > > I've seen some versions of gcc inline weak

Re: smart gcc inliner...

2007-03-30 Thread Adrian Bunk
On Tue, Mar 27, 2007 at 07:55:38PM -0700, Jeremy Fitzhardinge wrote: Andi Kleen wrote: init functions should only ever be called from other init functions. So this should not happen. If it happens the annotations need to be fixed. I've seen some versions of gcc inline weak functions too.

Re: smart gcc inliner...

2007-03-30 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: On Tue, Mar 27, 2007 at 07:55:38PM -0700, Jeremy Fitzhardinge wrote: Andi Kleen wrote: init functions should only ever be called from other init functions. So this should not happen. If it happens the annotations need to be fixed. I've seen some versions

Re: smart gcc inliner...

2007-03-27 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > init functions should only ever be called from other init functions. > > So this should not happen. If it happens the annotations need to be fixed. > I've seen some versions of gcc inline weak functions too. J - To unsubscribe from this list: send the line "unsubscribe

Re: smart gcc inliner...

2007-03-27 Thread Jan Engelhardt
On Mar 27 2007 17:07, Paweł Sikora wrote: > > The recent gcc (3.4/4.x) optimizer inlines functions across > sections which is definitely not we want, e.g. inlining > functions from .init.text section. > > I think, the `__init' macro needs `noinline' attribute and all An function from the .init

Re: smart gcc inliner...

2007-03-27 Thread Andi Kleen
Paweł Sikora <[EMAIL PROTECTED]> writes: > Hi, > > The recent gcc (3.4/4.x) optimizer inlines functions across > sections which is definitely not we want, e.g. inlining > functions from .init.text section. > > I think, the `__init' macro needs `noinline' attribute and all > the `static inline

smart gcc inliner...

2007-03-27 Thread Paweł Sikora
Hi, The recent gcc (3.4/4.x) optimizer inlines functions across sections which is definitely not we want, e.g. inlining functions from .init.text section. I think, the `__init' macro needs `noinline' attribute and all the `static inline __{dev}init' functions need `inline' attribute removal to

smart gcc inliner...

2007-03-27 Thread Paweł Sikora
Hi, The recent gcc (3.4/4.x) optimizer inlines functions across sections which is definitely not we want, e.g. inlining functions from .init.text section. I think, the `__init' macro needs `noinline' attribute and all the `static inline __{dev}init' functions need `inline' attribute removal to

Re: smart gcc inliner...

2007-03-27 Thread Andi Kleen
Paweł Sikora [EMAIL PROTECTED] writes: Hi, The recent gcc (3.4/4.x) optimizer inlines functions across sections which is definitely not we want, e.g. inlining functions from .init.text section. I think, the `__init' macro needs `noinline' attribute and all the `static inline

Re: smart gcc inliner...

2007-03-27 Thread Jan Engelhardt
On Mar 27 2007 17:07, Paweł Sikora wrote: The recent gcc (3.4/4.x) optimizer inlines functions across sections which is definitely not we want, e.g. inlining functions from .init.text section. I think, the `__init' macro needs `noinline' attribute and all An function from the .init section

Re: smart gcc inliner...

2007-03-27 Thread Jeremy Fitzhardinge
Andi Kleen wrote: init functions should only ever be called from other init functions. So this should not happen. If it happens the annotations need to be fixed. I've seen some versions of gcc inline weak functions too. J - To unsubscribe from this list: send the line unsubscribe