Re: sound: bebop: strncmp length oddity

2016-11-17 Thread Nicolas Iooss
On 17/11/16 21:07, Takashi Sakamoto wrote: > On Nov 17 2016 20:47, Takashi Iwai wrote: >> On Sat, 29 Oct 2016 23:37:00 +0200, >> Joe Perches wrote: >>> >>> 15 isn't the length of the string, is that really what's desired? >>> >>> linux/next/sound/firewire/bebob/bebop.c >>> >>> -

Re: sound: bebop: strncmp length oddity

2016-11-17 Thread Takashi Sakamoto
s/bebop/bebob/ (BeBoB is 'BridgeCo enhanced Breakout Box'.) I'm sorry to miss this post, Joe. I was busy to prepare for Audio mini-conference on Linux Plumber Conference. I realized that Nicolas posted a patch for this issue. [alsa-devel] [PATCH 1/1] ALSA: bebob: use the right string length i

Re: [alsa-devel] sound: bebop: strncmp length oddity

2016-11-17 Thread Takashi Iwai
On Sat, 29 Oct 2016 23:37:00 +0200, Joe Perches wrote: > > 15 isn't the length of the string, is that really what's desired? > > linux/next/sound/firewire/bebob/bebop.c > > - > > static bool > check_audiophile_booted(struct fw_unit *unit) > { > char name[24] =

sound: bebop: strncmp length oddity

2016-10-29 Thread Joe Perches
15 isn't the length of the string, is that really what's desired? linux/next/sound/firewire/bebob/bebop.c - static bool check_audiophile_booted(struct fw_unit *unit) { char name[24] = {0}; if (fw_csr_string(unit->directory, CSR_MODEL, name, sizeof(nam