Re: sparse warnings in overflow.h

2018-06-07 Thread Luc Van Oostenryck
On Thu, Jun 07, 2018 at 09:25:09PM +0200, Rasmus Villemoes wrote: > > IIRC, the problem is that sparse pretends to be the gcc sparse itself > was built with, which is obviously entirely unrelated to the C dialect > that that particular sparse version groks. Sigh. Ack to the fix above. Yes, indeed

Re: sparse warnings in overflow.h

2018-06-07 Thread Rasmus Villemoes
On 2018-06-07 20:35, Kees Cook wrote: > On Thu, Jun 7, 2018 at 4:01 AM, Miroslav Benes wrote: >> >> Hi Kees, >> >> sparse (make C=1) gives me this warnings today... >> >> ./include/linux/overflow.h:254:13: error: undefined identifier >> '__builtin_mul_overflow' >> ./include/linux/overflow.h:254:1

Re: sparse warnings in overflow.h

2018-06-07 Thread Kees Cook
On Thu, Jun 7, 2018 at 4:01 AM, Miroslav Benes wrote: > > Hi Kees, > > sparse (make C=1) gives me this warnings today... > > ./include/linux/overflow.h:254:13: error: undefined identifier > '__builtin_mul_overflow' > ./include/linux/overflow.h:254:13: error: incorrect type in conditional > ./incl

sparse warnings in overflow.h

2018-06-07 Thread Miroslav Benes
Hi Kees, sparse (make C=1) gives me this warnings today... ./include/linux/overflow.h:254:13: error: undefined identifier '__builtin_mul_overflow' ./include/linux/overflow.h:254:13: error: incorrect type in conditional ./include/linux/overflow.h:254:13:got void ./include/linux/overflow.h:2