Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Andrew Morton wrote: > On Tue, 12 Jun 2007 20:15:41 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Tue, Jun 12 2007, Jens Axboe wrote: > > > On Tue, Jun 12 2007, Andrew Morton wrote: > > > > On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > >

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Andrew Morton
On Tue, 12 Jun 2007 20:15:41 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Jun 12 2007, Jens Axboe wrote: > > On Tue, Jun 12 2007, Andrew Morton wrote: > > > On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > splice > > > > > > btw, I'm staring in prof

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Jens Axboe wrote: > On Tue, Jun 12 2007, Andrew Morton wrote: > > On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > splice > > > > btw, I'm staring in profound mystification at this: > > > > int generic_pipe_buf_steal(struct pipe_inode_info *

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Andrew Morton wrote: > On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > > splice > > btw, I'm staring in profound mystification at this: > > int generic_pipe_buf_steal(struct pipe_inode_info *pipe, > struct pipe_buffer *bu

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Andrew Morton
On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > splice btw, I'm staring in profound mystification at this: int generic_pipe_buf_steal(struct pipe_inode_info *pipe, struct pipe_buffer *buf) { struct page *page = buf->page; if

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Andrew Morton
On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Tue, Jun 12 2007, Peter Zijlstra wrote: > > On Tue, 2007-06-12 at 14:10 +0200, Jens Axboe wrote: > > > On Tue, Jun 12 2007, Peter Zijlstra wrote: > > > > On Tue, 2007-06-12 at 13:31 +0200, Jens Axboe wrote: > > > > > >

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Peter Zijlstra wrote: > On Tue, 2007-06-12 at 14:10 +0200, Jens Axboe wrote: > > On Tue, Jun 12 2007, Peter Zijlstra wrote: > > > On Tue, 2007-06-12 at 13:31 +0200, Jens Axboe wrote: > > > > > > > Would you prefer this change, then? I'd prefer keeping the current code, > > > >

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Peter Zijlstra
On Tue, 2007-06-12 at 14:10 +0200, Jens Axboe wrote: > On Tue, Jun 12 2007, Peter Zijlstra wrote: > > On Tue, 2007-06-12 at 13:31 +0200, Jens Axboe wrote: > > > > > Would you prefer this change, then? I'd prefer keeping the current code, > > > unless it's absolutely critical that we call > > > bal

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Peter Zijlstra wrote: > On Tue, 2007-06-12 at 13:31 +0200, Jens Axboe wrote: > > > Would you prefer this change, then? I'd prefer keeping the current code, > > unless it's absolutely critical that we call > > balance_dirty_pages_ratelimited() for each and every page instead of

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Peter Zijlstra
On Tue, 2007-06-12 at 13:31 +0200, Jens Axboe wrote: > Would you prefer this change, then? I'd prefer keeping the current code, > unless it's absolutely critical that we call > balance_dirty_pages_ratelimited() for each and every page instead of eg > every 16 pages here. For that we should call:

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
gt; Author: Jens Axboe <[EMAIL PROTECTED]> > > > > AuthorDate: Tue Jun 5 11:05:11 2007 +0200 > > > > Committer: Jens Axboe <[EMAIL PROTECTED]> > > > > CommitDate: Fri Jun 8 08:33:59 2007 +0200 > > > > > > > > splice: move balance_d

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-12 Thread Jens Axboe
+0200 > > > Committer: Jens Axboe <[EMAIL PROTECTED]> > > > CommitDate: Fri Jun 8 08:33:59 2007 +0200 > > > > > > splice: move balance_dirty_pages_ratelimited() outside of splice actor > > > > > > I've seen inode relat

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-11 Thread Jens Axboe
; CommitDate: Fri Jun 8 08:33:59 2007 +0200 > > > > splice: move balance_dirty_pages_ratelimited() outside of splice actor > > > > I've seen inode related deadlocks, so move this call outside of the > > actor itself, which may hold the inode lock. > >

Re: splice: move balance_dirty_pages_ratelimited() outside of splice actor

2007-06-11 Thread Andrew Morton
> Parent: 17374ff1aa9ce2a0597416a16729474b538af443 > Author: Jens Axboe <[EMAIL PROTECTED]> > AuthorDate: Tue Jun 5 11:05:11 2007 +0200 > Committer: Jens Axboe <[EMAIL PROTECTED]> > CommitDate: Fri Jun 8 08:33:59 2007 +0200 > > splice: move balance_dirty_pages_ratelimited() outs