From: Markus Elfring
Date: Wed, 10 Aug 2016 17:57:50 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
v2: Rebased on the source files from Linux next-20160809.
Touched four source code places less.
drivers/staging/ks7010/ks7010_s
> I have a lot of other things to work on, of much greater interest (to me.)
This is fine.
Thanks for your feedback.
>>> Personally I see no value in such statistics.
>>
>> Do they indicate any code smells eventually?
>
> I have no idea what you mean, sorry.
How do you think about to take ano
Hello Markus,
On lun., 2016-07-25 at 18:19 +0200, SF Markus Elfring wrote:
> >> Would you like to support the renaming of a label like "error_out1"
> >> (in the function "ks7010_upload_firmware" for example)?
> >
> > They should be renamed too. Anything using numbers instead of explicit
>
> Inte
>> Would you like to support the renaming of a label like "error_out1"
>> (in the function "ks7010_upload_firmware" for example)?
>
> They should be renamed too. Anything using numbers instead of explicit
Interesting …
> Anything using numbers instead of explicit labels should be updated.
Woul
Hi Markus,
On Thu, 21 Jul 2016 22:11:53 +0200, SF Markus Elfring wrote:
> >> How do you generally think about jump label renaming?
> >
> > Renaming from "out0:", "out1:" etc to something meaningful, yes.
>
> I suggest to take another look at such identifiers.
>
> Would you like to support the r
Hi Markus,
On Thu, 21 Jul 2016 09:55:55 +0200, SF Markus Elfring wrote:
> > > How do you think about information from the chapter "7: Centralized
> > > exiting of functions"?
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle?id=47ef4ad2684d380dd6
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326
>
> "#goto labels aren't indented, allow a single space however"
>
> Can't be clearer :-)
Should such information from a comment in this script be also
Hi Markus,
On Thu, 21 Jul 2016 17:37:52 +0200, SF Markus Elfring wrote:
> > That being said... checkpatch does not complain about leading space
> > before labels. Not even with --strict. So why are you mentioning it here?
>
> I remembered a warning like "INDENTED_LABEL" instead.
> https://git.ker
> That being said... checkpatch does not complain about leading space
> before labels. Not even with --strict. So why are you mentioning it here?
I remembered a warning like "INDENTED_LABEL" instead.
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d2
> > How do you think about information from the chapter "7: Centralized exiting
> > of functions"?
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle?id=47ef4ad2684d380dd6d596140fb79395115c3950#n389
>
> I'm not impressed by this piece of documentati
Thank you very much for the heads up, Jean!
signature.asc
Description: PGP signature
Hello Markus, Wolfram,
On Wed, 20 Jul 2016 20:21:25 +0200, SF Markus Elfring wrote:
> >> Adjust jump targets according to the Linux coding style convention.
> >
> > Really? Is that documented somewhere?
>
> How do you think about information from the chapter "7: Centralized exiting
> of functio
>> Adjust jump targets according to the Linux coding style convention.
>
> Really? Is that documented somewhere?
How do you think about information from the chapter "7: Centralized exiting of
functions"?
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingSty
On Sun, Jul 17, 2016 at 08:20:12PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 16:26:18 +0200
>
> Adjust jump targets according to the Linux coding style convention.
Really? Is that documented somewhere?
Quoting Jean Delvare:
"> It is generally accepted to i
From: Markus Elfring
Date: Sun, 17 Jul 2016 16:26:18 +0200
Adjust jump targets according to the Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/staging/ks7010/ks7010_sdio.c | 81 +---
1 file changed, 38 insertions(+), 43 deletions(-)
di
15 matches
Mail list logo